-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Unskip test. #162106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unskip test. #162106
Conversation
yjbanov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request is not mergeable
|
A reason for requesting a revert of flutter/flutter/162106 could |
|
Reason for revert: causing test breakage on web. See: https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20linux_web_engine_tests/270/infra |
This reverts commit 8d00bd9.
<!-- start_original_pr_link --> Reverts: #162106 <!-- end_original_pr_link --> <!-- start_initiating_author --> Initiated by: harryterkelsen <!-- end_initiating_author --> <!-- start_revert_reason --> Reason for reverting: causing test breakage on web. See: https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20linux_web_engine_tests/270/infra <!-- end_revert_reason --> <!-- start_original_pr_author --> Original PR Author: polina-c <!-- end_original_pr_author --> <!-- start_reviewers --> Reviewed By: {yjbanov} <!-- end_reviewers --> <!-- start_revert_body --> This change reverts the following previous change: No description provided. <!-- end_revert_body --> Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
<!-- start_original_pr_link --> Reverts: flutter#162106 <!-- end_original_pr_link --> <!-- start_initiating_author --> Initiated by: harryterkelsen <!-- end_initiating_author --> <!-- start_revert_reason --> Reason for reverting: causing test breakage on web. See: https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20linux_web_engine_tests/270/infra <!-- end_revert_reason --> <!-- start_original_pr_author --> Original PR Author: polina-c <!-- end_original_pr_author --> <!-- start_reviewers --> Reviewed By: {yjbanov} <!-- end_reviewers --> <!-- start_revert_body --> This change reverts the following previous change: No description provided. <!-- end_revert_body --> Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
This relands commit b9bd02b. The previous attempt was reverted in #4175 because of the suspicion that it was landing PRs with failed checks. However, that suspicion seems to have been wrong. This is what actually happened: * 12:25PM: @polina-c creates the [PR](flutter/flutter#162106); Cocoon starts testing it and unlocks the Merge Queue Guard after all engine builds are done (old behavior). * 1:02PM: I deploy the new Cocoon with the new behavior. * 1:10PM: @polina-c hits the "Merge When Ready" button, and GitHub allows the PR to enter the queue. GitHub allowed that last action because the guard was already unlocked by the old behavior. It wasn't the new code misbehaving. In fact, this is exactly the problem that the new code is aiming to fix.
Manual roll requested by tarrinneal@google.com flutter/flutter@c1561a4...c1ffaa9 2025-01-24 737941+loic-sharma@users.noreply.github.com Fix link to hotfix documentation best practices (flutter/flutter#162116) 2025-01-24 reidbaker@google.com Add integration test for cutout rotation evaluation (flutter/flutter#160354) 2025-01-24 flar@google.com Reland "[Impeller] Migrate unit tests off of Skia geometry classes (#161855)" (flutter/flutter#162146) 2025-01-24 bruno.leroux@gmail.com Fix TextField intrinsic width when hint is not visible (flutter/flutter#161235) 2025-01-24 magder@google.com When parsing flavors, handle Xcode build configurations that are not lowercase (flutter/flutter#161455) 2025-01-24 flar@google.com [Impeller] Fix source offset in PathBuilder::AddPath (flutter/flutter#162052) 2025-01-24 jessiewong401@gmail.com Add to Setup Path Example to Engine README (flutter/flutter#162115) 2025-01-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Unskip test. (#162106)" (flutter/flutter#162122) 2025-01-23 31410839+maheshj01@users.noreply.github.com feat: Add `hint` (Widget) property to InputDecoration (flutter/flutter#161424) 2025-01-23 jacksongardner@google.com Fix skwasm target in wasm_debug_unopt build. (flutter/flutter#162100) 2025-01-23 fluttergithubbot@gmail.com Marks Linux_android_emu android views to be unflaky (flutter/flutter#160493) 2025-01-23 polinach@google.com Unskip test. (flutter/flutter#162106) 2025-01-23 tessertaha@gmail.com Add ability to maintain bottom view padding in `NavigationBar` safe area (flutter/flutter#162076) 2025-01-23 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#162095) 2025-01-23 matanlurey@users.noreply.github.com Delete an unused (manual) workflow, added missing copyright headers. (flutter/flutter#162050) 2025-01-23 barpac02@gmail.com Android templates: update default Kotlin from 1.8.22 to 2.1.0, update default Gradle from 8.9 to 8.12 (flutter/flutter#160974) 2025-01-23 chris@bracken.jp flutter_tools: flutter_tester is a host artifact (flutter/flutter#162047) 2025-01-23 jason-simmons@users.noreply.github.com [Impeller] Make glIsTexture mockable for use by the ReactorGLES.NameUntrackedHandle test (flutter/flutter#162082) 2025-01-23 magder@google.com Remove "Mac Designed for iPad" as a discoverable `flutter run` device (flutter/flutter#161459) 2025-01-23 737941+loic-sharma@users.noreply.github.com Show error on macOS if missing Local Network permissions (flutter/flutter#161846) 2025-01-23 jmccandless@google.com Autocomplete keyboard navigation (flutter/flutter#159455) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
|
@yjbanov , couple questions:
It is not obvious, but after some thinking I see that Sounds correct? I followed https://github.com/flutter/flutter/blob/master/engine/README.md#gclient-bootstrap and ran I got this error:gclient sync /Users/polinach/_/platform/depot_tools/.cipd_bin WARNING: subprocess '"git" "-c" "core.deltaBaseCacheLimit=2g" "clone" "--no-checkout" "--progress" "https://dart.googlesource.com/sdk.git" "/Users/polinach/_/flutter_dev/engine/src/flutter/third_party/_gclient_dart_jrt8a_5f"' in /Users/polinach/_/flutter_dev failed; will retry after a short nap...engine/src/flutter/third_party/dart (ERROR)[0:01:24] Started. ________ running 'git -c core.deltaBaseCacheLimit=2g clone --no-checkout --progress https://dart.googlesource.com/sdk.git /Users/polinach/_/flutter_dev/engine/src/flutter/third_party/gclient_dart_jrt8a_5f' in '/Users/polinach//flutter_dev' [0:01:24] Cloning into '/Users/polinach/_/flutter_dev/engine/src/flutter/third_party/gclient_dart_jrt8a_5f'... [0:01:26] Cloning into '/Users/polinach//flutter_dev/engine/src/flutter/third_party/gclient_dart_jrt8a_5f'...
|
) Manual roll requested by tarrinneal@google.com flutter/flutter@c1561a4...c1ffaa9 2025-01-24 737941+loic-sharma@users.noreply.github.com Fix link to hotfix documentation best practices (flutter/flutter#162116) 2025-01-24 reidbaker@google.com Add integration test for cutout rotation evaluation (flutter/flutter#160354) 2025-01-24 flar@google.com Reland "[Impeller] Migrate unit tests off of Skia geometry classes (#161855)" (flutter/flutter#162146) 2025-01-24 bruno.leroux@gmail.com Fix TextField intrinsic width when hint is not visible (flutter/flutter#161235) 2025-01-24 magder@google.com When parsing flavors, handle Xcode build configurations that are not lowercase (flutter/flutter#161455) 2025-01-24 flar@google.com [Impeller] Fix source offset in PathBuilder::AddPath (flutter/flutter#162052) 2025-01-24 jessiewong401@gmail.com Add to Setup Path Example to Engine README (flutter/flutter#162115) 2025-01-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Unskip test. (#162106)" (flutter/flutter#162122) 2025-01-23 31410839+maheshj01@users.noreply.github.com feat: Add `hint` (Widget) property to InputDecoration (flutter/flutter#161424) 2025-01-23 jacksongardner@google.com Fix skwasm target in wasm_debug_unopt build. (flutter/flutter#162100) 2025-01-23 fluttergithubbot@gmail.com Marks Linux_android_emu android views to be unflaky (flutter/flutter#160493) 2025-01-23 polinach@google.com Unskip test. (flutter/flutter#162106) 2025-01-23 tessertaha@gmail.com Add ability to maintain bottom view padding in `NavigationBar` safe area (flutter/flutter#162076) 2025-01-23 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#162095) 2025-01-23 matanlurey@users.noreply.github.com Delete an unused (manual) workflow, added missing copyright headers. (flutter/flutter#162050) 2025-01-23 barpac02@gmail.com Android templates: update default Kotlin from 1.8.22 to 2.1.0, update default Gradle from 8.9 to 8.12 (flutter/flutter#160974) 2025-01-23 chris@bracken.jp flutter_tools: flutter_tester is a host artifact (flutter/flutter#162047) 2025-01-23 jason-simmons@users.noreply.github.com [Impeller] Make glIsTexture mockable for use by the ReactorGLES.NameUntrackedHandle test (flutter/flutter#162082) 2025-01-23 magder@google.com Remove "Mac Designed for iPad" as a discoverable `flutter run` device (flutter/flutter#161459) 2025-01-23 737941+loic-sharma@users.noreply.github.com Show error on macOS if missing Local Network permissions (flutter/flutter#161846) 2025-01-23 jmccandless@google.com Autocomplete keyboard navigation (flutter/flutter#159455) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
) Manual roll requested by tarrinneal@google.com flutter/flutter@c1561a4...c1ffaa9 2025-01-24 737941+loic-sharma@users.noreply.github.com Fix link to hotfix documentation best practices (flutter/flutter#162116) 2025-01-24 reidbaker@google.com Add integration test for cutout rotation evaluation (flutter/flutter#160354) 2025-01-24 flar@google.com Reland "[Impeller] Migrate unit tests off of Skia geometry classes (#161855)" (flutter/flutter#162146) 2025-01-24 bruno.leroux@gmail.com Fix TextField intrinsic width when hint is not visible (flutter/flutter#161235) 2025-01-24 magder@google.com When parsing flavors, handle Xcode build configurations that are not lowercase (flutter/flutter#161455) 2025-01-24 flar@google.com [Impeller] Fix source offset in PathBuilder::AddPath (flutter/flutter#162052) 2025-01-24 jessiewong401@gmail.com Add to Setup Path Example to Engine README (flutter/flutter#162115) 2025-01-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Unskip test. (#162106)" (flutter/flutter#162122) 2025-01-23 31410839+maheshj01@users.noreply.github.com feat: Add `hint` (Widget) property to InputDecoration (flutter/flutter#161424) 2025-01-23 jacksongardner@google.com Fix skwasm target in wasm_debug_unopt build. (flutter/flutter#162100) 2025-01-23 fluttergithubbot@gmail.com Marks Linux_android_emu android views to be unflaky (flutter/flutter#160493) 2025-01-23 polinach@google.com Unskip test. (flutter/flutter#162106) 2025-01-23 tessertaha@gmail.com Add ability to maintain bottom view padding in `NavigationBar` safe area (flutter/flutter#162076) 2025-01-23 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#162095) 2025-01-23 matanlurey@users.noreply.github.com Delete an unused (manual) workflow, added missing copyright headers. (flutter/flutter#162050) 2025-01-23 barpac02@gmail.com Android templates: update default Kotlin from 1.8.22 to 2.1.0, update default Gradle from 8.9 to 8.12 (flutter/flutter#160974) 2025-01-23 chris@bracken.jp flutter_tools: flutter_tester is a host artifact (flutter/flutter#162047) 2025-01-23 jason-simmons@users.noreply.github.com [Impeller] Make glIsTexture mockable for use by the ReactorGLES.NameUntrackedHandle test (flutter/flutter#162082) 2025-01-23 magder@google.com Remove "Mac Designed for iPad" as a discoverable `flutter run` device (flutter/flutter#161459) 2025-01-23 737941+loic-sharma@users.noreply.github.com Show error on macOS if missing Local Network permissions (flutter/flutter#161846) 2025-01-23 jmccandless@google.com Autocomplete keyboard navigation (flutter/flutter#159455) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

No description provided.