Skip to content

Fix skwasm target in wasm_debug_unopt build. #162100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Jan 24, 2025
Merged

Fix skwasm target in wasm_debug_unopt build. #162100

auto-submit merged 1 commit into from
Jan 24, 2025

Conversation

@eyebrowsoffire
Copy link
Contributor

@eyebrowsoffire eyebrowsoffire commented Jan 23, 2025

Fixes a couple issues in the skwasm build rules:

  • DEMANGLE_SUPPORT is deprecated in emscripten, so just remove it.
  • sSHARED_MEMORY=1 needs to be added to the cflags so that emscripten appends the proper feature flags (-matomics and -mbulk-memory) when doing the compile so that the flags match the linking step.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Jan 23, 2025

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@github-actions github-actions bot added engine flutter/engine related. See also e: labels. platform-web Web applications specifically labels Jan 23, 2025
mdebbar
mdebbar approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@mdebbar mdebbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eyebrowsoffire eyebrowsoffire added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 23, 2025
@eyebrowsoffire eyebrowsoffire mentioned this pull request Jan 23, 2025
Closed
harryterkelsen
harryterkelsen approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@harryterkelsen harryterkelsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@auto-submit auto-submit bot added this pull request to the merge queue Jan 23, 2025
Merged via the queue into flutter:master with commit bfe31d6 Jan 24, 2025
172 of 173 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 24, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 24, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 24, 2025
@engine-flutter-autoroll
bfe31d6 Fix skwasm target in wasm_debug_unopt build. (flutter/flutter…
031bfc1 
…#162100)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 24, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 24, 2025
@engine-flutter-autoroll
bfe31d6 Fix skwasm target in wasm_debug_unopt build. (flutter/flutter…
b18764e 
…#162100)
Wasmund1 pushed a commit to Wasmund1/flutter that referenced this pull request Jan 24, 2025
@eyebrowsoffire
Fix skwasm target in wasm_debug_unopt build. (flutter#162100)
7667858 
Fixes a couple issues in the skwasm build rules:
* `DEMANGLE_SUPPORT` is deprecated in emscripten, so just remove it.
* `sSHARED_MEMORY=1` needs to be added to the cflags so that emscripten
appends the proper feature flags (`-matomics` and `-mbulk-memory`) when
doing the compile so that the flags match the linking step.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 24, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 24, 2025
@engine-flutter-autoroll
bfe31d6 Fix skwasm target in wasm_debug_unopt build. (flutter/flutter…
6bcb55b 
…#162100)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 24, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 24, 2025
@engine-flutter-autoroll
bfe31d6 Fix skwasm target in wasm_debug_unopt build. (flutter/flutter…
fc1a7a8 
…#162100)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 24, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 24, 2025
@engine-flutter-autoroll
bfe31d6 Fix skwasm target in wasm_debug_unopt build. (flutter/flutter…
cfeff34 
…#162100)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jan 24, 2025
@engine-flutter-autoroll
Manual roll Flutter from c1561a4 to c1ffaa9 (21 revisions) (#8498)
72a47ed 
Manual roll requested by tarrinneal@google.com

flutter/flutter@c1561a4...c1ffaa9

2025-01-24 737941+loic-sharma@users.noreply.github.com Fix link to hotfix documentation best practices (flutter/flutter#162116)
2025-01-24 reidbaker@google.com Add integration test for cutout rotation evaluation (flutter/flutter#160354)
2025-01-24 flar@google.com Reland "[Impeller] Migrate unit tests off of Skia geometry classes (#161855)" (flutter/flutter#162146)
2025-01-24 bruno.leroux@gmail.com Fix TextField intrinsic width when hint is not visible (flutter/flutter#161235)
2025-01-24 magder@google.com When parsing flavors, handle Xcode build configurations that are not lowercase (flutter/flutter#161455)
2025-01-24 flar@google.com [Impeller] Fix source offset in PathBuilder::AddPath (flutter/flutter#162052)
2025-01-24 jessiewong401@gmail.com Add to Setup Path Example to Engine README (flutter/flutter#162115)
2025-01-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Unskip test. (#162106)" (flutter/flutter#162122)
2025-01-23 31410839+maheshj01@users.noreply.github.com feat: Add `hint` (Widget) property to InputDecoration (flutter/flutter#161424)
2025-01-23 jacksongardner@google.com Fix skwasm target in wasm_debug_unopt build. (flutter/flutter#162100)
2025-01-23 fluttergithubbot@gmail.com Marks Linux_android_emu android views to be unflaky (flutter/flutter#160493)
2025-01-23 polinach@google.com Unskip test. (flutter/flutter#162106)
2025-01-23 tessertaha@gmail.com Add ability to maintain bottom view padding in `NavigationBar` safe area (flutter/flutter#162076)
2025-01-23 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#162095)
2025-01-23 matanlurey@users.noreply.github.com Delete an unused (manual) workflow, added missing copyright headers. (flutter/flutter#162050)
2025-01-23 barpac02@gmail.com Android templates: update default Kotlin from 1.8.22 to 2.1.0, update default Gradle from 8.9 to 8.12 (flutter/flutter#160974)
2025-01-23 chris@bracken.jp flutter_tools: flutter_tester is a host artifact (flutter/flutter#162047)
2025-01-23 jason-simmons@users.noreply.github.com [Impeller] Make glIsTexture mockable for use by the ReactorGLES.NameUntrackedHandle test (flutter/flutter#162082)
2025-01-23 magder@google.com Remove "Mac Designed for iPad" as a discoverable `flutter run` device (flutter/flutter#161459)
2025-01-23 737941+loic-sharma@users.noreply.github.com Show error on macOS if missing Local Network permissions (flutter/flutter#161846)
2025-01-23 jmccandless@google.com Autocomplete keyboard navigation (flutter/flutter#159455)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
bfe31d6 Fix skwasm target in wasm_debug_unopt build. (flutter/flutter…
46472e2 
…#162100)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
bfe31d6 Fix skwasm target in wasm_debug_unopt build. (flutter/flutter…
acdec00 
…#162100)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
bfe31d6 Fix skwasm target in wasm_debug_unopt build. (flutter/flutter…
7c477a9 
…#162100)
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@engine-flutter-autoroll @androidseb
Manual roll Flutter from c1561a4 to c1ffaa9 (21 revisions) (flutter#8498
552d465 
)

Manual roll requested by tarrinneal@google.com

flutter/flutter@c1561a4...c1ffaa9

2025-01-24 737941+loic-sharma@users.noreply.github.com Fix link to hotfix documentation best practices (flutter/flutter#162116)
2025-01-24 reidbaker@google.com Add integration test for cutout rotation evaluation (flutter/flutter#160354)
2025-01-24 flar@google.com Reland "[Impeller] Migrate unit tests off of Skia geometry classes (#161855)" (flutter/flutter#162146)
2025-01-24 bruno.leroux@gmail.com Fix TextField intrinsic width when hint is not visible (flutter/flutter#161235)
2025-01-24 magder@google.com When parsing flavors, handle Xcode build configurations that are not lowercase (flutter/flutter#161455)
2025-01-24 flar@google.com [Impeller] Fix source offset in PathBuilder::AddPath (flutter/flutter#162052)
2025-01-24 jessiewong401@gmail.com Add to Setup Path Example to Engine README (flutter/flutter#162115)
2025-01-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Unskip test. (#162106)" (flutter/flutter#162122)
2025-01-23 31410839+maheshj01@users.noreply.github.com feat: Add `hint` (Widget) property to InputDecoration (flutter/flutter#161424)
2025-01-23 jacksongardner@google.com Fix skwasm target in wasm_debug_unopt build. (flutter/flutter#162100)
2025-01-23 fluttergithubbot@gmail.com Marks Linux_android_emu android views to be unflaky (flutter/flutter#160493)
2025-01-23 polinach@google.com Unskip test. (flutter/flutter#162106)
2025-01-23 tessertaha@gmail.com Add ability to maintain bottom view padding in `NavigationBar` safe area (flutter/flutter#162076)
2025-01-23 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#162095)
2025-01-23 matanlurey@users.noreply.github.com Delete an unused (manual) workflow, added missing copyright headers. (flutter/flutter#162050)
2025-01-23 barpac02@gmail.com Android templates: update default Kotlin from 1.8.22 to 2.1.0, update default Gradle from 8.9 to 8.12 (flutter/flutter#160974)
2025-01-23 chris@bracken.jp flutter_tools: flutter_tester is a host artifact (flutter/flutter#162047)
2025-01-23 jason-simmons@users.noreply.github.com [Impeller] Make glIsTexture mockable for use by the ReactorGLES.NameUntrackedHandle test (flutter/flutter#162082)
2025-01-23 magder@google.com Remove "Mac Designed for iPad" as a discoverable `flutter run` device (flutter/flutter#161459)
2025-01-23 737941+loic-sharma@users.noreply.github.com Show error on macOS if missing Local Network permissions (flutter/flutter#161846)
2025-01-23 jmccandless@google.com Autocomplete keyboard navigation (flutter/flutter#159455)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@engine-flutter-autoroll @FMorschel
Manual roll Flutter from c1561a4 to c1ffaa9 (21 revisions) (flutter#8498
52932db 
)

Manual roll requested by tarrinneal@google.com

flutter/flutter@c1561a4...c1ffaa9

2025-01-24 737941+loic-sharma@users.noreply.github.com Fix link to hotfix documentation best practices (flutter/flutter#162116)
2025-01-24 reidbaker@google.com Add integration test for cutout rotation evaluation (flutter/flutter#160354)
2025-01-24 flar@google.com Reland "[Impeller] Migrate unit tests off of Skia geometry classes (#161855)" (flutter/flutter#162146)
2025-01-24 bruno.leroux@gmail.com Fix TextField intrinsic width when hint is not visible (flutter/flutter#161235)
2025-01-24 magder@google.com When parsing flavors, handle Xcode build configurations that are not lowercase (flutter/flutter#161455)
2025-01-24 flar@google.com [Impeller] Fix source offset in PathBuilder::AddPath (flutter/flutter#162052)
2025-01-24 jessiewong401@gmail.com Add to Setup Path Example to Engine README (flutter/flutter#162115)
2025-01-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Unskip test. (#162106)" (flutter/flutter#162122)
2025-01-23 31410839+maheshj01@users.noreply.github.com feat: Add `hint` (Widget) property to InputDecoration (flutter/flutter#161424)
2025-01-23 jacksongardner@google.com Fix skwasm target in wasm_debug_unopt build. (flutter/flutter#162100)
2025-01-23 fluttergithubbot@gmail.com Marks Linux_android_emu android views to be unflaky (flutter/flutter#160493)
2025-01-23 polinach@google.com Unskip test. (flutter/flutter#162106)
2025-01-23 tessertaha@gmail.com Add ability to maintain bottom view padding in `NavigationBar` safe area (flutter/flutter#162076)
2025-01-23 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#162095)
2025-01-23 matanlurey@users.noreply.github.com Delete an unused (manual) workflow, added missing copyright headers. (flutter/flutter#162050)
2025-01-23 barpac02@gmail.com Android templates: update default Kotlin from 1.8.22 to 2.1.0, update default Gradle from 8.9 to 8.12 (flutter/flutter#160974)
2025-01-23 chris@bracken.jp flutter_tools: flutter_tester is a host artifact (flutter/flutter#162047)
2025-01-23 jason-simmons@users.noreply.github.com [Impeller] Make glIsTexture mockable for use by the ReactorGLES.NameUntrackedHandle test (flutter/flutter#162082)
2025-01-23 magder@google.com Remove "Mac Designed for iPad" as a discoverable `flutter run` device (flutter/flutter#161459)
2025-01-23 737941+loic-sharma@users.noreply.github.com Show error on macOS if missing Local Network permissions (flutter/flutter#161846)
2025-01-23 jmccandless@google.com Autocomplete keyboard navigation (flutter/flutter#159455)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@eyebrowsoffire eyebrowsoffire deleted the skwasm_debug_fixes branch December 12, 2025 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdebbar mdebbar mdebbar approved these changes

@harryterkelsen harryterkelsen harryterkelsen approved these changes

Assignees

No one assigned

Labels

engine flutter/engine related. See also e: labels. platform-web Web applications specifically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eyebrowsoffire @mdebbar @harryterkelsen