Skip to content

[Impeller] Fix source offset in PathBuilder::AddPath #162052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
flar merged 3 commits into from
Jan 24, 2025
Merged

[Impeller] Fix source offset in PathBuilder::AddPath #162052

flar merged 3 commits into from
Jan 24, 2025

Conversation

@flar
Copy link
Contributor

@flar flar commented Jan 23, 2025

An error in bookkeeping in PathBuilder::AddPath caused crashes in recent unit tests (see #162046)

@github-actions github-actions bot added engine flutter/engine related. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels Jan 23, 2025
@flar flar force-pushed the fix-addpath-source-offset branch from ae49d92 to c260aac Compare January 23, 2025 01:30
jonahwilliams
jonahwilliams approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flar flar added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 23, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Jan 23, 2025

auto label is removed for flutter/flutter/162052, due to - The status or check suite Linux linux_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 23, 2025
@flar flar added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 23, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 23, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Jan 23, 2025

auto label is removed for flutter/flutter/162052, due to - The status or check suite Linux linux_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

@flar flar added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 23, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Jan 23, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 24, 2025
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 24, 2025
@flar flar added this pull request to the merge queue Jan 24, 2025
Merged via the queue into flutter:master with commit 83bac34 Jan 24, 2025
174 of 175 checks passed
@flar flar deleted the fix-addpath-source-offset branch January 24, 2025 06:41
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 24, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 24, 2025
@engine-flutter-autoroll
83bac34 [Impeller] Fix source offset in PathBuilder::AddPath (flutter…
9a966b3 
…/flutter#162052)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 24, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 24, 2025
@engine-flutter-autoroll
83bac34 [Impeller] Fix source offset in PathBuilder::AddPath (flutter…
be50894 
…/flutter#162052)
Wasmund1 pushed a commit to Wasmund1/flutter that referenced this pull request Jan 24, 2025
@flar
[Impeller] Fix source offset in PathBuilder::AddPath (flutter#162052)
55702b5 
An error in bookkeeping in `PathBuilder::AddPath` caused crashes in
recent unit tests (see flutter#162046)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 24, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 24, 2025
@engine-flutter-autoroll
83bac34 [Impeller] Fix source offset in PathBuilder::AddPath (flutter…
27c2750 
…/flutter#162052)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 24, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 24, 2025
@engine-flutter-autoroll
83bac34 [Impeller] Fix source offset in PathBuilder::AddPath (flutter…
ae71360 
…/flutter#162052)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 24, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 24, 2025
@engine-flutter-autoroll
83bac34 [Impeller] Fix source offset in PathBuilder::AddPath (flutter…
bee7060 
…/flutter#162052)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jan 24, 2025
@engine-flutter-autoroll
Manual roll Flutter from c1561a4 to c1ffaa9 (21 revisions) (#8498)
72a47ed 
Manual roll requested by tarrinneal@google.com

flutter/flutter@c1561a4...c1ffaa9

2025-01-24 737941+loic-sharma@users.noreply.github.com Fix link to hotfix documentation best practices (flutter/flutter#162116)
2025-01-24 reidbaker@google.com Add integration test for cutout rotation evaluation (flutter/flutter#160354)
2025-01-24 flar@google.com Reland "[Impeller] Migrate unit tests off of Skia geometry classes (#161855)" (flutter/flutter#162146)
2025-01-24 bruno.leroux@gmail.com Fix TextField intrinsic width when hint is not visible (flutter/flutter#161235)
2025-01-24 magder@google.com When parsing flavors, handle Xcode build configurations that are not lowercase (flutter/flutter#161455)
2025-01-24 flar@google.com [Impeller] Fix source offset in PathBuilder::AddPath (flutter/flutter#162052)
2025-01-24 jessiewong401@gmail.com Add to Setup Path Example to Engine README (flutter/flutter#162115)
2025-01-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Unskip test. (#162106)" (flutter/flutter#162122)
2025-01-23 31410839+maheshj01@users.noreply.github.com feat: Add `hint` (Widget) property to InputDecoration (flutter/flutter#161424)
2025-01-23 jacksongardner@google.com Fix skwasm target in wasm_debug_unopt build. (flutter/flutter#162100)
2025-01-23 fluttergithubbot@gmail.com Marks Linux_android_emu android views to be unflaky (flutter/flutter#160493)
2025-01-23 polinach@google.com Unskip test. (flutter/flutter#162106)
2025-01-23 tessertaha@gmail.com Add ability to maintain bottom view padding in `NavigationBar` safe area (flutter/flutter#162076)
2025-01-23 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#162095)
2025-01-23 matanlurey@users.noreply.github.com Delete an unused (manual) workflow, added missing copyright headers. (flutter/flutter#162050)
2025-01-23 barpac02@gmail.com Android templates: update default Kotlin from 1.8.22 to 2.1.0, update default Gradle from 8.9 to 8.12 (flutter/flutter#160974)
2025-01-23 chris@bracken.jp flutter_tools: flutter_tester is a host artifact (flutter/flutter#162047)
2025-01-23 jason-simmons@users.noreply.github.com [Impeller] Make glIsTexture mockable for use by the ReactorGLES.NameUntrackedHandle test (flutter/flutter#162082)
2025-01-23 magder@google.com Remove "Mac Designed for iPad" as a discoverable `flutter run` device (flutter/flutter#161459)
2025-01-23 737941+loic-sharma@users.noreply.github.com Show error on macOS if missing Local Network permissions (flutter/flutter#161846)
2025-01-23 jmccandless@google.com Autocomplete keyboard navigation (flutter/flutter#159455)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
83bac34 [Impeller] Fix source offset in PathBuilder::AddPath (flutter…
68e2d52 
…/flutter#162052)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
83bac34 [Impeller] Fix source offset in PathBuilder::AddPath (flutter…
891c9ef 
…/flutter#162052)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
83bac34 [Impeller] Fix source offset in PathBuilder::AddPath (flutter…
721bc97 
…/flutter#162052)
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@engine-flutter-autoroll @androidseb
Manual roll Flutter from c1561a4 to c1ffaa9 (21 revisions) (flutter#8498
552d465 
)

Manual roll requested by tarrinneal@google.com

flutter/flutter@c1561a4...c1ffaa9

2025-01-24 737941+loic-sharma@users.noreply.github.com Fix link to hotfix documentation best practices (flutter/flutter#162116)
2025-01-24 reidbaker@google.com Add integration test for cutout rotation evaluation (flutter/flutter#160354)
2025-01-24 flar@google.com Reland "[Impeller] Migrate unit tests off of Skia geometry classes (#161855)" (flutter/flutter#162146)
2025-01-24 bruno.leroux@gmail.com Fix TextField intrinsic width when hint is not visible (flutter/flutter#161235)
2025-01-24 magder@google.com When parsing flavors, handle Xcode build configurations that are not lowercase (flutter/flutter#161455)
2025-01-24 flar@google.com [Impeller] Fix source offset in PathBuilder::AddPath (flutter/flutter#162052)
2025-01-24 jessiewong401@gmail.com Add to Setup Path Example to Engine README (flutter/flutter#162115)
2025-01-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Unskip test. (#162106)" (flutter/flutter#162122)
2025-01-23 31410839+maheshj01@users.noreply.github.com feat: Add `hint` (Widget) property to InputDecoration (flutter/flutter#161424)
2025-01-23 jacksongardner@google.com Fix skwasm target in wasm_debug_unopt build. (flutter/flutter#162100)
2025-01-23 fluttergithubbot@gmail.com Marks Linux_android_emu android views to be unflaky (flutter/flutter#160493)
2025-01-23 polinach@google.com Unskip test. (flutter/flutter#162106)
2025-01-23 tessertaha@gmail.com Add ability to maintain bottom view padding in `NavigationBar` safe area (flutter/flutter#162076)
2025-01-23 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#162095)
2025-01-23 matanlurey@users.noreply.github.com Delete an unused (manual) workflow, added missing copyright headers. (flutter/flutter#162050)
2025-01-23 barpac02@gmail.com Android templates: update default Kotlin from 1.8.22 to 2.1.0, update default Gradle from 8.9 to 8.12 (flutter/flutter#160974)
2025-01-23 chris@bracken.jp flutter_tools: flutter_tester is a host artifact (flutter/flutter#162047)
2025-01-23 jason-simmons@users.noreply.github.com [Impeller] Make glIsTexture mockable for use by the ReactorGLES.NameUntrackedHandle test (flutter/flutter#162082)
2025-01-23 magder@google.com Remove "Mac Designed for iPad" as a discoverable `flutter run` device (flutter/flutter#161459)
2025-01-23 737941+loic-sharma@users.noreply.github.com Show error on macOS if missing Local Network permissions (flutter/flutter#161846)
2025-01-23 jmccandless@google.com Autocomplete keyboard navigation (flutter/flutter#159455)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@engine-flutter-autoroll @FMorschel
Manual roll Flutter from c1561a4 to c1ffaa9 (21 revisions) (flutter#8498
52932db 
)

Manual roll requested by tarrinneal@google.com

flutter/flutter@c1561a4...c1ffaa9

2025-01-24 737941+loic-sharma@users.noreply.github.com Fix link to hotfix documentation best practices (flutter/flutter#162116)
2025-01-24 reidbaker@google.com Add integration test for cutout rotation evaluation (flutter/flutter#160354)
2025-01-24 flar@google.com Reland "[Impeller] Migrate unit tests off of Skia geometry classes (#161855)" (flutter/flutter#162146)
2025-01-24 bruno.leroux@gmail.com Fix TextField intrinsic width when hint is not visible (flutter/flutter#161235)
2025-01-24 magder@google.com When parsing flavors, handle Xcode build configurations that are not lowercase (flutter/flutter#161455)
2025-01-24 flar@google.com [Impeller] Fix source offset in PathBuilder::AddPath (flutter/flutter#162052)
2025-01-24 jessiewong401@gmail.com Add to Setup Path Example to Engine README (flutter/flutter#162115)
2025-01-23 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Unskip test. (#162106)" (flutter/flutter#162122)
2025-01-23 31410839+maheshj01@users.noreply.github.com feat: Add `hint` (Widget) property to InputDecoration (flutter/flutter#161424)
2025-01-23 jacksongardner@google.com Fix skwasm target in wasm_debug_unopt build. (flutter/flutter#162100)
2025-01-23 fluttergithubbot@gmail.com Marks Linux_android_emu android views to be unflaky (flutter/flutter#160493)
2025-01-23 polinach@google.com Unskip test. (flutter/flutter#162106)
2025-01-23 tessertaha@gmail.com Add ability to maintain bottom view padding in `NavigationBar` safe area (flutter/flutter#162076)
2025-01-23 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#162095)
2025-01-23 matanlurey@users.noreply.github.com Delete an unused (manual) workflow, added missing copyright headers. (flutter/flutter#162050)
2025-01-23 barpac02@gmail.com Android templates: update default Kotlin from 1.8.22 to 2.1.0, update default Gradle from 8.9 to 8.12 (flutter/flutter#160974)
2025-01-23 chris@bracken.jp flutter_tools: flutter_tester is a host artifact (flutter/flutter#162047)
2025-01-23 jason-simmons@users.noreply.github.com [Impeller] Make glIsTexture mockable for use by the ReactorGLES.NameUntrackedHandle test (flutter/flutter#162082)
2025-01-23 magder@google.com Remove "Mac Designed for iPad" as a discoverable `flutter run` device (flutter/flutter#161459)
2025-01-23 737941+loic-sharma@users.noreply.github.com Show error on macOS if missing Local Network permissions (flutter/flutter#161846)
2025-01-23 jmccandless@google.com Autocomplete keyboard navigation (flutter/flutter#159455)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jason-simmons jason-simmons jason-simmons approved these changes

+1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

e: impeller Impeller rendering backend issues and features requests engine flutter/engine related. See also e: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@flar @jonahwilliams @jason-simmons