-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Manual roll of engine from aa4c205c1 to 9b539b339 #113463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This version of engine is breaking the tree, need to resolve this to make the tree green
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
This is for #113454 @drewroengoogle you need to wait until the flutter/engine@59dea4c engine artifacts are published otherwise the tests will fail. I'm re-running them now. |
|
Please avoid doing manual rolls like this. Instead, you can revert a bad roll from the framework tree. Pause the engine -> framework roll, wait for a good build on the engine tree to finish, then re-enable the roller. That way the roll commits contain all the information that the autoroller puts in them. |
|
@zanderso Gotcha, that makes sense! In my head I was trying to get away from the red tree, but I didn't realize it was bad practice to manually roll, so I'll make sure to avoid doing so in the future. |
* 0575faa Revert "Roll Flutter Engine from 732410a66973 to 3711bbaeabb7 (3 revisions) (#113410)" (flutter/flutter#113440) * 24aa26a Handle null exception case in ProxiedDevice.stopApp. (flutter/flutter#113317) * 8d3c7e7 Revert "`AutomatedTestWidgetsFlutterBinding.pump` provides wrong pump time stamp, probably because of forgetting the precision" (flutter/flutter#113415) * c49a173 Roll Flutter Engine from 732410a66973 to aa4c205c1357 (18 revisions) (flutter/flutter#113442) * 8875040 [web] Migrate selectable_region to static interop. (flutter/flutter#113292) * a707d05 Manual roll of engine from aa4c205c1 to 9b539b339 (flutter/flutter#113463)
This version of engine is breaking the tree, need to update to this version to make the tree green
#113454
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.