Skip to content

Handle null exception case in ProxiedDevice.stopApp. #113317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Oct 14, 2022
Merged

Handle null exception case in ProxiedDevice.stopApp. #113317

auto-submit merged 1 commit into from
Oct 14, 2022

Conversation

@chingjun
Copy link
Contributor

@chingjun chingjun commented Oct 12, 2022

It crashes when stopApp is called without a valid application bundle.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Oct 12, 2022
christopherfujino
christopherfujino approved these changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@chingjun chingjun added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 13, 2022
@auto-submit auto-submit bot merged commit 24aa26a into flutter:master Oct 14, 2022
This was referenced Oct 15, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 15, 2022
@engine-flutter-autoroll
24aa26a Handle null exception case in ProxiedDevice.stopApp. (flutter…
f01dc51 
…/flutter#113317)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Oct 15, 2022
@engine-flutter-autoroll
24aa26a Handle null exception case in ProxiedDevice.stopApp. (flutter…
17ae718 
…/flutter#113317)
ditman pushed a commit to flutter/packages that referenced this pull request Oct 18, 2022
@engine-flutter-autoroll
Roll Flutter from 08e1729 to a707d05 (6 revisions) (#2712)
550e445 
* 0575faa Revert "Roll Flutter Engine from 732410a66973 to 3711bbaeabb7 (3 revisions) (#113410)" (flutter/flutter#113440)

* 24aa26a Handle null exception case in ProxiedDevice.stopApp. (flutter/flutter#113317)

* 8d3c7e7 Revert "`AutomatedTestWidgetsFlutterBinding.pump` provides wrong pump time stamp, probably because of forgetting the precision" (flutter/flutter#113415)

* c49a173 Roll Flutter Engine from 732410a66973 to aa4c205c1357 (18 revisions) (flutter/flutter#113442)

* 8875040 [web] Migrate selectable_region to static interop. (flutter/flutter#113292)

* a707d05 Manual roll of engine from aa4c205c1 to 9b539b339 (flutter/flutter#113463)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chingjun @christopherfujino