Skip to content

[web] Migrate selectable_region to static interop. #113292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joshualitt merged 1 commit into from
Oct 14, 2022
Merged

[web] Migrate selectable_region to static interop. #113292

joshualitt merged 1 commit into from
Oct 14, 2022

Conversation

@joshualitt
Copy link
Contributor

@joshualitt joshualitt commented Oct 11, 2022

This CL migrates selectable_region to static interop.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels Oct 11, 2022
@flutter-dashboard
Copy link

flutter-dashboard bot commented Oct 11, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@joshualitt
Copy link
Contributor Author

joshualitt commented Oct 11, 2022

@ditman @eyebrowsoffire ptal. The analyze tests are failing because of dom.dart living in lib/. Where should the dom shim live?

eyebrowsoffire
eyebrowsoffire approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@eyebrowsoffire eyebrowsoffire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It appears the CI analyzer stuff is passing, is your above question still pertinent? I'm not intimately familiar with the folder structure in the framework and what's allowed where so I'm not the best person to ask on this topic.

@joshualitt
Copy link
Contributor Author

joshualitt commented Oct 12, 2022

@eyebrowsoffire I moved dom.dart to lib/src which fixed the analyzer issues, so the question above is resolved.

@dnfield
Copy link
Contributor

dnfield commented Oct 13, 2022

(putting dom in lib would've made it visible to users in IDEs, which I don't think we'd want).

ditman
ditman approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go! My only serious comment is let @chunhtai that this is coming, in case he's got anything to look at/test.

chunhtai
chunhtai approved these changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the selectable region part.

@joshualitt joshualitt merged commit 8875040 into flutter:master Oct 14, 2022
This was referenced Oct 15, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 15, 2022
@engine-flutter-autoroll
8875040 [web] Migrate selectable_region to static interop. (flutter/f…
1d06442 
…lutter#113292)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Oct 15, 2022
@engine-flutter-autoroll
8875040 [web] Migrate selectable_region to static interop. (flutter/f…
72c9c26 
…lutter#113292)
ditman pushed a commit to flutter/packages that referenced this pull request Oct 18, 2022
@engine-flutter-autoroll
Roll Flutter from 08e1729 to a707d05 (6 revisions) (#2712)
550e445 
* 0575faa Revert "Roll Flutter Engine from 732410a66973 to 3711bbaeabb7 (3 revisions) (#113410)" (flutter/flutter#113440)

* 24aa26a Handle null exception case in ProxiedDevice.stopApp. (flutter/flutter#113317)

* 8d3c7e7 Revert "`AutomatedTestWidgetsFlutterBinding.pump` provides wrong pump time stamp, probably because of forgetting the precision" (flutter/flutter#113415)

* c49a173 Roll Flutter Engine from 732410a66973 to aa4c205c1357 (18 revisions) (flutter/flutter#113442)

* 8875040 [web] Migrate selectable_region to static interop. (flutter/flutter#113292)

* a707d05 Manual roll of engine from aa4c205c1 to 9b539b339 (flutter/flutter#113463)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ditman ditman ditman approved these changes

@eyebrowsoffire eyebrowsoffire eyebrowsoffire approved these changes

@chunhtai chunhtai chunhtai approved these changes

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@joshualitt @dnfield @ditman @eyebrowsoffire @chunhtai