Revert "AutomatedTestWidgetsFlutterBinding.pump provides wrong pump time stamp, probably because of forgetting the precision"
#113415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godofredoc
approved these changes
Oct 14, 2022
This was referenced Oct 15, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 15, 2022
…ong pump time stamp, probably because of forgetting the precision" (flutter/flutter#113415)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Oct 15, 2022
…ong pump time stamp, probably because of forgetting the precision" (flutter/flutter#113415)
ditman
pushed a commit
to flutter/packages
that referenced
this pull request
Oct 18, 2022
* 0575faa Revert "Roll Flutter Engine from 732410a66973 to 3711bbaeabb7 (3 revisions) (#113410)" (flutter/flutter#113440) * 24aa26a Handle null exception case in ProxiedDevice.stopApp. (flutter/flutter#113317) * 8d3c7e7 Revert "`AutomatedTestWidgetsFlutterBinding.pump` provides wrong pump time stamp, probably because of forgetting the precision" (flutter/flutter#113415) * c49a173 Roll Flutter Engine from 732410a66973 to aa4c205c1357 (18 revisions) (flutter/flutter#113442) * 8875040 [web] Migrate selectable_region to static interop. (flutter/flutter#113292) * a707d05 Manual roll of engine from aa4c205c1 to 9b539b339 (flutter/flutter#113463)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #112609. context: this is causing flaky tests in the current roll, and is difficult to get a g3fix in for.