Reland Clang 11, Roll buildroot to 1bc40a5f916adb93d87e2a2230a0ec43db876c1c #17457
Conversation
…orted symbols (flutter#17440)" (flutter#17451)" This reverts commit a870bc5.
| } | ||
|
|
||
| TEST_F(EmbedderTest, VerifyB143464703WithSoftwareBackend) { | ||
| #if !defined(OS_LINUX) |
There was a problem hiding this comment.
We ensure all tests here run on all platforms. I'd rather have this test disabled (and file a bug with a linked TODO) than skip it this way.
There was a problem hiding this comment.
Golden tests are difficult to get right for all platforms. We could just skip it outright and re-enable it if we can get Skia gold for engine unit tests, but we'd then lose coverage even on Linux...
There was a problem hiding this comment.
(The actual differences are minor pixel differences in the gradients)
There was a problem hiding this comment.
Golden tests are difficult to get right for all platforms.
Sigh. Very true. And, looking at this test, I am not sure why the assertions in the next presentation callback are not sufficient. The pixel test here seems to be redundant.
It's your call on if you want to skip or disable. But please file a bug with a linked TODO either way.
There was a problem hiding this comment.
Added a TODO and filed flutter/flutter#53784
| } | ||
|
|
||
| TEST_F(EmbedderTest, VerifyB143464703WithSoftwareBackend) { | ||
| #if !defined(OS_LINUX) |
There was a problem hiding this comment.
Golden tests are difficult to get right for all platforms.
Sigh. Very true. And, looking at this test, I am not sure why the assertions in the next presentation callback are not sufficient. The pixel test here seems to be redundant.
It's your call on if you want to skip or disable. But please file a bug with a linked TODO either way.
|
LUCI failures are a known infra issue right now |
|
I'll push the formatting fix once the linux engine builders are fixed. |
|
Going to land this to kick the tree again. None of the changes impact presubmits compared to the last round of presubmits that passed. |
* Reland "Roll Clang to v11, roll buildroot to fe13f79, allow newly exported symbols (flutter#17440)" (flutter#17451)" This reverts commit a870bc5. * skip golden that is different on macos * buildroot to 1bc40a5
…lutter#17464) This reverts commit a4026cc.
* Reland Clang 11, Roll buildroot to 1bc40a5 (flutter#17457)" (flutter#17464) This reverts commit 9eacd02. * Skip more image tests, use newer dsymutil, add missing symbols
Disables a test on Mac that now fails with the new toolchain due to minor pixel differences. Test is still enabled on Linux.
Rolls buildroot to flutter/buildroot@1bc40a5 to capture additional warning ignore guards for Xcode builds (e.g. bitcode enablded builds for iOS).
See also: #17451, #17440