This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Roll Clang to v11, roll buildroot to ee57ed9459f52adf9165e0adad4e74ba167c2f93, allow newly exported symbols #17440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Apr 1, 2020
goderbauer
approved these changes
Apr 1, 2020
Member
goderbauer
left a comment
There was a problem hiding this comment.
LGTM
Nice reduction in size!
Contributor
Author
|
Tree is green, landing. |
dnfield
added a commit
to dnfield/engine
that referenced
this pull request
Apr 1, 2020
…orted symbols (flutter#17440)" (flutter#17451)" This reverts commit a870bc5.
Contributor
|
Is there a bug tracking the lld zlib issue blocking the roll to a fresher Clang? We should find someone to chase that down and get this this toolchain on an autoroller. |
Contributor
Author
|
Filed flutter/flutter#53782 |
dnfield
added a commit
that referenced
this pull request
Apr 1, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 2, 2020
goderbauer
pushed a commit
to goderbauer/engine
that referenced
this pull request
Apr 16, 2020
…mbols (flutter#17440) * Buildroot to fe13f79 * whitelist more symbols
goderbauer
pushed a commit
to goderbauer/engine
that referenced
this pull request
Apr 16, 2020
…orted symbols (flutter#17440)" (flutter#17451) This reverts commit 8d723ae.
goderbauer
pushed a commit
to goderbauer/engine
that referenced
this pull request
Apr 16, 2020
* Reland "Roll Clang to v11, roll buildroot to fe13f79, allow newly exported symbols (flutter#17440)" (flutter#17451)" This reverts commit a870bc5. * skip golden that is different on macos * buildroot to 1bc40a5
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rolls to the latest GOMA-aware clang, along with the necessary buildroot config needed for it.
Although we have newly exported symbols,
flutter.jarends up significantly smaller than the one currently being built by our Clang 8.x toolchain - locally seeing a size of ~3.5mb compared to 3.7mb upstream for arm.If and when fxb/47943 is fixed, we can remove the allowances for newly exported symbols. We shouldn't have to worry about iOS because we don't use this clang for our bitcode enabled builds anyway on LUCI.
/cc @rmacnak-google fyi
/cc @goderbauer fyi