Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Revert "Roll Clang to v11, roll buildroot to ee57ed9459f52adf9165e0adad4e74ba167c2f93, allow newly exported symbols" #17451

Merged
dnfield merged 1 commit into from
Apr 1, 2020
Merged

Revert "Roll Clang to v11, roll buildroot to ee57ed9459f52adf9165e0adad4e74ba167c2f93, allow newly exported symbols" #17451

dnfield merged 1 commit into from
Apr 1, 2020

Conversation

@dnfield
Copy link
Contributor

@dnfield dnfield commented Apr 1, 2020

Reverts #17440

This broke Xcode bitcode builds - needs a couple more tweaks to buildroot and shoul dbe good. Failing build example here: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket.appspot.com/8884199962162400000/+/steps/build_ios_profile/0/stdout

clang++ -MD -MF obj/flutter/lib/io/io.dart_io.o.d -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -D_LIBCPP_ENABLE_THREAD_SAFETY_ANNOTATIONS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DNDEBUG -I../.. -Igen -I../../third_party/dart/runtime/include -I../.. -I../../flutter/third_party -I../../flutter -I../../third_party/dart/runtime -I../../third_party/dart/runtime/include -isysroot /b/s/w/ir/cache/osx_sdk/XCode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS13.0.sdk -miphoneos-version-min=8.0 -flto -fno-strict-aliasing -fembed-bitcode-marker -arch arm64 -fcolor-diagnostics -Wall -Wextra -Wendif-labels -Werror -Wno-missing-field-initializers -Wno-unused-parameter -Wno-implicit-int-float-conversion -Wno-c99-designator -Wno-non-c-typedef-for-linkage -Wno-deprecated-copy -Wno-range-loop-construct -Wunguarded-availability -fvisibility=hidden -stdlib=libc++ -Wstring-conversion -Wnewline-eof -Os -fno-ident -fdata-sections -ffunction-sections -g2 -Werror -Wall -Wextra -Wno-unused-parameter -Wno-unused-private-field -Wnon-virtual-dtor -Wvla -Wno-conversion-null -Woverloaded-virtual -Wno-comments -g3 -ggdb3 -fno-rtti -fno-exceptions -Wimplicit-fallthrough -O3 -fvisibility-inlines-hidden -std=c++17 -fno-rtti -fno-exceptions -nostdinc++ -isystem /b/s/w/ir/cache/osx_sdk/XCode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1  -c ../../flutter/lib/io/dart_io.cc -o obj/flutter/lib/io/io.dart_io.o
 error: unknown warning option '-Wno-implicit-int-float-conversion'; did you mean '-Wno-implicit-float-conversion'? [-Werror,-Wunknown-warning-option]
 error: unknown warning option '-Wno-c99-designator'; did you mean '-Wno-gnu-designator'? [-Werror,-Wunknown-warning-option]
 error: unknown warning option '-Wno-non-c-typedef-for-linkage'; did you mean '-Wno-return-type-c-linkage'? [-Werror,-Wunknown-warning-option]
 error: unknown warning option '-Wno-deprecated-copy'; did you mean '-Wno-deprecated'? [-Werror,-Wunknown-warning-option]
 error: unknown warning option '-Wno-range-loop-construct'; did you mean '-Wno-range-loop-analysis'? [-Werror,-Wunknown-warning-option]

Will land TBR @chinmaygarde @goderbauer

@dnfield dnfield merged commit a870bc5 into master Apr 1, 2020
@dnfield dnfield deleted the revert-17440-clang branch April 1, 2020 18:06
@dnfield dnfield mentioned this pull request Apr 1, 2020
Merged
@goderbauer
Copy link
Member

goderbauer commented Apr 1, 2020

LGTM

dnfield added a commit to dnfield/engine that referenced this pull request Apr 1, 2020
@dnfield
Reland "Roll Clang to v11, roll buildroot to fe13f79, allow newly exp…
3e66736 
…orted symbols (flutter#17440)" (flutter#17451)"

This reverts commit a870bc5.
@dnfield dnfield mentioned this pull request Apr 1, 2020
Merged
dnfield added a commit that referenced this pull request Apr 1, 2020
@dnfield
Reland Clang 11, Roll buildroot to 1bc40a5 (#17457)
a4026cc 
* Reland "Roll Clang to v11, roll buildroot to fe13f79, allow newly exported symbols (#17440)" (#17451)"

This reverts commit a870bc5.

* skip golden that is different on macos

* buildroot to 1bc40a5
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 2, 2020
@engine-flutter-autoroll
a870bc5 Revert "Roll Clang to v11, roll buildroot to fe13f79, allow n…
39efaf5 
…ewly exported symbols (flutter#17440)" (flutter/engine#17451)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 2, 2020
Merged
goderbauer pushed a commit to goderbauer/engine that referenced this pull request Apr 16, 2020
@dnfield @goderbauer
Revert "Roll Clang to v11, roll buildroot to fe13f79, allow newly exp…
bce7871 
…orted symbols (flutter#17440)" (flutter#17451)

This reverts commit 8d723ae.
goderbauer pushed a commit to goderbauer/engine that referenced this pull request Apr 16, 2020
@dnfield @goderbauer
Reland Clang 11, Roll buildroot to 1bc40a5 (flutter#17457)
3e93930 
* Reland "Roll Clang to v11, roll buildroot to fe13f79, allow newly exported symbols (flutter#17440)" (flutter#17451)"

This reverts commit a870bc5.

* skip golden that is different on macos

* buildroot to 1bc40a5
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dnfield @goderbauer @googlebot