This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reland Clang 11, roll buildroot to 1bc40a5f916adb93d87e2a2230a0ec43db876c1c, take 3 #17467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnfield
commented
Apr 2, 2020
Comment on lines
+189
to
+191
| // jit x86 | ||
| '__moddi3': 'T', | ||
| '__umoddi3': 'T', |
Contributor
Author
There was a problem hiding this comment.
The new symbols to whitelist.
I manually checked x64, that's fine with the current list.
Contributor
There was a problem hiding this comment.
This issues has been addressed in upstream by https://reviews.llvm.org/D77280
chinmaygarde
approved these changes
Apr 2, 2020
|
|
||
| if not os.path.isdir(arm64_framework): | ||
| print 'Cannot find iOS arm64 Framework at', arm64_framework | ||
| print('Cannot find iOS arm64 Framework at %s' % arm64_framework) |
Contributor
There was a problem hiding this comment.
Why the change to the prints?
Contributor
Author
There was a problem hiding this comment.
Move them to python3 friendly syntax. I'm assuming at some point the bots will be on python3
Contributor
Author
|
Going to land this again without waiting fora ll presubmits, for similar reasons as last time. Only post submits exercise all the failures this patch was addressing. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 2, 2020
dnfield
added a commit
to dnfield/engine
that referenced
this pull request
Apr 2, 2020
…lutter#17482)" This reverts commit 8166a91.
goderbauer
pushed a commit
to goderbauer/engine
that referenced
this pull request
Apr 16, 2020
* Reland Clang 11, Roll buildroot to 1bc40a5 (flutter#17457)" (flutter#17464) This reverts commit 9eacd02. * Skip more image tests, use newer dsymutil, add missing symbols
goderbauer
pushed a commit
to goderbauer/engine
that referenced
this pull request
Apr 16, 2020
…7467)" (flutter#17482) This reverts commit 39b7718.
goderbauer
pushed a commit
to goderbauer/engine
that referenced
this pull request
Apr 16, 2020
* "Reland Clang 11, roll buildroot to 1bc40a5, take 4 (flutter#17467)" (flutter#17482)" This reverts commit 8166a91. * format code * Roll buildroot to 3a27de1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes since the last patch:
See also: flutter/buildroot@1bc40a5, #17464