Skip to content

Conversation

@nilslindemann
Copy link
Contributor

@nilslindemann nilslindemann commented Sep 20, 2023

Closed in favor of #9502 by fhabers21.

* Full translation
* Based on fastapi#9502
* In sync with current en/docs/tutorial/index.md
* Hand-translated (Google translate rarely used)
* Checked for errors using LanguageTool
* Manually checked
@tiangolo
Copy link
Member

📝 Docs preview for commit 792e8d5 at: https://cc9c4695.fastapitiangolo.pages.dev

@GeorchW
Copy link
Contributor

GeorchW commented Sep 21, 2023

I think this has been done before, too: #9502
This is true for multiple of your PRs. Could you check which of the PRs (both yours and the existing ones) should maybe be merged and which should be closed?

@nilslindemann
Copy link
Contributor Author

nilslindemann commented Sep 21, 2023

@GeorchW "See commit description" ;-)
#9502 can be closed, this one is based on it.

For an explanation why I recreated some PRs, see here.

@nilslindemann
Copy link
Contributor Author

nilslindemann commented Sep 21, 2023

@GeorchW @tiangolo @DevSpace88 and others I do not know yet

To be precise,

#10283 is based on #3631
#10284 is independent
#10285 is based on #3048
#10287 is based on #3048
#10288 is based on #9502
#10289 is based on #9530
#10290 is independent
#10293 is independent
#10295 is independent

#3631, #3048, #9502 and #9530 can be closed. My PRs contain them, add translations, fix errors, and sync to the current English docs.

#10281 by @DevSpace88 and #10290 by me is an accidental clash. See here. Others may decide which is better. It is ok if you close mine, because it was later, though I admit, I like mine better, because I use "Sie", where he uses "man", which is less direct in my opinion.

I now check here and here before every new translation. I post here on which translation I am currently working.

My following PRs (since #10290) will not cause this problem anymore, because there exists no translation for these documents. I go through the documents in the order they are listed in the docs .

@nilslindemann nilslindemann changed the title German translation of docs/tutorial/index.md Update German translation of docs/tutorial/index.md Sep 23, 2023
Translating the text changed the icon and coloring of the box
@tiangolo
Copy link
Member

📝 Docs preview for commit 6a7c88f at: https://967ccac3.fastapitiangolo.pages.dev

@tiangolo
Copy link
Member

📝 Docs preview for commit 9cee7c8 at: https://9075d2f7.fastapitiangolo.pages.dev

@nilslindemann nilslindemann changed the title Update German translation of docs/tutorial/index.md 🌐 Update German translation of docs/tutorial/index.md Sep 26, 2023
@nilslindemann nilslindemann changed the title 🌐 Update German translation of docs/tutorial/index.md 🌐 Update German translation for docs/tutorial/index.md Sep 28, 2023
@nilslindemann nilslindemann changed the title 🌐 Update German translation for docs/tutorial/index.md 🌐 Update German translation for docs/de/docs/tutorial/index.md Sep 29, 2023
@tiangolo
Copy link
Member

📝 Docs preview for commit 698749f at: https://21ac2245.fastapitiangolo.pages.dev

Nils Lindemann added 2 commits September 30, 2023 16:34
@tiangolo
Copy link
Member

📝 Docs preview for commit 13f5525 at: https://27e1fece.fastapitiangolo.pages.dev

@fhabers21
Copy link
Contributor

fhabers21 commented Oct 4, 2023

@nilslindemann
#9530 already has one approval, so if you tell me what I should change, and afterwards you review it, we could get it merged.

#9502 has not been reviewed yet, so I could close it (though I don't really understand what's wrong with it).

@tiangolo
Copy link
Member

tiangolo commented Oct 5, 2023

📝 Docs preview for commit bc85132 at: https://2a7afc89.fastapitiangolo.pages.dev

@nilslindemann
Copy link
Contributor Author

nilslindemann commented Oct 5, 2023

Hello @fhabers21,

I do not know anymore why I recreated your PRs. If you do not mind, I will close my PRs and point to yours.

Greetings, Nils

nilslindemann pushed a commit to nilslindemann/fastapi that referenced this pull request Nov 2, 2023
nilslindemann pushed a commit to nilslindemann/fastapi that referenced this pull request Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-review lang-all Translations lang-de German translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants