Subscribed to pull request

Generated by CodeMention

Bug Fixes

1. ComposeViewProp.kt - Use current props state instead of initial instance

   • When updating props, was copying from initial props instance
   • Now correctly uses propsMutableState.value to preserve other prop changes

2. ViewEvent.kt - Smart validation for DSL views

   • DSL views share the same class (ComposeFunctionHolder)
   • Skip event validation when multiple view definitions share same viewType
   • Prevents incorrect validation errors for DSL components

3. HostView.kt - Bounded infinite constraints

   • When matchContents is used, constraints can have infinite maxWidth/maxHeight
   • DatePicker and segmented Picker use horizontal scrolling internally and crash with infinite constraints
   • Fixed by bounding infinite values to screen size

4. PickerView.kt - PickerOptionSelectedEvent properly extends Record

   • Event classes need @Field annotations to be serializable to JS
   • Was causing crash when clicking Picker options

DSL Pattern Refactoring + Modifiers Fix

Changes

1. DSL Pattern Migration - Migrated Button, Chip, IconButton, Shape, ContextMenu, and other components to DSL pattern

   // Before (class-based)
   class ButtonView(context: Context, appContext: AppContext) : ExpoComposeView<ButtonProps>(...) {
     @Composable
     override fun Content() { ... }
   }
   
   // After (DSL)
   View("Button") { props: ButtonProps ->
     ButtonContent(props)
   }

2. Modifiers Fix - Removed __expo_shared_object_id__ mapping in JS

   // Before (broken - ModifierConfig doesn't have __expo_shared_object_id__)
   modifiers={props.modifiers?.map((m) => m.__expo_shared_object_id__)}
   
   // After (fixed - pass JSON Config directly)
   modifiers={props.modifiers}

3. expo-modules-core fixes

   • Fixed DSL view props using stale state when updating (ComposeViewProp.kt)

Architecture Decision: JSON Config Pattern for Modifiers

Context

expo-ui needs to pass native view modifiers (Jetpack Compose Modifier, SwiftUI view modifiers) from JavaScript to native layers.

Technical Constraints:

• Fabric codegen generates typed C++ structs from TS/Flow component specs
• JSI HostObject props are not supported in stable Fabric; view props must be JSON-serializable
• Jetpack Compose Modifier is an opaque chain of function calls and cannot be serialized directly

Decision: JSON Config Pattern

JavaScript
  const mod = paddingAll(10);
  // { $type: 'paddingAll', all: 10 }

React Native
  <Button modifiers={[mod]} />

Android (Kotlin)
  - ModifierConfig Record parses the JSON
  - ModifierRegistry applies the config to build a Compose Modifier chain

ModifierConfig (JS)

export interface ModifierConfig {
  $type: string;
  $scope?: string;
  [key: string]: unknown;
}

ModifierConfig (Android Record)

data class ModifierConfig(
  @Field(key = "\$type") val type: String = "",
  ...
) : Record

Why JSON Config over SharedRef?

The SharedRef + ID Registry approach is deprecated. ExpoModifier is now a TypeScript alias of ModifierConfig.

References

Hi @kimchi-developer – awesome PR and a lot of work saved – thank you!

Noticed too late you saw my PR and found that source set issue so I merged that one, here's a PR following your suggestion – I like it but I renamed the interface – feel free to review it.

#41685

I'll try to review the rest of your PR asap.

@aleqsio Hey! This builds on your compose modifiers work (#38630, #39155). Would appreciate your review when you have time.

i would update expo-ui code soon and don't want to keep the pr conflict again. i'm going to merge it and will follow my comment in a separate pr. thanks again for the great work 👏