Skip to content

[ui][android] Fix events for functional view definitions.#41374

Merged
aleqsio merged 1 commit intomainfrom
@aleqsio/12-03-_ui_android_fix_events_for_functional_view_definitions
Dec 16, 2025
Merged

[ui][android] Fix events for functional view definitions.#41374
aleqsio merged 1 commit intomainfrom
@aleqsio/12-03-_ui_android_fix_events_for_functional_view_definitions

Conversation

@aleqsio
Copy link
Copy Markdown
Contributor

@aleqsio aleqsio commented Dec 3, 2025 •
edited
Loading

Why

Events didn't work when having multiple ComposeFunctionHolders in one module.

How

Tracking events by name not by view class.

Test Plan

Tested in a tester app.

Checklist

This was referenced Dec 3, 2025
Merged
Merged
Merged
@aleqsio Graphite App
Copy link
Copy Markdown
Contributor Author

aleqsio commented Dec 3, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@aleqsio aleqsio mentioned this pull request Dec 3, 2025
Merged
3 tasks
@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Dec 3, 2025
@aleqsio aleqsio marked this pull request as ready for review December 3, 2025 14:32
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 3, 2025 •
edited
Loading

Subscribed to pull request

File Patterns Mentions
packages/expo-modules-core/** @Kudo, @lukmccall
packages/expo-ui/** @behenate, @douglowder

Generated by CodeMention

@aleqsio aleqsio force-pushed the @aleqsio/11-25-_ui_android_add_a_few_modifiers branch from bf6365f to 752cf40 Compare December 3, 2025 14:49
@aleqsio aleqsio force-pushed the @aleqsio/12-03-_ui_android_fix_events_for_functional_view_definitions branch from 66a73c3 to 8d9e5fe Compare December 3, 2025 14:49
@aleqsio aleqsio force-pushed the @aleqsio/12-03-_ui_android_fix_events_for_functional_view_definitions branch from 8d9e5fe to 074bbc4 Compare December 3, 2025 17:08
@aleqsio aleqsio force-pushed the @aleqsio/11-25-_ui_android_add_a_few_modifiers branch 2 times, most recently from 397a109 to e4a88c8 Compare December 3, 2025 17:18
@aleqsio aleqsio force-pushed the @aleqsio/12-03-_ui_android_fix_events_for_functional_view_definitions branch 2 times, most recently from 45e08e5 to 777ea64 Compare December 3, 2025 17:20
@aleqsio aleqsio force-pushed the @aleqsio/11-25-_ui_android_add_a_few_modifiers branch from e4a88c8 to 71f01f2 Compare December 3, 2025 17:20
@aleqsio aleqsio force-pushed the @aleqsio/12-03-_ui_android_fix_events_for_functional_view_definitions branch from 777ea64 to 8766342 Compare December 3, 2025 17:23
@aleqsio aleqsio force-pushed the @aleqsio/11-25-_ui_android_add_a_few_modifiers branch from 71f01f2 to 3723298 Compare December 3, 2025 17:23
@aleqsio aleqsio changed the base branch from @aleqsio/11-25-_ui_android_add_a_few_modifiers to graphite-base/41374 December 3, 2025 17:39
@aleqsio aleqsio force-pushed the graphite-base/41374 branch from 3723298 to 5a2e7f8 Compare December 3, 2025 17:41
@aleqsio aleqsio force-pushed the @aleqsio/12-03-_ui_android_fix_events_for_functional_view_definitions branch from 8766342 to eb28fbf Compare December 3, 2025 17:41
@graphite-app graphite-app bot changed the base branch from graphite-base/41374 to main December 3, 2025 17:42
@aleqsio aleqsio force-pushed the @aleqsio/12-03-_ui_android_fix_events_for_functional_view_definitions branch from eb28fbf to 3f14ddf Compare December 3, 2025 17:42
@aleqsio aleqsio force-pushed the @aleqsio/12-03-_ui_android_fix_events_for_functional_view_definitions branch from 3f14ddf to 20f8086 Compare December 3, 2025 17:42
@expo-bot
Copy link
Copy Markdown
Collaborator

expo-bot commented Dec 3, 2025 •
edited
Loading

The Pull Request introduced fingerprint changes against the base commit: 5a2e7f8

Fingerprint diff 
[
  {
    "op": "changed",
    "beforeSource": {
      "type": "dir",
      "filePath": "../../packages/expo-modules-core",
      "reasons": [
        "expoAutolinkingIos",
        "expoAutolinkingAndroid",
        "expoAutolinkingIos"
      ],
      "hash": "0ea8b2ac87a722a59e9bafc5ce85bd9e0859525a"
    },
    "afterSource": {
      "type": "dir",
      "filePath": "../../packages/expo-modules-core",
      "reasons": [
        "expoAutolinkingIos",
        "expoAutolinkingAndroid",
        "expoAutolinkingIos"
      ],
      "hash": "245aae8585c97035fe6f85036685f63c340b2193"
    }
  }
]

Generated by PR labeler 🤖

@expo-bot
Copy link
Copy Markdown
Collaborator

expo-bot commented Dec 3, 2025

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

⚠️ Suggestion: Missing changelog entries


Your changes should be noted in the changelog, e.g.:
- [android] Fix events for functional view definitions. ([#41374](https://github.com/expo/expo/pull/41374) by [@aleqsio](https://github.com/aleqsio))
Read Updating Changelogs guide and consider adding an appropriate entry to the following changelogs:

Generated by ExpoBot 🤖 against 20f8086

@aleqsio aleqsio mentioned this pull request Dec 3, 2025
Draft
3 tasks
@aleqsio aleqsio mentioned this pull request Dec 4, 2025
Draft
3 tasks
@kimchi-developer kimchi-developer mentioned this pull request Dec 15, 2025
Merged
3 tasks
@aleqsio aleqsio merged commit e452e4a into main Dec 16, 2025
15 of 16 checks passed
@aleqsio aleqsio deleted the @aleqsio/12-03-_ui_android_fix_events_for_functional_view_definitions branch December 16, 2025 22:33
@aleqsio aleqsio mentioned this pull request Dec 16, 2025
Merged
3 tasks
aleqsio added a commit that referenced this pull request Dec 22, 2025
@aleqsio
[ui][android] Fix events for functional view definitions. (#41374)
1e07690
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kudo Kudo Kudo approved these changes

@lukmccall lukmccall lukmccall approved these changes

Assignees

No one assigned

Labels

bot: fingerprint changed bot: suggestions ExpoBot has some suggestions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aleqsio @expo-bot @Kudo @lukmccall