Merged
Conversation
Contributor
Author
This was referenced Nov 25, 2025
Collaborator
|
The Pull Request introduced fingerprint changes against the base commit: 94a23f5 Fingerprint diff[
{
"op": "changed",
"beforeSource": {
"type": "dir",
"filePath": "../../packages/expo-ui/android",
"reasons": [
"expoAutolinkingAndroid"
],
"hash": "07599c4d772481d062ceb38a738fcd3194cbb59b"
},
"afterSource": {
"type": "dir",
"filePath": "../../packages/expo-ui/android",
"reasons": [
"expoAutolinkingAndroid"
],
"hash": "191c36707802ba844bf3a4183c0e696dabe56296"
}
}
]Generated by PR labeler 🤖 |
527b5ef to
44918dc
Compare
8f1c134 to
3fcd734
Compare
44918dc to
497b352
Compare
Contributor
|
Subscribed to pull request
Generated by CodeMention |
Kudo
approved these changes
Nov 27, 2025
Contributor
Kudo
left a comment
There was a problem hiding this comment.
-
leaving some ni comments but we can follow up in separate pr. given this code are referenced from <Button> directly, we can update with <Button> together later.
-
would be good to add NCL example. i'm not quite clear that how to pass an icon to <IconButton>
| val (colors) = props.elementColors | ||
| val (disabled) = props.disabled | ||
|
|
||
| DynamicTheme { |
Contributor
There was a problem hiding this comment.
fine for now but i was thinking to keep each component as simple and 1:1 mapping from js <-> compose. we should reduce DynamicTheme in most of places. maybe just keep DynamicTheme in the <Host> component.
| ), | ||
| shape = shapeFromShapeRecord(props.shape.value) | ||
| ) { | ||
| Box(modifier = Modifier.fillMaxSize()) { |
Contributor
There was a problem hiding this comment.
ditto. we may try to remove the Box here
3 tasks
03eac30 to
6c77bce
Compare
090fb5b to
01198d0
Compare
Contributor
Author
6c77bce to
10725bb
Compare
This was referenced Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
It's a different compose component from the regular button. While you can get mostly the same thing with a regular button it seems a common enough pattern to warrant a native component (?) – open to discussing.
How
Test Plan
Checklist
changelog.mdentry and rebuilt the package sources according to this short guidenpx expo prebuild& EAS Build (eg: updated a module plugin).