[ui][android] DO_NOT_MERGE Add native drawer.#41384
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇
|
|
The Pull Request introduced fingerprint changes against the base commit: 5a2e7f8 Fingerprint diff[
{
"op": "changed",
"beforeSource": {
"type": "dir",
"filePath": "../../packages/expo-modules-core",
"reasons": [
"expoAutolinkingIos",
"expoAutolinkingAndroid",
"expoAutolinkingIos"
],
"hash": "0ea8b2ac87a722a59e9bafc5ce85bd9e0859525a"
},
"afterSource": {
"type": "dir",
"filePath": "../../packages/expo-modules-core",
"reasons": [
"expoAutolinkingIos",
"expoAutolinkingAndroid",
"expoAutolinkingIos"
],
"hash": "245aae8585c97035fe6f85036685f63c340b2193"
}
},
{
"op": "changed",
"beforeSource": {
"type": "dir",
"filePath": "../../packages/expo-ui/android",
"reasons": [
"expoAutolinkingAndroid"
],
"hash": "04adccbab30396483749b362cdbc3024f7977043"
},
"afterSource": {
"type": "dir",
"filePath": "../../packages/expo-ui/android",
"reasons": [
"expoAutolinkingAndroid"
],
"hash": "f5ef1c2a947d053b6dbe18094796ab0ad7b641c3"
}
}
]Generated by PR labeler 🤖 |
Why
I was working on the wikireader app, and the main feature I was missing was a navigation drawer.
It's still a draft, need to think how and where to land this but this aligns with expo-router APIs.
How
Copied over
@react-navigation/drawerand changed code to use the new expo-ui NavigationDrawer component.This also allows using compose components as items of the drawer, though the API is restrictive enough where it's hard to fully customize it I think.
Will explore using NavigationRail as an option/instead of the drawer.
Test Plan
Checklist
changelog.mdentry and rebuilt the package sources according to this short guidenpx expo prebuild& EAS Build (eg: updated a module plugin).