Skip to content

[ui][android] Remove style props from components.#41233

Merged
aleqsio merged 2 commits intomainfrom
@aleqsio/11-25-_ui_android_remove_style_props_from_components
Dec 3, 2025
Merged

[ui][android] Remove style props from components.#41233
aleqsio merged 2 commits intomainfrom
@aleqsio/11-25-_ui_android_remove_style_props_from_components

Conversation

@aleqsio
Copy link
Copy Markdown
Contributor

@aleqsio aleqsio commented Nov 25, 2025 •
edited
Loading

Why

The style prop doesn't affect components that require <Host>

How

Removed the prop.

Test Plan

Checklist

@aleqsio aleqsio mentioned this pull request Nov 25, 2025
Merged
3 tasks
@aleqsio Graphite App
Copy link
Copy Markdown
Contributor Author

aleqsio commented Nov 25, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Nov 25, 2025
Merged
Merged
@aleqsio aleqsio force-pushed the @aleqsio/11-25-_ui_android_remove_style_props_from_components branch from ca5d72b to 07d2dde Compare November 25, 2025 17:49
@aleqsio aleqsio force-pushed the @aleqsio/11-25-_ui_android_add_iconbutton branch from 527b5ef to 44918dc Compare November 25, 2025 17:49
@aleqsio aleqsio force-pushed the @aleqsio/11-25-_ui_android_remove_style_props_from_components branch from 07d2dde to b7ffa4e Compare November 25, 2025 18:07
@aleqsio aleqsio force-pushed the @aleqsio/11-25-_ui_android_add_iconbutton branch from 44918dc to 497b352 Compare November 25, 2025 18:07
@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Nov 25, 2025
@aleqsio aleqsio marked this pull request as ready for review November 26, 2025 11:18
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 26, 2025

Subscribed to pull request

File Patterns Mentions
packages/expo-ui/** @behenate, @douglowder

Generated by CodeMention

@aleqsio aleqsio mentioned this pull request Dec 3, 2025
Merged
3 tasks
@aleqsio aleqsio force-pushed the @aleqsio/11-25-_ui_android_remove_style_props_from_components branch from b7ffa4e to 3d06cf9 Compare December 3, 2025 14:49
@aleqsio aleqsio force-pushed the @aleqsio/11-25-_ui_android_add_iconbutton branch 2 times, most recently from 20c8dfb to 03eac30 Compare December 3, 2025 17:08
@aleqsio aleqsio force-pushed the @aleqsio/11-25-_ui_android_remove_style_props_from_components branch from 3d06cf9 to fe18451 Compare December 3, 2025 17:08
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Dec 3, 2025
@aleqsio aleqsio force-pushed the @aleqsio/11-25-_ui_android_add_iconbutton branch from 03eac30 to 6c77bce Compare December 3, 2025 17:23
@aleqsio aleqsio force-pushed the @aleqsio/11-25-_ui_android_remove_style_props_from_components branch from cd41d44 to 54dc489 Compare December 3, 2025 17:23
@aleqsio Graphite App
Copy link
Copy Markdown
Contributor Author

aleqsio commented Dec 3, 2025 •
edited
Loading

Merge activity

  • Dec 3, 5:32 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Dec 3, 5:38 PM UTC: Graphite rebased this pull request as part of a merge.
  • Dec 3, 5:38 PM UTC: @aleqsio merged this pull request with Graphite.

@aleqsio aleqsio changed the base branch from @aleqsio/11-25-_ui_android_add_iconbutton to graphite-base/41233 December 3, 2025 17:34
@aleqsio aleqsio changed the base branch from graphite-base/41233 to main December 3, 2025 17:36
@aleqsio aleqsio force-pushed the @aleqsio/11-25-_ui_android_remove_style_props_from_components branch from 54dc489 to 6f9ba61 Compare December 3, 2025 17:37
@aleqsio aleqsio merged commit 38f5ba8 into main Dec 3, 2025
8 of 9 checks passed
@aleqsio aleqsio deleted the @aleqsio/11-25-_ui_android_remove_style_props_from_components branch December 3, 2025 17:38
This was referenced Dec 3, 2025
Draft
Draft
@Kudo Kudo added the published Changes from the PR have been published to npm label Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kudo Kudo Kudo approved these changes

@intergalacticspacehighway intergalacticspacehighway intergalacticspacehighway approved these changes

Assignees

No one assigned

Labels

bot: fingerprint compatible bot: passed checks ExpoBot has nothing to complain about published Changes from the PR have been published to npm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aleqsio @Kudo @intergalacticspacehighway @expo-bot