[core][android] Fix source sets for compose events.#41685
Merged
Conversation
Contributor
|
Subscribed to pull request
Generated by CodeMention |
Collaborator
|
The Pull Request introduced fingerprint changes against the base commit: 444e4b7 Fingerprint diff[
{
"op": "changed",
"beforeSource": {
"type": "dir",
"filePath": "../../packages/expo-modules-core",
"reasons": [
"expoAutolinkingIos",
"expoAutolinkingAndroid",
"expoAutolinkingIos"
],
"hash": "f79bfcba3fcd5aa8bc106746aebb1e56f13e76ca"
},
"afterSource": {
"type": "dir",
"filePath": "../../packages/expo-modules-core",
"reasons": [
"expoAutolinkingIos",
"expoAutolinkingAndroid",
"expoAutolinkingIos"
],
"hash": "fa027c0d4978f911f882993bb17e92eba960ee7e"
}
}
]Generated by PR labeler 🤖 |
3 tasks
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
lukmccall
approved these changes
Dec 17, 2025
...ages/expo-modules-core/android/src/main/java/expo/modules/kotlin/views/ViewFunctionHolder.kt
Outdated
Show resolved
Hide resolved
…kotlin/views/ViewFunctionHolder.kt Co-authored-by: Łukasz Kosmaty <kosmatylukasz@gmail.com>
aleqsio
added a commit
that referenced
this pull request
Dec 22, 2025
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com> Co-authored-by: Łukasz Kosmaty <kosmatylukasz@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Fixing brownfield tester, a followup to #41374
Good suggestion here: #41622 (comment)
How
Added an interface so that brownfield tester still works.
Test Plan
Tested in bare expo if it doesn't break, hope CI will make sure brownfield tester works.
Checklist
changelog.mdentry and rebuilt the package sources according to this short guidenpx expo prebuild& EAS Build (eg: updated a module plugin).