Merged
Conversation
Collaborator
|
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇
|
Collaborator
|
The Pull Request introduced fingerprint changes against the base commit: 543def9 Fingerprint diff[
{
"op": "changed",
"source": {
"type": "dir",
"filePath": "../../node_modules/expo",
"reasons": [
"bareRncliAutolinking"
],
"hash": "d32d189df25878181ae467ebba16e97b5518a042"
}
},
{
"op": "changed",
"source": {
"type": "dir",
"filePath": "../../packages/expo",
"reasons": [
"expoAutolinkingIos",
"expoAutolinkingAndroid",
"expoConfigPlugins",
"expoConfigPlugins"
],
"hash": "9235ee5e4f043b4102b0661031433ab1059c9862"
}
},
{
"op": "changed",
"source": {
"type": "dir",
"filePath": "../../packages/expo-modules-core",
"reasons": [
"expoAutolinkingIos",
"expoAutolinkingAndroid"
],
"hash": "bc02dda50a5c7a552b0d1b3a570659ab4eb49ee9"
}
}
]Generated by PR labeler 🤖 |
Kudo
approved these changes
Jul 6, 2024
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
SharedRefis a special case ofSharedObject. The difference between them matters only on the native side, but it still seems worth exposing it as a separate class.How
Export
SharedRefclass from the expo package, just like we already do withNativeModuleandSharedObjectTest Plan
Confirmed that the class can be imported from
expopackage