Don't honor VERSION_QUALIFIER if set but empty#17032
Merged
dliappis merged 3 commits intoelastic:mainfrom Feb 7, 2025
Merged
Conversation
PR#17006 revealed that the `VERSION_QUALIFIER` env var gets honored in various scripts when present but empty. This shouldn't be the case as the DRA process is designed to gracefully ignore empty values for this variable. This commit changes various ruby scripts to not treat "" as truthy. Bash scripts (used by CI etc.) are already ok with this as part of refactorings done in elastic#16907.
andsel
approved these changes
Feb 7, 2025
Member
andsel
left a comment
There was a problem hiding this comment.
LGTM
left a couple of suggestions to make the condition consistent in all places
Co-authored-by: Andrea Selva <selva.andre@gmail.com>
Co-authored-by: Andrea Selva <selva.andre@gmail.com>
|
💚 Build Succeeded
History
cc @dliappis |
Contributor
Author
|
@logstashmachine backport 9.0 |
Contributor
Author
|
@logstashmachine backport 8.x |
Contributor
Author
|
@logstashmachine backport 8.18 |
Contributor
Author
|
@logstashmachine backport 8.17 |
Contributor
Author
|
@logstashmachine backport 8.16 |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 7, 2025
PR #17006 revealed that the `VERSION_QUALIFIER` env var gets honored in various scripts when present but empty. This shouldn't be the case as the DRA process is designed to gracefully ignore empty values for this variable. This commit changes various ruby scripts to not treat "" as truthy. Bash scripts (used by CI etc.) are already ok with this as part of refactorings done in #16907. --------- Co-authored-by: Andrea Selva <selva.andre@gmail.com> (cherry picked from commit c7204fd)
Contributor
Author
|
Backports to 8.x/8.18/8.17/8.16 have conflicts due to lack of backports of #16904; left a comment in #16904 (comment) |
dliappis
added a commit
that referenced
this pull request
Feb 7, 2025
PR #17006 revealed that the `VERSION_QUALIFIER` env var gets honored in various scripts when present but empty. This shouldn't be the case as the DRA process is designed to gracefully ignore empty values for this variable. This commit changes various ruby scripts to not treat "" as truthy. Bash scripts (used by CI etc.) are already ok with this as part of refactorings done in #16907. --------- Co-authored-by: Andrea Selva <selva.andre@gmail.com> (cherry picked from commit c7204fd) Co-authored-by: Dimitrios Liappis <dimitrios.liappis@gmail.com>
Contributor
Author
|
@logstashmachine backport 8.x |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 12, 2025
PR #17006 revealed that the `VERSION_QUALIFIER` env var gets honored in various scripts when present but empty. This shouldn't be the case as the DRA process is designed to gracefully ignore empty values for this variable. This commit changes various ruby scripts to not treat "" as truthy. Bash scripts (used by CI etc.) are already ok with this as part of refactorings done in #16907. --------- Co-authored-by: Andrea Selva <selva.andre@gmail.com> (cherry picked from commit c7204fd)
Contributor
Author
|
@logstashmachine backport 8.18 |
Contributor
Author
|
@logstashmachine backport 8.17 |
Contributor
Author
|
@logstashmachine backport 8.16 |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 12, 2025
PR #17006 revealed that the `VERSION_QUALIFIER` env var gets honored in various scripts when present but empty. This shouldn't be the case as the DRA process is designed to gracefully ignore empty values for this variable. This commit changes various ruby scripts to not treat "" as truthy. Bash scripts (used by CI etc.) are already ok with this as part of refactorings done in #16907. --------- Co-authored-by: Andrea Selva <selva.andre@gmail.com> (cherry picked from commit c7204fd)
github-actions bot
pushed a commit
that referenced
this pull request
Feb 12, 2025
PR #17006 revealed that the `VERSION_QUALIFIER` env var gets honored in various scripts when present but empty. This shouldn't be the case as the DRA process is designed to gracefully ignore empty values for this variable. This commit changes various ruby scripts to not treat "" as truthy. Bash scripts (used by CI etc.) are already ok with this as part of refactorings done in #16907. --------- Co-authored-by: Andrea Selva <selva.andre@gmail.com> (cherry picked from commit c7204fd)
github-actions bot
pushed a commit
that referenced
this pull request
Feb 12, 2025
PR #17006 revealed that the `VERSION_QUALIFIER` env var gets honored in various scripts when present but empty. This shouldn't be the case as the DRA process is designed to gracefully ignore empty values for this variable. This commit changes various ruby scripts to not treat "" as truthy. Bash scripts (used by CI etc.) are already ok with this as part of refactorings done in #16907. --------- Co-authored-by: Andrea Selva <selva.andre@gmail.com> (cherry picked from commit c7204fd)
dliappis
added a commit
that referenced
this pull request
Feb 12, 2025
PR #17006 revealed that the `VERSION_QUALIFIER` env var gets honored in various scripts when present but empty. This shouldn't be the case as the DRA process is designed to gracefully ignore empty values for this variable. This commit changes various ruby scripts to not treat "" as truthy. Bash scripts (used by CI etc.) are already ok with this as part of refactorings done in #16907. --------- Co-authored-by: Andrea Selva <selva.andre@gmail.com> (cherry picked from commit c7204fd) Co-authored-by: Dimitrios Liappis <dimitrios.liappis@gmail.com>
dliappis
added a commit
that referenced
this pull request
Feb 12, 2025
PR #17006 revealed that the `VERSION_QUALIFIER` env var gets honored in various scripts when present but empty. This shouldn't be the case as the DRA process is designed to gracefully ignore empty values for this variable. This commit changes various ruby scripts to not treat "" as truthy. Bash scripts (used by CI etc.) are already ok with this as part of refactorings done in #16907. --------- Co-authored-by: Andrea Selva <selva.andre@gmail.com> (cherry picked from commit c7204fd) Co-authored-by: Dimitrios Liappis <dimitrios.liappis@gmail.com>
dliappis
added a commit
that referenced
this pull request
Feb 12, 2025
PR #17006 revealed that the `VERSION_QUALIFIER` env var gets honored in various scripts when present but empty. This shouldn't be the case as the DRA process is designed to gracefully ignore empty values for this variable. This commit changes various ruby scripts to not treat "" as truthy. Bash scripts (used by CI etc.) are already ok with this as part of refactorings done in #16907. --------- Co-authored-by: Andrea Selva <selva.andre@gmail.com> (cherry picked from commit c7204fd) Co-authored-by: Dimitrios Liappis <dimitrios.liappis@gmail.com>
dliappis
added a commit
that referenced
this pull request
Feb 12, 2025
PR #17006 revealed that the `VERSION_QUALIFIER` env var gets honored in various scripts when present but empty. This shouldn't be the case as the DRA process is designed to gracefully ignore empty values for this variable. This commit changes various ruby scripts to not treat "" as truthy. Bash scripts (used by CI etc.) are already ok with this as part of refactorings done in #16907. --------- Co-authored-by: Andrea Selva <selva.andre@gmail.com> (cherry picked from commit c7204fd) Co-authored-by: Dimitrios Liappis <dimitrios.liappis@gmail.com>
v1v
pushed a commit
to v1v/logstash
that referenced
this pull request
Feb 25, 2025
PR elastic#17006 revealed that the `VERSION_QUALIFIER` env var gets honored in various scripts when present but empty. This shouldn't be the case as the DRA process is designed to gracefully ignore empty values for this variable. This commit changes various ruby scripts to not treat "" as truthy. Bash scripts (used by CI etc.) are already ok with this as part of refactorings done in elastic#16907. --------- Co-authored-by: Andrea Selva <selva.andre@gmail.com>
v1v
added a commit
to v1v/logstash
that referenced
this pull request
Feb 25, 2025
…gify * upstream/main: (27 commits) Add Windows 2025 to CI (elastic#17133) Update container acceptance tests with stdout/stderr changes (elastic#17138) entrypoint: avoid polluting stdout (elastic#17125) Fix acceptance test assertions for updated plugin remove (elastic#17126) Fix acceptance test assertions for updated plugin `remove` (elastic#17122) plugins: improve `remove` command to support multiple plugins (elastic#17030) spec: improve ls2ls spec (elastic#17114) allow concurrent Batch deserialization (elastic#17050) CPM handle 404 response gracefully with user-friendly log (elastic#17052) qa: use clean expansion of LS tarball per fixture instance (elastic#17082) Allow capturing heap dumps in DRA BK jobs (elastic#17081) Use centralized source of truth for active branches (elastic#17063) Update logstash_releases.json (elastic#17055) fix logstash-keystore to accept spaces in values when added via stdin (elastic#17039) Don't honor VERSION_QUALIFIER if set but empty (elastic#17032) Release note placeholder might be empty, making parsing lines nil tolerant. (elastic#17026) Fix BufferedTokenizer to properly resume after a buffer full condition respecting the encoding of the input string (elastic#16968) Add short living 9.0 next and update main in CI release version definition. (elastic#17008) Core version bump to 9.1.0 (elastic#16991) Add 9.0 branch to the CI branches definition (elastic#16997) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release notes
[rn:skip]
What does this PR do?
PR#17006 revealed that the
VERSION_QUALIFIERenv var gets honored in various scripts when present but empty.This shouldn't be the case as the DRA process is designed to gracefully ignore empty values for this variable.
This commit changes various ruby scripts to not treat "" as truthy. Bash scripts (used by CI etc.) are already ok with this as part of refactorings done in #16907.
Why is it important/What is the impact to the user?
Makes the behavior consistent with DRA guidelines and allows to re-revert PR#17006
How to test this PR locally
Best tested with Buildkite. Test builds using this PR, DRA_BRABCH=main and
VERSION_QUALIFIER="":snapshot: https://buildkite.com/elastic/logstash-dra-snapshot-pipeline/builds/2169#_
staging (dry_run=true, so no publishing): https://buildkite.com/elastic/logstash-dra-staging-pipeline/builds/194
Also tested staging with dry_run=true and VERSION_QUALIFIER="alpha1" (this isn't getting published): https://buildkite.com/elastic/logstash-dra-staging-pipeline/builds/196