Skip to content

Update container acceptance tests with stdout/stderr changes#17138

Merged
donoghuc merged 1 commit intoelastic:mainfrom
donoghuc:check-std-err
Feb 21, 2025
Merged

Update container acceptance tests with stdout/stderr changes#17138
donoghuc merged 1 commit intoelastic:mainfrom
donoghuc:check-std-err

Conversation

@donoghuc
Copy link
Copy Markdown
Member

Release notes

[rn:skip]

What does this PR do?

In #17125 jvm setup was redirected to stderr to avoid polluting stdout. This test was actually having to do some additional processing to parse that information. Now that we have split the destinations the tests can be simplified to look for the data they are trying to validate on the appropriate stream.

Why is it important/What is the impact to the user?

No user impact, just a test fix.

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files (and/or docker env variables)
    - [ ] I have added tests that prove my fix is effective or that my feature works

Related issues

Failing tests

Failures:
--
  |  
  | 1) A container running the wolfi image behaves like the container is configured correctly logstash should run with the bundled JDK
  | Failure/Error: DEFAULT_FAILURE_NOTIFIER = lambda { \|failure, _opts\| raise failure }
  |  
  | expected "logstash 9.1.0" to match /Using bundled JDK: \/usr\/share\/logstash\/jdk/
  | Diff:
  | @@ -1 +1 @@
  | -/Using bundled JDK: \/usr\/share\/logstash\/jdk/
  | +"logstash 9.1.0"
  |  
  | Shared Example Group: "the container is configured correctly" called from ./docker/spec/wolfi/container_spec.rb:8
  | # ./docker/shared_examples/container.rb:27:in `block in <main>'
  |  
  | Finished in 9 minutes 26 seconds (files took 2.6 seconds to load)

In elastic#17125 jvm setup was redirected to
stderr to avoid polluting stdout. This test was actually having to do some
additional processing to parse that information. Now that we have split the
destinations the tests can be simplified to look for the data they are trying to
validate on the appropriate stream.
@elastic-sonarqube
Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link
Copy Markdown

💚 Build Succeeded

@donoghuc donoghuc requested a review from mashhurs February 21, 2025 18:27
Copy link
Copy Markdown
Contributor

@mashhurs mashhurs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@donoghuc donoghuc merged commit 227c0d8 into elastic:main Feb 21, 2025
@donoghuc
Copy link
Copy Markdown
Member Author

@logstashmachine backport 9.0

@donoghuc
Copy link
Copy Markdown
Member Author

@logstashmachine backport 8.x

github-actions bot pushed a commit that referenced this pull request Feb 21, 2025
In #17125 jvm setup was redirected to
stderr to avoid polluting stdout. This test was actually having to do some
additional processing to parse that information. Now that we have split the
destinations the tests can be simplified to look for the data they are trying to
validate on the appropriate stream.

(cherry picked from commit 227c0d8)
github-actions bot pushed a commit that referenced this pull request Feb 21, 2025
In #17125 jvm setup was redirected to
stderr to avoid polluting stdout. This test was actually having to do some
additional processing to parse that information. Now that we have split the
destinations the tests can be simplified to look for the data they are trying to
validate on the appropriate stream.

(cherry picked from commit 227c0d8)
donoghuc added a commit that referenced this pull request Feb 21, 2025
…#17139)

In #17125 jvm setup was redirected to
stderr to avoid polluting stdout. This test was actually having to do some
additional processing to parse that information. Now that we have split the
destinations the tests can be simplified to look for the data they are trying to
validate on the appropriate stream.

(cherry picked from commit 227c0d8)

Co-authored-by: Cas Donoghue <cas.donoghue@gmail.com>
donoghuc added a commit that referenced this pull request Feb 21, 2025
…#17140)

In #17125 jvm setup was redirected to
stderr to avoid polluting stdout. This test was actually having to do some
additional processing to parse that information. Now that we have split the
destinations the tests can be simplified to look for the data they are trying to
validate on the appropriate stream.

(cherry picked from commit 227c0d8)

Co-authored-by: Cas Donoghue <cas.donoghue@gmail.com>
v1v pushed a commit to v1v/logstash that referenced this pull request Feb 25, 2025
…#17138)

In elastic#17125 jvm setup was redirected to
stderr to avoid polluting stdout. This test was actually having to do some
additional processing to parse that information. Now that we have split the
destinations the tests can be simplified to look for the data they are trying to
validate on the appropriate stream.
v1v added a commit to v1v/logstash that referenced this pull request Feb 25, 2025
…gify

* upstream/main: (27 commits)
  Add Windows 2025 to CI (elastic#17133)
  Update container acceptance tests with stdout/stderr changes (elastic#17138)
  entrypoint: avoid polluting stdout (elastic#17125)
  Fix acceptance test assertions for updated plugin remove (elastic#17126)
  Fix acceptance test assertions for updated plugin `remove` (elastic#17122)
  plugins: improve `remove` command to support multiple plugins (elastic#17030)
  spec: improve ls2ls spec (elastic#17114)
  allow concurrent Batch deserialization (elastic#17050)
  CPM handle 404 response gracefully with user-friendly log (elastic#17052)
  qa: use clean expansion of LS tarball per fixture instance (elastic#17082)
  Allow capturing heap dumps in DRA BK jobs (elastic#17081)
  Use centralized source of truth for active branches (elastic#17063)
  Update logstash_releases.json (elastic#17055)
  fix logstash-keystore to accept spaces in values when added via stdin (elastic#17039)
  Don't honor VERSION_QUALIFIER if set but empty (elastic#17032)
  Release note placeholder might be empty, making parsing lines nil tolerant. (elastic#17026)
  Fix BufferedTokenizer to properly resume after a buffer full condition respecting the encoding of the input string (elastic#16968)
  Add short living 9.0 next and update main in CI release version definition. (elastic#17008)
  Core version bump to 9.1.0 (elastic#16991)
  Add 9.0 branch to the CI branches definition (elastic#16997)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants