inject VERSION_QUALIFIER into artifacts#16904
Merged
jsvd merged 3 commits intoelastic:mainfrom Jan 17, 2025
Merged
Conversation
jsvd
commented
Jan 16, 2025
donoghuc
reviewed
Jan 16, 2025
donoghuc
approved these changes
Jan 16, 2025
Member
donoghuc
left a comment
There was a problem hiding this comment.
In general this looks like the right update. One suggestion is https://github.com/elastic/logstash/pull/16904/files#r1919366815 but take it or leave it!
c17d28c to
480879a
Compare
|
💚 Build Succeeded
History
|
Contributor
Member
Author
|
@logstashmachine backport 8.x |
Member
Author
|
@logstashmachine backport 8.18 |
jsvd
added a commit
to jsvd/logstash
that referenced
this pull request
Feb 11, 2025
VERSION_QUALIFIER was already observed in rake artifacts task but only to influence the name of the artifact. This commit ensure that the qualifier is also displayed in the cli and in the http api.
jsvd
added a commit
that referenced
this pull request
Feb 12, 2025
This was referenced Feb 12, 2025
jsvd
added a commit
that referenced
this pull request
Feb 12, 2025
VERSION_QUALIFIER was already observed in rake artifacts task but only to influence the name of the artifact. This commit ensure that the qualifier is also displayed in the cli and in the http api. (cherry picked from commit 00f8b91) Co-authored-by: João Duarte <jsvd@users.noreply.github.com>
jsvd
added a commit
that referenced
this pull request
Feb 12, 2025
VERSION_QUALIFIER was already observed in rake artifacts task but only to influence the name of the artifact. This commit ensure that the qualifier is also displayed in the cli and in the http api. (cherry picked from commit 00f8b91) Co-authored-by: João Duarte <jsvd@users.noreply.github.com>
jsvd
added a commit
that referenced
this pull request
Feb 12, 2025
VERSION_QUALIFIER was already observed in rake artifacts task but only to influence the name of the artifact. This commit ensure that the qualifier is also displayed in the cli and in the http api. (cherry picked from commit 00f8b91) Co-authored-by: João Duarte <jsvd@users.noreply.github.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #16898
Exhaustive test suite run: https://buildkite.com/elastic/logstash-exhaustive-tests-pipeline/builds/1131