Upgrade EUI to v33.0.0 by thompsongl · Pull Request #99382 · elastic/kibana

thompsongl · 2021-05-05T17:18:25Z

Summary

eui@32.1.0 ⏩ eui@33.0.0

EuiCodeBlock: Replaced highlight.js with prism.js
- Content must be passed as a string
- Some language name changes (e.g., sh is not a supported alias for bash/shell)
- kbnUiSharedDeps-elastic | 3.3MB | 2.6MB | -761.6KB
EuiTable*: description and a11y updates
- Sort information is not included in screen reader title content (relies on aria-sort instead)
- title instead includes description content
EuiPopover: fixed initialFocus prop
- Fix will be backported in EUI and 7.13.x

`33.0.0`

Added autoFocus prop and functionality to EuiComboBox (#4772)
Added inherit color option to EuiIcon to force two-tone (app) icons to inherit their parent's color (#4760)
Updated EuiBetaBadge, EuiBadge, EuiButtonIcon, EuiButtonContent, EuiCallOut, EuiContextMenuItem, EuiListGroupItem icon usage to inherit their parent's color (#4760)
Added iconProps prop to EuiListGroupItem (#4760)
Added i18ntokens.json to published package (#4771)
Replaced highlight.js with prism.js/refractor for code syntax highlighting in EuiCodeBlock (#4638)

Bug fixes

Fixed initialFocus prop functionality in EuiPopover (#4768)
Fixed description prop in EuiTable(#4754)

Breaking changes

Changed some language syntax references in EuiCodeBlock, such as jsx (#4638)
Removed ability to parse non-string content in EuiCodeBlock (#4638)

`32.3.0`

Reduced icon size in EuiButtonEmpty of size xs. (#4759)

Bug fixes

Fixed missing i18n tokens for EuiFilePicker (#4750)
Fixed EuiComboBox to use correct placeholder text color (#4744)

`32.2.0`

Removed MutationObserver fallback from EuiResizeObserver (#4709)

Bug fixes

Fixed EuiInMemoryTable pagination prop to update visible items when changed (#4714)
Fixed a bug in EuiFilePicker where the HTML input was being shown when disabled (#4738)
Fixed inverted asc and desc labels for EuiDataGrid datetime schema (#4733)

This reverts commit adc3538.

elasticmachine · 2021-05-26T16:38:08Z

Pinging @elastic/uptime (Team:uptime)

elasticmachine · 2021-05-26T16:38:08Z

Pinging @elastic/apm-ui (Team:apm)

mshustov · 2021-05-26T16:39:05Z

packages/kbn-telemetry-tools/BUILD.bazel

  "@npm//@types/node",
  "@npm//@types/normalize-path",
  "@npm//@types/testing-library__jest-dom",
+  "@npm//resize-observer-polyfill"


This is a server-side package. It shouldn't depend on resize-observer-polyfill.

cjcenizal

ES UI test snapshot changes LGTM.

justinkambic

Uptime changes LGTM.

igoristic

LGTM in Stack Monitoring

mshustov

Ok for the changes in Core code, providing we enforce env separation in the future #99382 (comment)

cnasikas

Security solution changes LGTM!

smith

APM changes look good

qn895 · 2021-05-27T17:04:57Z

ML changes LGTM

poffdeluxe

Presentation changes LGTM

kertal

LGTM, Code owner review, checked out, timestamp sorting in data grid is now correct, merci beaucoup! 👍

thompsongl · 2021-06-01T13:54:33Z

@elasticmachine merge upstream

kibanamachine · 2021-06-01T15:44:27Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`apm`	1601	1604	+3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`apm`	4.3MB	4.3MB	+12.7KB
`home`	165.0KB	165.0KB	+2.0B
`ml`	5.9MB	5.9MB	+45.0B
`securitySolution`	6.9MB	6.9MB	+112.0B
`visTypeTimeseries`	1.7MB	1.7MB	+80.0B
`visTypeVega`	2.4MB	2.4MB	+4.0B
total			+12.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`kbnUiSharedDeps-css`	501.7KB	503.3KB	+1.6KB
`kbnUiSharedDeps-elastic`	3.3MB	2.6MB	-761.6KB
`kbnUiSharedDeps-js`	6.8MB	6.5MB	-337.7KB
total			-1.1MB

Unknown metric groups

References to deprecated APIs

id	before	after	diff
`canvas`	29	25	-4
`crossClusterReplication`	8	6	-2
`fleet`	22	20	-2
`globalSearch`	4	2	-2
`indexManagement`	12	7	-5
`infra`	256	146	-110
`lens`	67	45	-22
`licensing`	18	15	-3
`lists`	239	236	-3
`maps`	286	208	-78
`ml`	121	115	-6
`monitoring`	109	56	-53
`securitySolution`	390	346	-44
`stackAlerts`	101	95	-6
total			-340

History

💚 Build #127930 succeeded e145ae9
💚 Build #127725 succeeded 894a022
💚 Build #127412 succeeded ff527bb
💚 Build #127404 succeeded 3eb5f21
💔 Build #126843 failed 7ae359f

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

igoristic

Stack Monitoring looks good 👍

* eui to 33.0.0 * resize observer type inclusion - revisit * src snapshot updates * x-pack snapshot updates * table sort test updates * code block language sh -> bash * datagrid datetime sort inversion * types * kbn-crypto * refractor yarn resolution * refractor yarn resolution * update cypress tests * url state test * trial * Revert "trial" This reverts commit adc3538. * trial anomaly timeout * Revert "trial anomaly timeout" This reverts commit 9a11711. * kbn-telemetry-tools * Change a useMemo to useCallback so the code executes when intended * Removed no-longer-used import * exitOrFail already retries for longer than tryForTime * Wait for loading indicator to disappear * Intentionally adding `.only` * Revert .only * Increase wait time for the ML chart to load * Remove unused var * overflow * chartWidth Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Alejandro Fernández Haro <alejandro.haro@elastic.co> Co-authored-by: Chandler Prall <chandler.prall@gmail.com>

* eui to 33.0.0 * resize observer type inclusion - revisit * src snapshot updates * x-pack snapshot updates * table sort test updates * code block language sh -> bash * datagrid datetime sort inversion * types * kbn-crypto * refractor yarn resolution * refractor yarn resolution * update cypress tests * url state test * trial * Revert "trial" This reverts commit adc3538. * trial anomaly timeout * Revert "trial anomaly timeout" This reverts commit 9a11711. * kbn-telemetry-tools * Change a useMemo to useCallback so the code executes when intended * Removed no-longer-used import * exitOrFail already retries for longer than tryForTime * Wait for loading indicator to disappear * Intentionally adding `.only` * Revert .only * Increase wait time for the ML chart to load * Remove unused var * overflow * chartWidth Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Alejandro Fernández Haro <alejandro.haro@elastic.co> Co-authored-by: Chandler Prall <chandler.prall@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Alejandro Fernández Haro <alejandro.haro@elastic.co> Co-authored-by: Chandler Prall <chandler.prall@gmail.com>

thompsongl added 6 commits May 5, 2021 09:32

eui to 33.0.0

063b0dc

resize observer type inclusion - revisit

7865c2c

src snapshot updates

0a67885

x-pack snapshot updates

ece02e4

table sort test updates

1570e0e

code block language sh -> bash

738bfe8

thompsongl added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes EUI v7.14.0 labels May 5, 2021

thompsongl added 5 commits May 5, 2021 13:29

Merge branch 'master' into eui/33.0

c319815

datagrid datetime sort inversion

e254d09

types

e27f5ab

kbn-crypto

a2791b8

Merge branch 'master' into eui/33.0

f4aa961

afharo mentioned this pull request May 6, 2021

EUI labels not translating #74657

Closed

thompsongl added 5 commits May 6, 2021 11:45

refractor yarn resolution

8a6b280

refractor yarn resolution

ed27ab5

Merge branch 'master' into eui/33.0

8522942

update cypress tests

74d0c2c

Merge branch 'master' into eui/33.0

6847767

afharo mentioned this pull request May 10, 2021

[i18n] Add tests to @elastic/eui tokens #99613

Closed

2 tasks

thompsongl added 7 commits May 11, 2021 09:32

url state test

2ddfafa

trial

adc3538

Merge branch 'master' into eui/33.0

30ade23

Merge branch 'master' into eui/33.0

9698262

Revert "trial"

6c7a985

This reverts commit adc3538.

trial anomaly timeout

9a11711

Merge branch 'master' into eui/33.0

3c3d305

qn895 mentioned this pull request May 12, 2021

[ML] Stabilize anomaly chart embeddable tests #99955

Merged

1 task

botelastic bot added Team:APM - DEPRECATED Use Team:obs-ux-infra_services. Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels May 26, 2021

mshustov reviewed May 26, 2021

View reviewed changes

cjcenizal approved these changes May 26, 2021

View reviewed changes

justinkambic approved these changes May 26, 2021

View reviewed changes

igoristic approved these changes May 26, 2021

View reviewed changes

mshustov approved these changes May 27, 2021

View reviewed changes

cnasikas approved these changes May 27, 2021

View reviewed changes

justinkambic mentioned this pull request May 27, 2021

[Uptime] Refactor snapshot tests to RTL #100771

Closed

smith approved these changes May 27, 2021

View reviewed changes

qn895 approved these changes May 27, 2021

View reviewed changes

thompsongl added 2 commits May 27, 2021 12:07

Merge branch 'master' into eui/33.0

894a022

Merge branch 'master' into eui/33.0

e145ae9

mattkime approved these changes May 28, 2021

View reviewed changes

poffdeluxe approved these changes May 28, 2021

View reviewed changes

kertal approved these changes May 28, 2021

View reviewed changes

Merge branch 'master' into eui/33.0

b9b06d6

kibanamachine requested a review from a team June 1, 2021 13:54

igoristic approved these changes Jun 1, 2021

View reviewed changes

thompsongl merged commit 38fd8a2 into elastic:master Jun 1, 2021

thompsongl mentioned this pull request Jun 1, 2021

[7.x] Upgrade EUI to v33.0.0 (#99382) #101067

Merged

thompsongl mentioned this pull request Jun 1, 2021

Enable CSS-in-JS styling with emotion #98157

Merged

3 tasks

qn895 mentioned this pull request Jun 4, 2021

[ML] Fix missing overflowY in Anomaly charts embeddable #101404

Merged

Conversation

thompsongl commented May 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

33.0.0

32.3.0

32.2.0

Uh oh!

elasticmachine commented May 26, 2021

Uh oh!

elasticmachine commented May 26, 2021

Uh oh!

mshustov May 26, 2021

Choose a reason for hiding this comment

Uh oh!

cjcenizal left a comment

Choose a reason for hiding this comment

Uh oh!

justinkambic left a comment

Choose a reason for hiding this comment

Uh oh!

igoristic left a comment

Choose a reason for hiding this comment

Uh oh!

mshustov left a comment

Choose a reason for hiding this comment

Uh oh!

cnasikas left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

smith left a comment

Choose a reason for hiding this comment

Uh oh!

qn895 commented May 27, 2021

Uh oh!

poffdeluxe left a comment

Choose a reason for hiding this comment

Uh oh!

kertal left a comment

Choose a reason for hiding this comment

Uh oh!

thompsongl commented Jun 1, 2021

Uh oh!

kibanamachine commented Jun 1, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Page load bundle

References to deprecated APIs

History

Uh oh!

igoristic left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

16 participants

thompsongl commented May 5, 2021 •

edited

Loading

`33.0.0`

`32.3.0`

`32.2.0`

cnasikas left a comment •

edited

Loading