[EuiResizeObserver] Remove compatibility fallback#4709
[EuiResizeObserver] Remove compatibility fallback#4709thompsongl merged 6 commits intoelastic:masterfrom
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4709/ |
chandlerprall
left a comment
There was a problem hiding this comment.
Changes LGTM; I'm not sure the @types/resize-observer-browser will get picked up automatically by downstream projects / not cause some other issue in Kibana, would you mind doing a quick pass there to verify?
Good call. I questioned whether to use the lib at all. I'll test it but might just bring the types we need inline. |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4709/ |
|
Types do get picked up in downstream projects. Tested in CRA and Kibana. |
chandlerprall
left a comment
There was a problem hiding this comment.
Thanks for double checking the impact! Changes LGTM
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4709/ |
Summary
Part of #4402. Removes
makeCompatibleObserverfallback originally written for a time when EUI's supported browsers did not all implement the ResizeObserver API.Note that the tests have been skipped:
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Props have proper autodocs and playground toggles- [ ] Checked for accessibility including keyboard-only and screenreader modes