Skip to content

[EuiFilePicker] Added i18n for Remove text#4750

Merged
myasonik merged 2 commits intoelastic:masterfrom
Lemaro86:patch-1
Apr 23, 2021
Merged

[EuiFilePicker] Added i18n for Remove text#4750
myasonik merged 2 commits intoelastic:masterfrom
Lemaro86:patch-1

Conversation

@Lemaro86
Copy link
Copy Markdown
Contributor

@Lemaro86 Lemaro86 commented Apr 23, 2021

Summary

Provide a detailed summary of your PR. Explain how you arrived at your solution. If it includes changes to UI elements include a screenshot or gif.

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs and playground toggles
  • Added documentation
  • Checked Code Sandbox works for the any docs examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link
Copy Markdown

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link
Copy Markdown

cla-checker-service bot commented Apr 23, 2021

💚 CLA has been signed

@myasonik
Copy link
Copy Markdown
Contributor

Hi @Lemaro86 – thank you for fixing this bug!

Could you please sign the Contributor Agreement so we can review your PR?

@Lemaro86
Copy link
Copy Markdown
Contributor Author

Hi @Lemaro86 – thank you for fixing this bug!

Could you please sign the Contributor Agreement so we can review your PR?

I did it, but your CLA I think don't send callback)

@myasonik
Copy link
Copy Markdown
Contributor

jenkins test this

@kibanamachine
Copy link
Copy Markdown

Preview documentation changes for this PR: https://eui.elastic.co/pr_4750/

@myasonik myasonik changed the title Added euiI18 for Remove text [EuiFilePicker] Added i18n for Remove text Apr 23, 2021
@myasonik myasonik merged commit e6fd955 into elastic:master Apr 23, 2021
cchaos pushed a commit that referenced this pull request May 4, 2021
Co-authored-by: Michail Yasonik <michail.yasonik@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants