Fixed EuiInMemoryTable content render on changing pagination#4714
Fixed EuiInMemoryTable content render on changing pagination#4714thompsongl merged 4 commits intoelastic:masterfrom
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
@chandlerprall @cchaos Could you please review! |
|
Thanks for the PR, @hetanthakkar1! |
|
@thompsongl Sure! Thank you |
|
@cchaos @chandlerprall @thompsongl Could you please review! |
|
jenkins test this |
thompsongl
left a comment
There was a problem hiding this comment.
Code changes LGTM; thanks, @hetanthakkar1
Just some changelog clean up.
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4714/ |
|
@thompsongl I have made the necessary changes. Could you please review! |
|
@thompsongl I was just curious and wondering that you maintainers after reviewing our PR usually test them by writing Jenkin, Test this. But if we contributors are also given the freedom to do that I think the process can speed up and save time as we will be executing that command after pushing the code and you won't have to write that !? Obviously, you guys would have thought about this but I just wanted to know why it can't happen that way |
|
Hi @hetanthakkar1 We understand it's a slow manual process for reviewing community PR's and we appreciate your patience with us as we juggle maintenance of the repo alongside our other Elastic duties. The CI builds, and triggering them, are completely permissions based and managed by our internal infrastructure team. Since community members don't have access to the builds, they also can't trigger them. Sorry, but it's not part of our control on that side. |
|
@cchaos I get it. I didn't know these CI builds are something that is very permission-based and important. I thought CI build is like test commands! I really appreciate your reviews and have learnt a lot while contributing. Thank you! |
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4714/ |
Summary
Fixed issue #3231 Disabling pagination will render the whole content in the table and enabling it will again allow pagination in the table
Checklist
Props have proper autodocs and **[playground toggles](https://github.com/elastic/eui/blob/master/wiki/documentation-guidelines.md#adding-playground-toggles)**~Added documentationAdded or updated jest testsChecked for accessibility including keyboard-only and screenreader modes