[Security Solution] Fixes Exit full screen and Copy to clipboard styling issues#96676
Merged
andrew-goldstein merged 5 commits intoelastic:masterfrom Apr 13, 2021
Merged
Conversation
…` styling issues Note: This PR is `release_note:skip` because the styling issues below do not effect any previous release. - Fixes an issue elastic#96209 where the `Exit full screen` button in Timeline's `Pinned` tab is rendered adjacent to, instead of above, the table: ### Before: Exit Full Screen (`Pinned` tab)  _Before: The `Exit full screen` button on Timeline's `Pinned` tab_ ### After: Exit Full Screen (`Pinned` tab)  _After: The `Exit full screen` button on Timeline's `Pinned` tab_ - Fixes an issue where the `Copy to clipboard` hover menu action was not aligned with the other hover menu actions: ### Before: Copy to clipboard hover action  _Before: The `Copy to clipboard` hover action was not aligned_ ### After: Copy to clipboard hover action  _After: The `Copy to clipboard` hover action is aligned_ ### Desk Testing Desk tested in: - Chrome `89.0.4389.114` - Firefox `87.0` - Safari `14.0.3`
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Contributor
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
Contributor
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
XavierM
approved these changes
Apr 13, 2021
Contributor
XavierM
left a comment
There was a problem hiding this comment.
Tested locally on chrome, safari, firefox
andrew-goldstein
added a commit
to andrew-goldstein/kibana
that referenced
this pull request
Apr 13, 2021
…` styling issues (elastic#96676) ## [Security Solution] Fixes `Exit full screen` and `Copy to clipboard` styling issues Note: This PR is `release_note:skip` because the styling issues below do not effect any previous release. - Fixes issue elastic#96209 where the `Exit full screen` button in Timeline's `Pinned` tab is rendered adjacent to, instead of above, the table: ### Before: Exit Full Screen (`Pinned` tab)  _Before: The `Exit full screen` button on Timeline's `Pinned` tab_ ### After: Exit Full Screen (`Pinned` tab)  _After: The `Exit full screen` button on Timeline's `Pinned` tab_ - Fixes an issue where the `Copy to clipboard` hover menu action was not aligned with the other hover menu actions: ### Before: Copy to clipboard hover action  _Before: The `Copy to clipboard` hover action was not aligned_ ### After: Copy to clipboard hover action  _After: The `Copy to clipboard` hover action is aligned_ ### Desk Testing Desk tested in: - Chrome `89.0.4389.114` - Firefox `87.0` - Safari `14.0.3`
andrew-goldstein
added a commit
that referenced
this pull request
Apr 13, 2021
…` styling issues (#96676) (#97047) ## [Security Solution] Fixes `Exit full screen` and `Copy to clipboard` styling issues Note: This PR is `release_note:skip` because the styling issues below do not effect any previous release. - Fixes issue #96209 where the `Exit full screen` button in Timeline's `Pinned` tab is rendered adjacent to, instead of above, the table: ### Before: Exit Full Screen (`Pinned` tab)  _Before: The `Exit full screen` button on Timeline's `Pinned` tab_ ### After: Exit Full Screen (`Pinned` tab)  _After: The `Exit full screen` button on Timeline's `Pinned` tab_ - Fixes an issue where the `Copy to clipboard` hover menu action was not aligned with the other hover menu actions: ### Before: Copy to clipboard hover action  _Before: The `Copy to clipboard` hover action was not aligned_ ### After: Copy to clipboard hover action  _After: The `Copy to clipboard` hover action is aligned_ ### Desk Testing Desk tested in: - Chrome `89.0.4389.114` - Firefox `87.0` - Safari `14.0.3`
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Apr 14, 2021
…ax_primary_shard_size * 'master' of github.com:elastic/kibana: (99 commits) added missing optional chain for bracket notation (elastic#96939) [Discover][DocViewer] Fix toggle columns from doc viewer table tab (elastic#95748) [TSVB] Fix per-request caching of index patterns (elastic#97043) [Datatable] Fix filter cell flakiness (elastic#96934) Unskip heatmap suite and fixes flakiness (elastic#96941) [Fleet] Improve performance of data stream API (elastic#97058) [ML] Data Frame Analytics: remove beta badge (elastic#96977) [App Search] Migrate expanded rows for meta engines table in Engines Overview (elastic#96251) Instances latency distribution chart tooltips and axis fixes (elastic#95577) [Monitoring] Using primary average shard size (elastic#96177) [Workplace Search] Hide Kibana chrome on 3rd party connector redirects (elastic#97028) ## [Security Solution] Fixes `Exit full screen` and `Copy to cliboard` styling issues (elastic#96676) Index pattern field editor - Add warning on name or type change (elastic#95528) [App Search] Add small engine breadcrumb utility helper (elastic#96917) Copy esArchiver commands from ./reassign.ts to fix tests (elastic#97012) [Security Solution][Detections] Updates MITRE Tactics, Techniques, and Subtechniques for 7.13 (elastic#97011) Index patterns server - throw correct error on field caps 404 (elastic#95879) Use `EuiThemeProvider` in lists plugin tests and stories (elastic#96129) [npm] upgrade caniuse database (elastic#97002) chore(NA): moving @kbn/apm-utils into bazel (elastic#96227) ... # Conflicts: # x-pack/plugins/index_lifecycle_management/__jest__/client_integration/edit_policy/serialization/policy_serialization.test.ts # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/form/schema.ts
phillipb
added a commit
to phillipb/kibana
that referenced
this pull request
Apr 14, 2021
…to-metrics-tab * 'master' of github.com:elastic/kibana: (61 commits) [Usage collection] Usage counters (elastic#96696) UI actions readme (elastic#96925) [TSVB] Enable brush for visualizations created with no index patterns (elastic#96727) [Data telemetry] Add Async Search to the tests (elastic#96693) added missing optional chain for bracket notation (elastic#96939) [Discover][DocViewer] Fix toggle columns from doc viewer table tab (elastic#95748) [TSVB] Fix per-request caching of index patterns (elastic#97043) [Datatable] Fix filter cell flakiness (elastic#96934) Unskip heatmap suite and fixes flakiness (elastic#96941) [Fleet] Improve performance of data stream API (elastic#97058) [ML] Data Frame Analytics: remove beta badge (elastic#96977) [App Search] Migrate expanded rows for meta engines table in Engines Overview (elastic#96251) Instances latency distribution chart tooltips and axis fixes (elastic#95577) [Monitoring] Using primary average shard size (elastic#96177) [Workplace Search] Hide Kibana chrome on 3rd party connector redirects (elastic#97028) ## [Security Solution] Fixes `Exit full screen` and `Copy to cliboard` styling issues (elastic#96676) Index pattern field editor - Add warning on name or type change (elastic#95528) [App Search] Add small engine breadcrumb utility helper (elastic#96917) Copy esArchiver commands from ./reassign.ts to fix tests (elastic#97012) [Security Solution][Detections] Updates MITRE Tactics, Techniques, and Subtechniques for 7.13 (elastic#97011) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Security Solution] Fixes
Exit full screenandCopy to clipboardstyling issuesNote: This PR is
release_note:skipbecause the styling issues below do not effect any previous release.Exit full screenbutton in Timeline'sPinnedtab is rendered adjacent to, instead of above, the table:Before: Exit Full Screen (
Pinnedtab)Before: The
Exit full screenbutton on Timeline'sPinnedtabAfter: Exit Full Screen (
Pinnedtab)After: The
Exit full screenbutton on Timeline'sPinnedtabCopy to clipboardhover menu action was not aligned with the other hover menu actions:Before: Copy to clipboard hover action
Before: The
Copy to clipboardhover action was not alignedAfter: Copy to clipboard hover action
After: The
Copy to clipboardhover action is alignedDesk Testing
Desk tested in:
89.0.4389.11487.014.0.3