chore(NA): moving @kbn/apm-utils into bazel by mistic · Pull Request #96227 · elastic/kibana

mistic · 2021-04-05T16:18:25Z

One step forward on #69706

That PR moves the @kbn/apm-utils into Bazel by pushing a BUILD file for that package.
After merging this the package will be consumed from within bazel-bin folder.

elasticmachine · 2021-04-05T16:18:27Z

Pinging @elastic/kibana-operations (Team:Operations)

spalger · 2021-04-05T16:53:57Z

Do we have docs on how to work with packages that are built using Bazel yet? Now that we're converting packages I think it's a good time to at least outline how we build and watch for changes in packages, and how to identify which packages have been migrated in the "Getting started" section of the docs.

packages/elastic-datemath/BUILD.bazel

tylersmalley · 2021-04-05T17:52:46Z

Do we have docs on how to work with packages that are built using Bazel yet? Now that we're converting packages I think it's a good time to at least outline how we build and watch for changes in packages, and how to identify which packages have been migrated in the "Getting started" section of the docs.

@mistic, it would be good to run both the legacy build/watch and that of Bazel under the existing kbn build and kbn watch commands. If that is too complex, I would be fine with adding another command. Since most packages are still in lagacy, maybe we add a kbn build-bazel and kbn watch-bazel command. We can either rename them when most are migrated to essentially change the default, or we can drop legacy entirely when all have been migrated. I am hopeful this phase where both exist for packages won't be very long, where I see that being much longer for plugins. If we do this split approach, the default build and watch command should provide notice about the possible need to run the other build and additionally updating the docs to reflect both of these.

cc: @spalger

spalger · 2021-04-05T18:35:15Z

it would be good to run both the legacy build/watch and that of Bazel under the existing kbn build and kbn watch commands.

If we can detect the BUILD.bazel file and automatically run the right bazel commands from kbn/pm for either the build or watch step that would be amazing. It breaks the existing "cd into the package and run yarn build" expectation but I think we can log the commands we're running when yarn kbn watch -i @kbn/apm-utils is executing and educate users that way, along with a quick doc we can link to about the right commands to run.

mistic · 2021-04-06T01:54:36Z

@spalger @tylersmalley would you both be okay with just adding 2 new commands for now (yarn kbn build-bazel and yarn kbn watch-bazel) to deal with the bazel built packages and improve and standardise those in the kbn watch and kbn build (with support for -i) once we have none legacy built packages?

spalger · 2021-04-06T01:55:28Z

If we're implementing the commands why not call them automatically if the package has a BUILD.bazel file? Seems that's the only job that users would have to do and it would be trivial for kbn/pm to just do it for us.

…s-into-bazel

mistic · 2021-04-12T11:52:58Z

@elasticmachine merge upstream

…s-into-bazel

…ng started

kibanamachine · 2021-04-13T03:16:42Z

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

💚 Build #118923 succeeded 2e47c3e
💚 Build #118672 succeeded 4ce4565
💚 Build #118367 succeeded afcc653
💚 Build #118248 succeeded 9e9dc96
💚 Build #117294 succeeded c4a5c60

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

jbudz

LGTM. I'm assuming the discussion above was moved to #96465, I've tested that separately.

* chore(NA): moving @kbn/apm-utils into bazel * chore(NA): add kbn/apm-utils into package.json * chore(NA): missing standard on build file globs * chore(NA): be more explicit about incremental setting * chore(NA): include pretty in the args for ts_project rule * docs(NA): include package migration completion in the developer getting started Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

kibanamachine · 2021-04-13T18:17:06Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

* chore(NA): moving @kbn/apm-utils into bazel * chore(NA): add kbn/apm-utils into package.json * chore(NA): missing standard on build file globs * chore(NA): be more explicit about incremental setting * chore(NA): include pretty in the args for ts_project rule * docs(NA): include package migration completion in the developer getting started Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Tiago Costa <tiagoffcc@hotmail.com>

…ax_primary_shard_size * 'master' of github.com:elastic/kibana: (99 commits) added missing optional chain for bracket notation (elastic#96939) [Discover][DocViewer] Fix toggle columns from doc viewer table tab (elastic#95748) [TSVB] Fix per-request caching of index patterns (elastic#97043) [Datatable] Fix filter cell flakiness (elastic#96934) Unskip heatmap suite and fixes flakiness (elastic#96941) [Fleet] Improve performance of data stream API (elastic#97058) [ML] Data Frame Analytics: remove beta badge (elastic#96977) [App Search] Migrate expanded rows for meta engines table in Engines Overview (elastic#96251) Instances latency distribution chart tooltips and axis fixes (elastic#95577) [Monitoring] Using primary average shard size (elastic#96177) [Workplace Search] Hide Kibana chrome on 3rd party connector redirects (elastic#97028) ## [Security Solution] Fixes `Exit full screen` and `Copy to cliboard` styling issues (elastic#96676) Index pattern field editor - Add warning on name or type change (elastic#95528) [App Search] Add small engine breadcrumb utility helper (elastic#96917) Copy esArchiver commands from ./reassign.ts to fix tests (elastic#97012) [Security Solution][Detections] Updates MITRE Tactics, Techniques, and Subtechniques for 7.13 (elastic#97011) Index patterns server - throw correct error on field caps 404 (elastic#95879) Use `EuiThemeProvider` in lists plugin tests and stories (elastic#96129) [npm] upgrade caniuse database (elastic#97002) chore(NA): moving @kbn/apm-utils into bazel (elastic#96227) ... # Conflicts: # x-pack/plugins/index_lifecycle_management/__jest__/client_integration/edit_policy/serialization/policy_serialization.test.ts # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/form/schema.ts

chore(NA): moving @kbn/apm-utils into bazel

dc65b79

mistic added chore Team:Operations Kibana-Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.13.0 labels Apr 5, 2021

mistic mentioned this pull request Apr 5, 2021

Use Bazel for Kibana builds #69706

Closed

23 tasks

chore(NA): add kbn/apm-utils into package.json

20cd771

chore(NA): missing standard on build file globs

c4a5c60

mistic requested a review from a team as a code owner April 5, 2021 17:02

mistic commented Apr 5, 2021

View reviewed changes

packages/elastic-datemath/BUILD.bazel Show resolved Hide resolved

mistic mentioned this pull request Apr 7, 2021

chore(NA): @kbn/pm new commands to support development on Bazel packages #96465

Merged

Merge remote-tracking branch 'upstream/master' into move-kbn-apm-util…

9e9dc96

…s-into-bazel

mistic added the auto-backport Deprecated - use backport:version if exact versions are needed label Apr 8, 2021

chore(NA): be more explicit about incremental setting

afcc653

kibanamachine and others added 2 commits April 12, 2021 07:53

Merge branch 'master' into move-kbn-apm-utils-into-bazel

4ce4565

chore(NA): include pretty in the args for ts_project rule

2e47c3e

streamich approved these changes Apr 12, 2021

View reviewed changes

mistic added 2 commits April 13, 2021 02:12

Merge remote-tracking branch 'upstream/master' into move-kbn-apm-util…

cf826d2

…s-into-bazel

docs(NA): include package migration completion in the developer getti…

a1c23e1

…ng started

jbudz approved these changes Apr 13, 2021

View reviewed changes

mistic merged commit 47065ac into elastic:master Apr 13, 2021

kibanamachine mentioned this pull request Apr 13, 2021

[7.x] chore(NA): moving @kbn/apm-utils into bazel (#96227) #97024

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(NA): moving @kbn/apm-utils into bazel#96227

chore(NA): moving @kbn/apm-utils into bazel#96227
mistic merged 9 commits intoelastic:masterfrom
mistic:move-kbn-apm-utils-into-bazel

mistic commented Apr 5, 2021

Uh oh!

elasticmachine commented Apr 5, 2021

Uh oh!

spalger commented Apr 5, 2021

Uh oh!

Uh oh!

tylersmalley commented Apr 5, 2021

Uh oh!

spalger commented Apr 5, 2021 •

edited

Loading

Uh oh!

mistic commented Apr 6, 2021

Uh oh!

spalger commented Apr 6, 2021 •

edited

Loading

Uh oh!

mistic commented Apr 12, 2021

Uh oh!

kibanamachine commented Apr 13, 2021

Uh oh!

jbudz left a comment

Uh oh!

kibanamachine commented Apr 13, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

mistic commented Apr 5, 2021

Uh oh!

elasticmachine commented Apr 5, 2021

Uh oh!

spalger commented Apr 5, 2021

Uh oh!

Uh oh!

tylersmalley commented Apr 5, 2021

Uh oh!

spalger commented Apr 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mistic commented Apr 6, 2021

Uh oh!

spalger commented Apr 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mistic commented Apr 12, 2021

Uh oh!

kibanamachine commented Apr 13, 2021

💚 Build Succeeded

Metrics [docs]

History

Uh oh!

jbudz left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Apr 13, 2021

💚 Backport successful

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

spalger commented Apr 5, 2021 •

edited

Loading

spalger commented Apr 6, 2021 •

edited

Loading