Index patterns server - throw correct error on field caps 404 by mattkime · Pull Request #95879 · elastic/kibana

mattkime · 2021-03-30T23:16:56Z

Summary

Previously the server side field caps api call was throwing a generic error and was therefore not caught as expected. This PR fixes this and tests that relied on this incorrect error.

Also simplifies a small amount of map related index pattern code. Previously the field list was being loaded manually which wasn't necessary.

Note: better fixes could be made to the tests but the scripted field code is being deprecated anyway. The tests started failing because the API was correctly reporting errors on index patterns without backing indices.

Closes: #92947

elasticmachine · 2021-04-13T12:39:24Z

Pinging @elastic/kibana-app-services (Team:AppServices)

kindsun · 2021-04-13T15:56:28Z

First pass looks good overall. Maps telemetry works as expected without ugly log messages. Need to do a deeper dive, but any idea why the error message is coming through undefined in the log?

server    log   [09:46:42.145] [warning][data][data][indexPatterns][plugins] No matching indices found: kibana_sample_data_logs : undefined

To replicate:

Load sample data
Delete any index but retain the index pattern associated with it
Load this endpoint to trigger the telemetry warning: http://localhost:5601/api/stats?extended=true

mattkime · 2021-04-13T16:58:16Z

@aaronjcaldwell I resolved the : undefined issue.

elasticmachine · 2021-04-13T17:02:39Z

Pinging @elastic/kibana-gis (Team:Geo)

tsullivan · 2021-04-13T17:07:14Z

src/plugins/data/server/index_patterns/index_patterns_api_client.ts

+        ) {
+          throw new IndexPatternMissingIndices(pattern);
+        } else {
+          throw err;


When this is thrown, does the error get caught and logged to the server logs somewhere?

Or should there be a logger.error(err) before the throw?

It gets caught and logged to the server logs - https://github.com/elastic/kibana/pull/95879/files#diff-a4e9a6425b24a341a47560c879ec9eb04e76748d29376a9c1390962d1da65c10R74 - its defined in the server abstraction layer.

kibanamachine · 2021-04-13T18:58:42Z

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

💚 Build #119085 succeeded 81bed9a
💔 Build #116386 failed 455fa8d

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kindsun

Thanks for simplifying the code on the Maps side and fixing the error handling on the data side. lgtm!

tested locally in chrome
code review, primarily Maps

kindsun · 2021-04-13T19:09:35Z

@mattkime Is there any possibility these changes could be backported to 7.12.x?

tsullivan

LGTM

…c#95879) * throw correct error on field caps 404 and update tests

kibanamachine · 2021-04-13T19:17:15Z

💔 Backport failed

Status	Branch	Result
❌	7.12	Commit could not be cherrypicked due to conflicts
✅	7.x

Successful backport PRs will be merged automatically after passing CI.

To backport manually run:
node scripts/backport --pr 95879

…c#95879) * throw correct error on field caps 404 and update tests # Conflicts: # src/plugins/data/server/index_patterns/index_patterns_service.ts

#97034) * throw correct error on field caps 404 and update tests # Conflicts: # src/plugins/data/server/index_patterns/index_patterns_service.ts

#97033) * throw correct error on field caps 404 and update tests Co-authored-by: Matthew Kime <matt@mattki.me>

…ax_primary_shard_size * 'master' of github.com:elastic/kibana: (99 commits) added missing optional chain for bracket notation (elastic#96939) [Discover][DocViewer] Fix toggle columns from doc viewer table tab (elastic#95748) [TSVB] Fix per-request caching of index patterns (elastic#97043) [Datatable] Fix filter cell flakiness (elastic#96934) Unskip heatmap suite and fixes flakiness (elastic#96941) [Fleet] Improve performance of data stream API (elastic#97058) [ML] Data Frame Analytics: remove beta badge (elastic#96977) [App Search] Migrate expanded rows for meta engines table in Engines Overview (elastic#96251) Instances latency distribution chart tooltips and axis fixes (elastic#95577) [Monitoring] Using primary average shard size (elastic#96177) [Workplace Search] Hide Kibana chrome on 3rd party connector redirects (elastic#97028) ## [Security Solution] Fixes `Exit full screen` and `Copy to cliboard` styling issues (elastic#96676) Index pattern field editor - Add warning on name or type change (elastic#95528) [App Search] Add small engine breadcrumb utility helper (elastic#96917) Copy esArchiver commands from ./reassign.ts to fix tests (elastic#97012) [Security Solution][Detections] Updates MITRE Tactics, Techniques, and Subtechniques for 7.13 (elastic#97011) Index patterns server - throw correct error on field caps 404 (elastic#95879) Use `EuiThemeProvider` in lists plugin tests and stories (elastic#96129) [npm] upgrade caniuse database (elastic#97002) chore(NA): moving @kbn/apm-utils into bazel (elastic#96227) ... # Conflicts: # x-pack/plugins/index_lifecycle_management/__jest__/client_integration/edit_policy/serialization/policy_serialization.test.ts # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/form/schema.ts

throw correct error on field caps 404

455fa8d

mattkime changed the title ~~throw correct error on field caps 404~~ Index patterns server - throw correct error on field caps 404 Mar 31, 2021

mattkime added 4 commits April 12, 2021 09:45

Merge branch 'master' into throw_correct_error_field_caps_404

2a4f53f

Merge branch 'master' into throw_correct_error_field_caps_404

ee9e312

update tests

498b27b

Merge branch 'master' into throw_correct_error_field_caps_404

81bed9a

mattkime marked this pull request as ready for review April 13, 2021 04:12

mattkime requested a review from a team as a code owner April 13, 2021 04:12

mattkime added v8.0.0 v7.13.0 Team:AppServices labels Apr 13, 2021

mattkime added release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed Feature:Data Views Data Views code and UI - index patterns before 8.0 labels Apr 13, 2021

mattkime requested a review from kindsun April 13, 2021 13:54

mattkime added 2 commits April 13, 2021 11:27

Merge branch 'master' into throw_correct_error_field_caps_404

6bfa329

don't show notification text when its not provided

6a92082

kindsun added the Team:Geo Former Team Label for Geo Team. Now use Team:Presentation label Apr 13, 2021

tsullivan reviewed Apr 13, 2021

View reviewed changes

kindsun approved these changes Apr 13, 2021

View reviewed changes

mattkime added the v7.12.1 label Apr 13, 2021

tsullivan approved these changes Apr 13, 2021

View reviewed changes

mattkime merged commit d80c257 into elastic:master Apr 13, 2021

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 13, 2021

Index patterns server - throw correct error on field caps 404 (elasti…

0e8a8a8

…c#95879) * throw correct error on field caps 404 and update tests

kibanamachine mentioned this pull request Apr 13, 2021

[7.x] Index patterns server - throw correct error on field caps 404 (#95879) #97033

Merged

mattkime mentioned this pull request Apr 13, 2021

[7.12] Index patterns server - throw correct error on field caps 404 (#95879) #97034

Merged

kibanamachine added a commit that referenced this pull request Apr 13, 2021

Index patterns server - throw correct error on field caps 404 (#95879) (

784270d

#97033) * throw correct error on field caps 404 and update tests Co-authored-by: Matthew Kime <matt@mattki.me>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Index patterns server - throw correct error on field caps 404#95879

Index patterns server - throw correct error on field caps 404#95879
mattkime merged 7 commits intoelastic:masterfrom
mattkime:throw_correct_error_field_caps_404

mattkime commented Mar 30, 2021 •

edited

Loading

Uh oh!

elasticmachine commented Apr 13, 2021

Uh oh!

kindsun commented Apr 13, 2021

Uh oh!

mattkime commented Apr 13, 2021

Uh oh!

elasticmachine commented Apr 13, 2021

Uh oh!

tsullivan Apr 13, 2021

Uh oh!

mattkime Apr 13, 2021 •

edited

Loading

Uh oh!

kibanamachine commented Apr 13, 2021

Uh oh!

kindsun left a comment

Uh oh!

kindsun commented Apr 13, 2021

Uh oh!

tsullivan left a comment

Uh oh!

kibanamachine commented Apr 13, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

mattkime commented Mar 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

elasticmachine commented Apr 13, 2021

Uh oh!

kindsun commented Apr 13, 2021

Uh oh!

mattkime commented Apr 13, 2021

Uh oh!

elasticmachine commented Apr 13, 2021

Uh oh!

tsullivan Apr 13, 2021

Choose a reason for hiding this comment

Uh oh!

mattkime Apr 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Apr 13, 2021

💚 Build Succeeded

Metrics [docs]

History

Uh oh!

kindsun left a comment

Choose a reason for hiding this comment

Uh oh!

kindsun commented Apr 13, 2021

Uh oh!

tsullivan left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Apr 13, 2021

💔 Backport failed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mattkime commented Mar 30, 2021 •

edited

Loading

mattkime Apr 13, 2021 •

edited

Loading