Skip to content

[Data telemetry] Add Async Search to the tests#96693

Merged
afharo merged 3 commits intoelastic:masterfrom
afharo:data-telemetry/add-async-search-test
Apr 14, 2021
Merged

[Data telemetry] Add Async Search to the tests#96693
afharo merged 3 commits intoelastic:masterfrom
afharo:data-telemetry/add-async-search-test

Conversation

@afharo
Copy link
Copy Markdown
Member

@afharo afharo commented Apr 9, 2021

Summary

Related to #96613: It adds a test to ensure Data Telemetry excludes Async Search indices. I double-checked it locally just in case .async-search is an alias and the actual index names could match any pattern. Confirmed: it is a plain index name (at least for now).

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@afharo afharo added Feature:Telemetry release_note:skip Skip the PR/issue when compiling release notes v7.13.0 labels Apr 9, 2021
@afharo afharo mentioned this pull request Apr 9, 2021
Closed
@afharo afharo marked this pull request as ready for review April 9, 2021 12:35
@afharo afharo requested a review from a team as a code owner April 9, 2021 12:35
@Bamieh
Copy link
Copy Markdown
Contributor

Bamieh commented Apr 12, 2021

@elasticmachine merge upstream

@afharo
Copy link
Copy Markdown
Member Author

afharo commented Apr 14, 2021

@elasticmachine merge upstream

@afharo afharo enabled auto-merge (squash) April 14, 2021 08:28
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 14, 2021

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afharo afharo merged commit f4f49bc into elastic:master Apr 14, 2021
@afharo afharo deleted the data-telemetry/add-async-search-test branch April 14, 2021 10:32
phillipb added a commit to phillipb/kibana that referenced this pull request Apr 14, 2021
@phillipb
Merge branch 'master' of github.com:elastic/kibana into add-log-rate-…
79e604e 
…to-metrics-tab

* 'master' of github.com:elastic/kibana: (61 commits)
  [Usage collection] Usage counters (elastic#96696)
  UI actions readme (elastic#96925)
  [TSVB] Enable brush for visualizations created with no index patterns (elastic#96727)
  [Data telemetry] Add Async Search to the tests (elastic#96693)
  added missing optional chain for bracket notation (elastic#96939)
  [Discover][DocViewer] Fix toggle columns from doc viewer table tab (elastic#95748)
  [TSVB] Fix per-request caching of index patterns (elastic#97043)
  [Datatable] Fix filter cell flakiness (elastic#96934)
  Unskip heatmap suite and fixes flakiness (elastic#96941)
  [Fleet] Improve performance of data stream API (elastic#97058)
  [ML] Data Frame Analytics: remove beta badge (elastic#96977)
  [App Search] Migrate expanded rows for meta engines table in Engines Overview (elastic#96251)
  Instances latency distribution chart tooltips and axis fixes (elastic#95577)
  [Monitoring] Using primary average shard size (elastic#96177)
  [Workplace Search] Hide Kibana chrome on 3rd party connector redirects (elastic#97028)
  ## [Security Solution] Fixes `Exit full screen` and `Copy to cliboard` styling issues (elastic#96676)
  Index pattern field editor - Add warning on name or type change (elastic#95528)
  [App Search] Add small engine breadcrumb utility helper (elastic#96917)
  Copy esArchiver commands from ./reassign.ts to fix tests (elastic#97012)
  [Security Solution][Detections] Updates MITRE Tactics, Techniques, and Subtechniques for 7.13 (elastic#97011)
  ...
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 16, 2021

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 96693 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 16, 2021
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 19, 2021

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 96693 or prevent reminders by adding the backport:skip label.

3 similar comments
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 20, 2021

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 96693 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 21, 2021

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 96693 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 22, 2021

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 96693 or prevent reminders by adding the backport:skip label.

@afharo afharo added auto-backport Deprecated - use backport:version if exact versions are needed v7.14.0 and removed auto-backport Deprecated - use backport:version if exact versions are needed labels Apr 22, 2021
@afharo
Copy link
Copy Markdown
Member Author

afharo commented Apr 22, 2021

oops! how could I forget? 🤦 Creating them now!

This was referenced Apr 22, 2021
Closed
Closed
afharo added a commit to afharo/kibana that referenced this pull request Apr 22, 2021
@afharo @kibanamachine
[Data telemetry] Add Async Search to the tests (elastic#96693)
9dbf16a 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
afharo added a commit to afharo/kibana that referenced this pull request Apr 22, 2021
@afharo @kibanamachine
[Data telemetry] Add Async Search to the tests (elastic#96693)
f811b49 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Apr 22, 2021
@afharo @kibanamachine
[Data telemetry] Add Async Search to the tests (elastic#96693)
e3299ff 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Apr 22, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Apr 22, 2021
@afharo @kibanamachine
[Data telemetry] Add Async Search to the tests (elastic#96693)
3e850e2 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Apr 22, 2021
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 22, 2021

💚 Backport successful

Status Branch Result
✅ 7.13
✅ 7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Apr 22, 2021
@kibanamachine @afharo
[Data telemetry] Add Async Search to the tests (#96693) (#97992)
85cae4c 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Alejandro Fernández Haro <alejandro.haro@elastic.co>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 22, 2021
kibanamachine added a commit that referenced this pull request Apr 22, 2021
@kibanamachine @afharo
[Data telemetry] Add Async Search to the tests (#96693) (#97993)
b20b697 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Alejandro Fernández Haro <alejandro.haro@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Bamieh Bamieh Bamieh approved these changes

Assignees

No one assigned

Labels

Feature:Telemetry release_note:skip Skip the PR/issue when compiling release notes v7.13.0 v7.14.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@afharo @Bamieh @kibanamachine