[Upgrade Assistant] Migrate server to new es-js client by alisonelizabeth · Pull Request #89207 · elastic/kibana

alisonelizabeth · 2021-01-25T19:17:02Z

This PR migrates Upgrade Assistant to use the new ES JS client.

How to test:

These changes are pretty widespread. I think UA has good test coverage to catch regressions, but it would also be good to run through the UI and do a quick smoke test.

Hack x-pack/plugins/upgrade_assistant/server/lib/es_migration_apis.ts and seed data:

      indices: indices.concat([
      {
        level: 'none',
        message: 'none level test',
        url: 'test/url',
        details: 'test details',
        index: 'test1',
        reindex: true,
        needsDefaultFields: false,
        blockerForReindexing: 'index-closed',
      },
      {
        level: 'info',
        message: 'info level test',
        url: 'test/url',
        details: 'test details',
        index: 'test2',
        reindex: true,
        needsDefaultFields: false,
      },
      {
        level: 'warning',
        message: 'warning level test2',
        url: 'test/url',
        details: 'test details',
        index: 'test3',
        reindex: true,
        needsDefaultFields: false,
      },
      {
        level: 'critical',
        message: 'metricbeat-1 successful fix',
        url: 'test/url',
        details: 'test details',
        index: 'metricbeat-1',
        reindex: false,
        needsDefaultFields: true,
      },
      {
        level: 'critical',
        message: 'metricbeat-2 failed fix',
        url: 'test/url',
        details: 'test details',
        index: 'metricbeat-2',
        reindex: false,
        needsDefaultFields: true,
      },
    ]),

Then, via Console, create indices:

PUT test1/_doc/1
{"foo":"bar"}
PUT test2/_doc/1
{"foo":"bar"}
PUT test3/_doc/1
{"foo":"bar"}
PUT metricbeat-1/_doc/1
{"foo":"bar"}

Navigate to Upgrade Assistant in Stack Management.
Verify enable/disable deprecation logging on the Overview tab
Go to the Indices tab and run reindex against test2 index

…ration/ua

alisonelizabeth · 2021-01-27T01:57:48Z

x-pack/test/upgrade_assistant_integration/upgrade_assistant/reindexing.js

@@ -13,7 +13,7 @@ import { getIndexState } from '../../../plugins/upgrade_assistant/common/get_ind
 export default function ({ getService }) {


I didn't realize these tests existed until today 😄 . We also have UA tests in x-pack/test/api_integration. In a future PR, it might be worth seeing if we can consolidate.

elasticmachine · 2021-01-27T01:59:03Z

Pinging @elastic/es-ui (Team:Elasticsearch UI)

jloleysens

Great work @alisonelizabeth ! I tested locally and was able to re-index indices as before.

I did notice one issue unrelated to these changes that might be worth following up on:

Clicking this documentation link just sent me back to the stack management home screen. I'm not sure how this URL is generated and whether it is different in a prod environment, but just wanted to raise this for visibility.

jloleysens · 2021-01-27T10:38:44Z

x-pack/plugins/upgrade_assistant/common/types.ts


 import { SavedObject, SavedObjectAttributes } from 'src/core/public';
-// eslint-disable-next-line @kbn/eslint/no-restricted-paths
-import type { DeprecationInfo } from '../../../../src/core/server/elasticsearch/legacy/api_types';


I am guessing these values are no longer being maintained on the core server side since it is in a "legacy" directory so they are safe to duplicate here without risk of something changing and TS not catching it?

Correct. I think it's safe to duplicate for now. I did not see any support for it with the new client. I also think UA was the only app consuming the legacy type.

jloleysens · 2021-01-27T10:58:07Z

@elasticmachine merge upstream

kibanamachine · 2021-01-27T12:36:35Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 011345c

Metrics [docs]

✅ unchanged

History

💚 Build #101328 succeeded b7fb0bb
💚 Build #101173 succeeded 4657b0c
💚 Build #101154 succeeded b204850
💔 Build #101112 failed b70b7df
💔 Build #100842 failed bc92fa2

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

alisonelizabeth · 2021-01-27T15:08:18Z

Thanks for the review @jloleysens!

Clicking this documentation link just sent me back to the stack management home screen. I'm not sure how this URL is generated and whether it is different in a prod environment, but just wanted to raise this for visibility.

👍 The documentation URL is generated from the response from the deprecation info API. You can see in the mocked data above it appears as url: 'test/url', which is likely why it's redirecting you back.

…y-tests * 'master' of github.com:elastic/kibana: (276 commits) [Telemetry] Settings Collector: redact sensitive reported values (elastic#88675) [CI] Combines Jest test jobs (elastic#85850) [Upgrade Assistant] Migrate server to new es-js client (elastic#89207) Migrate maps_legacy, maps_oss, region_map, and tile_map plugions to TS projects (elastic#89351) [Vega Docs] Add experimental flag on the vega maps title (elastic#89402) Increase the time needed to locate the save viz toast (elastic#89301) [Enterprise Search] Add links to doc links service (elastic#89260) Fixed regex bug in Safari (elastic#89399) [Lens] Fix indexpattern checks for missing references (elastic#88840) [Lens] Clean up usage collector (elastic#89109) update apm index pattern (elastic#89395) [APM] Upgrade ES client (elastic#86594) Enable v2 so migrations, disable in FTR tests (elastic#89297) [Search Sessions] Make search session indicator UI opt-in, refactor per-app capabilities (elastic#88699) Cleanup OSS code from visualizations wizard (elastic#89092) [APM] Optimize API test order (elastic#88654) Rename conversion function, extract to module scope and add tests. (elastic#89018) [core.logging] Add ops logs to the KP logging system (elastic#88070) chore(NA): improve ts build refs performance on kbn bootstrap (elastic#89333) skip flaky suite (elastic#89379) ... # Conflicts: # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/timeline/timeline.tsx # x-pack/test/accessibility/config.ts

…ana into task-manager/shift-on-trend * 'task-manager/shift-on-trend' of github.com:gmmorris/kibana: (74 commits) [Metrics UI] Fix Host Overview boxes in Host Detail page (elastic#89299) [Telemetry] Settings Collector: redact sensitive reported values (elastic#88675) [CI] Combines Jest test jobs (elastic#85850) [Upgrade Assistant] Migrate server to new es-js client (elastic#89207) Migrate maps_legacy, maps_oss, region_map, and tile_map plugions to TS projects (elastic#89351) [Vega Docs] Add experimental flag on the vega maps title (elastic#89402) Increase the time needed to locate the save viz toast (elastic#89301) [Enterprise Search] Add links to doc links service (elastic#89260) Fixed regex bug in Safari (elastic#89399) [Lens] Fix indexpattern checks for missing references (elastic#88840) [Lens] Clean up usage collector (elastic#89109) update apm index pattern (elastic#89395) [APM] Upgrade ES client (elastic#86594) Enable v2 so migrations, disable in FTR tests (elastic#89297) [Search Sessions] Make search session indicator UI opt-in, refactor per-app capabilities (elastic#88699) Cleanup OSS code from visualizations wizard (elastic#89092) [APM] Optimize API test order (elastic#88654) Rename conversion function, extract to module scope and add tests. (elastic#89018) [core.logging] Add ops logs to the KP logging system (elastic#88070) chore(NA): improve ts build refs performance on kbn bootstrap (elastic#89333) ...

…#89435)

migrate UA to new es-js client

bc92fa2

alisonelizabeth added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Upgrade Assistant v7.12.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// labels Jan 25, 2021

alisonelizabeth added 3 commits January 26, 2021 09:31

fix tests

5c89fbe

Merge branch 'master' of github.com:elastic/kibana into es_client_mig…

b70b7df

…ration/ua

cleanup

b204850

alisonelizabeth mentioned this pull request Jan 26, 2021

Stack Management elasticsearch-js client migration #73973

Closed

17 tasks

alisonelizabeth added the chore label Jan 26, 2021

alisonelizabeth added 2 commits January 26, 2021 12:18

migrate api_integration test

4657b0c

update upgrade_assistant_integration tests

b7fb0bb

alisonelizabeth commented Jan 27, 2021

View reviewed changes

alisonelizabeth requested a review from jloleysens January 27, 2021 01:58

alisonelizabeth marked this pull request as ready for review January 27, 2021 01:59

alisonelizabeth requested a review from a team as a code owner January 27, 2021 01:59

jloleysens approved these changes Jan 27, 2021

View reviewed changes

Merge branch 'master' into es_client_migration/ua

011345c

alisonelizabeth mentioned this pull request Jan 27, 2021

[Meta] Switch to the new Elasticsearch client #83910

Closed

74 tasks

alisonelizabeth merged commit 007e7e4 into elastic:master Jan 27, 2021

alisonelizabeth deleted the es_client_migration/ua branch January 27, 2021 15:22

alisonelizabeth mentioned this pull request Jan 27, 2021

[7.x] [Upgrade Assistant] Migrate server to new es-js client (#89207) #89435

Merged

alisonelizabeth mentioned this pull request Jan 28, 2021

[Upgrade Assistant] Fix getFlatSettings() request #89616

Merged

alisonelizabeth added a commit that referenced this pull request Jan 29, 2021

[7.x] [Upgrade Assistant] Migrate server to new es-js client (#89207) (…

e194a76

…#89435)

alisonelizabeth mentioned this pull request Jan 29, 2021

[Upgrade assistant] Clean up i18n #89661

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Upgrade Assistant] Migrate server to new es-js client#89207

[Upgrade Assistant] Migrate server to new es-js client#89207
alisonelizabeth merged 7 commits intoelastic:masterfrom
alisonelizabeth:es_client_migration/ua

alisonelizabeth commented Jan 25, 2021 •

edited

Loading

Uh oh!

alisonelizabeth Jan 27, 2021

Uh oh!

elasticmachine commented Jan 27, 2021

Uh oh!

jloleysens left a comment

Uh oh!

jloleysens Jan 27, 2021

Uh oh!

alisonelizabeth Jan 27, 2021

Uh oh!

jloleysens commented Jan 27, 2021

Uh oh!

kibanamachine commented Jan 27, 2021

Uh oh!

alisonelizabeth commented Jan 27, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		@@ -13,7 +13,7 @@ import { getIndexState } from '../../../plugins/upgrade_assistant/common/get_ind
		export default function ({ getService }) {

Conversation

alisonelizabeth commented Jan 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to test:

Uh oh!

alisonelizabeth Jan 27, 2021

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Jan 27, 2021

Uh oh!

jloleysens left a comment

Choose a reason for hiding this comment

Uh oh!

jloleysens Jan 27, 2021

Choose a reason for hiding this comment

Uh oh!

alisonelizabeth Jan 27, 2021

Choose a reason for hiding this comment

Uh oh!

jloleysens commented Jan 27, 2021

Uh oh!

kibanamachine commented Jan 27, 2021

💚 Build Succeeded

Metrics [docs]

History

Uh oh!

alisonelizabeth commented Jan 27, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

alisonelizabeth commented Jan 25, 2021 •

edited

Loading