[Uptime] Rename conversion function, extract to module scope and add tests by justinkambic · Pull Request #89018 · elastic/kibana

justinkambic · 2021-01-21T19:12:09Z

Summary

Resolves #88989.

We had some confusion over a function that performs conversion. It is doing an appropriate conversion (seconds to millis) but was named microToMillis. This patch simply renames the function. I also took it out of its inline position and added some tests for it.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
If a plugin configuration key changed, check if it needs to be whitelisted in the cloud and added to the docker list
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2021-01-21T19:12:12Z

Pinging @elastic/uptime (Team:uptime)

vigneshshanmugam

Looks good 👍

shahzad31 · 2021-01-25T09:42:41Z

@elasticmachine merge upstream

…kambic/kibana into uptime_rename-conversion-function

kibanamachine · 2021-01-25T18:52:12Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 0bcb817

Metrics [docs]

✅ unchanged

History

💚 Build #100627 succeeded d84295e
💚 Build #100425 succeeded 3560a93

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

justinkambic · 2021-01-25T22:05:59Z

@elastic/uptime need a CODEOWNER review.

dominiqueclarke

LGTM

dominiqueclarke · 2021-01-25T22:16:48Z

x-pack/plugins/uptime/server/lib/requests/get_network_events.test.ts

+    });
+
+    it('returns a value of seconds as milliseconds', () => {
+      expect(secondsToMillis(10)).toBe(10_000);


I have never in my life seen this underscore thing. Is that just syntactic sugar for formatting numbers?

'tis. Isn't it freaky? Someone on Twitter told me about it the other day.

PS @dominiqueclarke you only commented, not approved. Please ✅ if still LGTY.

…lastic#89018) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

…y-tests * 'master' of github.com:elastic/kibana: (276 commits) [Telemetry] Settings Collector: redact sensitive reported values (elastic#88675) [CI] Combines Jest test jobs (elastic#85850) [Upgrade Assistant] Migrate server to new es-js client (elastic#89207) Migrate maps_legacy, maps_oss, region_map, and tile_map plugions to TS projects (elastic#89351) [Vega Docs] Add experimental flag on the vega maps title (elastic#89402) Increase the time needed to locate the save viz toast (elastic#89301) [Enterprise Search] Add links to doc links service (elastic#89260) Fixed regex bug in Safari (elastic#89399) [Lens] Fix indexpattern checks for missing references (elastic#88840) [Lens] Clean up usage collector (elastic#89109) update apm index pattern (elastic#89395) [APM] Upgrade ES client (elastic#86594) Enable v2 so migrations, disable in FTR tests (elastic#89297) [Search Sessions] Make search session indicator UI opt-in, refactor per-app capabilities (elastic#88699) Cleanup OSS code from visualizations wizard (elastic#89092) [APM] Optimize API test order (elastic#88654) Rename conversion function, extract to module scope and add tests. (elastic#89018) [core.logging] Add ops logs to the KP logging system (elastic#88070) chore(NA): improve ts build refs performance on kbn bootstrap (elastic#89333) skip flaky suite (elastic#89379) ... # Conflicts: # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/timeline/timeline.tsx # x-pack/test/accessibility/config.ts

…ana into task-manager/shift-on-trend * 'task-manager/shift-on-trend' of github.com:gmmorris/kibana: (74 commits) [Metrics UI] Fix Host Overview boxes in Host Detail page (elastic#89299) [Telemetry] Settings Collector: redact sensitive reported values (elastic#88675) [CI] Combines Jest test jobs (elastic#85850) [Upgrade Assistant] Migrate server to new es-js client (elastic#89207) Migrate maps_legacy, maps_oss, region_map, and tile_map plugions to TS projects (elastic#89351) [Vega Docs] Add experimental flag on the vega maps title (elastic#89402) Increase the time needed to locate the save viz toast (elastic#89301) [Enterprise Search] Add links to doc links service (elastic#89260) Fixed regex bug in Safari (elastic#89399) [Lens] Fix indexpattern checks for missing references (elastic#88840) [Lens] Clean up usage collector (elastic#89109) update apm index pattern (elastic#89395) [APM] Upgrade ES client (elastic#86594) Enable v2 so migrations, disable in FTR tests (elastic#89297) [Search Sessions] Make search session indicator UI opt-in, refactor per-app capabilities (elastic#88699) Cleanup OSS code from visualizations wizard (elastic#89092) [APM] Optimize API test order (elastic#88654) Rename conversion function, extract to module scope and add tests. (elastic#89018) [core.logging] Add ops logs to the KP logging system (elastic#88070) chore(NA): improve ts build refs performance on kbn bootstrap (elastic#89333) ...

kibanamachine · 2021-01-29T03:54:39Z

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

…89018) (#89392) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

…89018) (#89391) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

justinkambic · 2021-01-29T21:14:57Z

Backported to:

7.11/7.11.0 6fe62a1
[7.11] Rename conversion function, extract to module scope and add tests. (#89018) #89392
7.x/7.12.0 cc0c9ec
[7.x] Rename conversion function, extract to module scope and add tests. (#89018) #89391

Rename conversion function, extract to module scope and add tests.

3560a93

justinkambic added bug Fixes for quality problems that affect the customer experience v8.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.11.0 v7.12.0 labels Jan 21, 2021

justinkambic self-assigned this Jan 21, 2021

justinkambic requested a review from a team as a code owner January 21, 2021 19:12

vigneshshanmugam approved these changes Jan 21, 2021

View reviewed changes

justinkambic added the release_note:skip Skip the PR/issue when compiling release notes label Jan 21, 2021

kibanamachine and others added 3 commits January 25, 2021 04:42

Merge branch 'master' into uptime_rename-conversion-function

d84295e

Merge branch 'master' into uptime_rename-conversion-function

2d4e458

Merge branch 'uptime_rename-conversion-function' of github.com:justin…

0bcb817

…kambic/kibana into uptime_rename-conversion-function

dominiqueclarke reviewed Jan 25, 2021

View reviewed changes

dominiqueclarke approved these changes Jan 26, 2021

View reviewed changes

justinkambic merged commit 3fe2e95 into elastic:master Jan 27, 2021

This was referenced Jan 27, 2021

[7.x] Rename conversion function, extract to module scope and add tests. (#89018) #89391

Merged

[7.11] Rename conversion function, extract to module scope and add tests. (#89018) #89392

Merged

justinkambic added a commit to justinkambic/kibana that referenced this pull request Jan 27, 2021

Rename conversion function, extract to module scope and add tests. (e…

696466a

…lastic#89018) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 29, 2021

kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 29, 2021

justinkambic deleted the uptime_rename-conversion-function branch January 29, 2021 21:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Uptime] Rename conversion function, extract to module scope and add tests#89018

[Uptime] Rename conversion function, extract to module scope and add tests#89018
justinkambic merged 4 commits intoelastic:masterfrom
justinkambic:uptime_rename-conversion-function

justinkambic commented Jan 21, 2021

Uh oh!

elasticmachine commented Jan 21, 2021

Uh oh!

vigneshshanmugam left a comment

Uh oh!

shahzad31 commented Jan 25, 2021

Uh oh!

kibanamachine commented Jan 25, 2021

Uh oh!

justinkambic commented Jan 25, 2021

Uh oh!

dominiqueclarke left a comment

Uh oh!

dominiqueclarke Jan 25, 2021

Uh oh!

justinkambic Jan 26, 2021

Uh oh!

justinkambic Jan 26, 2021

Uh oh!

kibanamachine commented Jan 29, 2021

Uh oh!

justinkambic commented Jan 29, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

justinkambic commented Jan 21, 2021

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented Jan 21, 2021

Uh oh!

vigneshshanmugam left a comment

Choose a reason for hiding this comment

Uh oh!

shahzad31 commented Jan 25, 2021

Uh oh!

kibanamachine commented Jan 25, 2021

💚 Build Succeeded

Metrics [docs]

History

Uh oh!

justinkambic commented Jan 25, 2021

Uh oh!

dominiqueclarke left a comment

Choose a reason for hiding this comment

Uh oh!

dominiqueclarke Jan 25, 2021

Choose a reason for hiding this comment

Uh oh!

justinkambic Jan 26, 2021

Choose a reason for hiding this comment

Uh oh!

justinkambic Jan 26, 2021

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Jan 29, 2021

Uh oh!

justinkambic commented Jan 29, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants