[Search Sessions] Make search session indicator UI opt-in#88699
Merged
Dosant merged 16 commits intoelastic:masterfrom Jan 27, 2021
Merged
[Search Sessions] Make search session indicator UI opt-in#88699Dosant merged 16 commits intoelastic:masterfrom
Dosant merged 16 commits intoelastic:masterfrom
Conversation
…t-in-to-session-ui # Conflicts: # src/plugins/data/public/public.api.md
Contributor
|
Pinging @elastic/kibana-app-services (Team:AppServices) |
Contributor
Author
|
@elasticmachine merge upstream |
…t-in-to-session-ui
…ibana into dev/search/opt-in-to-session-ui
lizozom
reviewed
Jan 21, 2021
Contributor
lizozom
left a comment
There was a problem hiding this comment.
Overall looks great.
Maybe we could add this to the sessions_in_space tests?
Should be simple enough to create a user that doesn't have this permission, and see that the component is properly disabled.
src/plugins/dashboard/public/application/hooks/use_dashboard_state_manager.ts
Show resolved
Hide resolved
lizozom
reviewed
Jan 21, 2021
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
|
@elasticmachine merge upstream |
Contributor
Author
I added these tests as you suggested. |
Contributor
|
Requires a deeper look into Discover, but indicator isn't showing up anymore in Lens, which LGTM |
lizozom
approved these changes
Jan 25, 2021
Contributor
lizozom
left a comment
There was a problem hiding this comment.
Just tested with and without permissions and seems good!
LGTM
Member
|
@elasticmachine merge upstream |
kertal
approved these changes
Jan 26, 2021
Member
kertal
left a comment
There was a problem hiding this comment.
Code LGTM, search sessions still work in Discover, tested locally in Chrome 👍
ThomThomson
approved these changes
Jan 26, 2021
Contributor
ThomThomson
left a comment
There was a problem hiding this comment.
Code only review - Dashboard changes LGTM.
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Dosant
added a commit
to Dosant/kibana
that referenced
this pull request
Jan 27, 2021
…er-app capabilities (elastic#88699)
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jan 27, 2021
…y-tests * 'master' of github.com:elastic/kibana: (276 commits) [Telemetry] Settings Collector: redact sensitive reported values (elastic#88675) [CI] Combines Jest test jobs (elastic#85850) [Upgrade Assistant] Migrate server to new es-js client (elastic#89207) Migrate maps_legacy, maps_oss, region_map, and tile_map plugions to TS projects (elastic#89351) [Vega Docs] Add experimental flag on the vega maps title (elastic#89402) Increase the time needed to locate the save viz toast (elastic#89301) [Enterprise Search] Add links to doc links service (elastic#89260) Fixed regex bug in Safari (elastic#89399) [Lens] Fix indexpattern checks for missing references (elastic#88840) [Lens] Clean up usage collector (elastic#89109) update apm index pattern (elastic#89395) [APM] Upgrade ES client (elastic#86594) Enable v2 so migrations, disable in FTR tests (elastic#89297) [Search Sessions] Make search session indicator UI opt-in, refactor per-app capabilities (elastic#88699) Cleanup OSS code from visualizations wizard (elastic#89092) [APM] Optimize API test order (elastic#88654) Rename conversion function, extract to module scope and add tests. (elastic#89018) [core.logging] Add ops logs to the KP logging system (elastic#88070) chore(NA): improve ts build refs performance on kbn bootstrap (elastic#89333) skip flaky suite (elastic#89379) ... # Conflicts: # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/timeline/timeline.tsx # x-pack/test/accessibility/config.ts
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jan 27, 2021
…ana into task-manager/shift-on-trend * 'task-manager/shift-on-trend' of github.com:gmmorris/kibana: (74 commits) [Metrics UI] Fix Host Overview boxes in Host Detail page (elastic#89299) [Telemetry] Settings Collector: redact sensitive reported values (elastic#88675) [CI] Combines Jest test jobs (elastic#85850) [Upgrade Assistant] Migrate server to new es-js client (elastic#89207) Migrate maps_legacy, maps_oss, region_map, and tile_map plugions to TS projects (elastic#89351) [Vega Docs] Add experimental flag on the vega maps title (elastic#89402) Increase the time needed to locate the save viz toast (elastic#89301) [Enterprise Search] Add links to doc links service (elastic#89260) Fixed regex bug in Safari (elastic#89399) [Lens] Fix indexpattern checks for missing references (elastic#88840) [Lens] Clean up usage collector (elastic#89109) update apm index pattern (elastic#89395) [APM] Upgrade ES client (elastic#86594) Enable v2 so migrations, disable in FTR tests (elastic#89297) [Search Sessions] Make search session indicator UI opt-in, refactor per-app capabilities (elastic#88699) Cleanup OSS code from visualizations wizard (elastic#89092) [APM] Optimize API test order (elastic#88654) Rename conversion function, extract to module scope and add tests. (elastic#89018) [core.logging] Add ops logs to the KP logging system (elastic#88070) chore(NA): improve ts build refs performance on kbn bootstrap (elastic#89333) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #88442
Previously the idea was that the search session indicator won't appear if an app doesn't use the search session. But recently Lens started using them without completing full integration #86297. If to enable
xpack.data_enhanced.search.sessions.enabledin master, then Lens show search session indicator, but sending session to background doesn't properly work.This pr changes the underlying logic of session service to show session indicator only app explicitly asked for that.
Also, I noticed, that we checked for per-app capabilities inside the data plugin component. I moved it outside and so now apps can configure search session indicator UI. In this case by setting it to disabled state.
What to test
The only user-facing difference comparing to master is that the search session indicator shouldn't appear in the Lens app.
Checklist
For maintainers