Cleanup OSS code from visualizations wizard by stratoula · Pull Request #89092 · elastic/kibana

stratoula · 2021-01-25T09:35:35Z

Summary

This PR cleans up the code that was related to the OSS functionality of the visualizations wizard component that was added here. It has to do with the two disabled cards that appear on the Oss version for Lens and Maps.

Specifically:

Removes the lens_oss and maps_oss plugins that registered the oss aliases.
Maps and Lens plugins no need to unregister the oss alias (as it is not registered anymore)
Removes the promoTooltip and disabled props from the VisTypeAlias as they were used only for the OSS
Removes the copyFromRoot from kbn/config as we are not going to need it anymore
Removes the functional test for OSS

Note:
I will not remove the unRegisterAlias method as it may be useful for some cases (see #88723)

Checklist

Delete any items that are not applicable to this PR.

Unit or functional tests were updated or added to match the most common scenarios
This was checked for cross-browser compatibility

elasticmachine · 2021-01-25T17:20:36Z

Pinging @elastic/kibana-app (Team:KibanaApp)

spalger

changes to bundle limits LGTM

sulemanof

Code LGTM, tested locally, works well 🎉
Just have a small concern around functional tests

test/functional/apps/visualize/index.ts

flash1293

Kibana app part LGTM, tested in chrome and works as expected

flash1293 · 2021-01-27T08:16:08Z

test/functional/apps/visualize/_chart_types.ts

-      let expectedChartTypes = [
+      const expectedChartTypes = [
        'Area',
-        'Coordinate Map',


Does this mean we won't test whether coordinate map and region map show up at all?

On this test yes but we already test it here
Not directly, but this test opens the wizard and clicks on the region map. Unfortunately, when the ci stops running the tests for OSS the above test won't also run.
if (isOss) { loadTestFile(require.resolve('./_tile_map')); loadTestFile(require.resolve('./_region_map')); }
We have to discuss this with the maps team.

Got it, makes sense

pgayvallet

LGTM for kbn-config changes. Thanks for reverting copyFromRoot in this PR.

kibanamachine · 2021-01-27T10:40:28Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 25201a6

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`lensOss`	7	-	-7
`mapsOss`	7	-	-7
total			-14

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`lens`	851.9KB	851.8KB	-1.0B
`maps`	2.6MB	2.6MB	-3.0B
`visualizations`	58.0KB	56.9KB	-1.1KB
total			-1.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`lens`	34.4KB	34.0KB	-361.0B
`lensOss`	4.5KB	-	-4.5KB
`maps`	138.6KB	138.2KB	-351.0B
`mapsOss`	4.2KB	-	-4.2KB
total			-9.4KB

History

💔 Build #101367 failed dc1b9c7
💚 Build #101018 succeeded 56f3c11
💚 Build #101002 succeeded 117d967
💚 Build #100711 succeeded 3f4923a
💔 Build #100694 failed 4413117

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* Cleanup OSS code from visualizations wizard * Remove unecessary translations * Remove unused translation * Fix functional test * Disable the functional test for OSS * Remove from oss correctly :D * Fix ci # Conflicts: # .github/CODEOWNERS # docs/developer/plugin-list.asciidoc # packages/kbn-optimizer/limits.yml

* Cleanup OSS code from visualizations wizard (#89092) * Cleanup OSS code from visualizations wizard * Remove unecessary translations * Remove unused translation * Fix functional test * Disable the functional test for OSS * Remove from oss correctly :D * Fix ci # Conflicts: # .github/CODEOWNERS # docs/developer/plugin-list.asciidoc # packages/kbn-optimizer/limits.yml * fix plugin list docs * Change plugins docs list

…y-tests * 'master' of github.com:elastic/kibana: (276 commits) [Telemetry] Settings Collector: redact sensitive reported values (elastic#88675) [CI] Combines Jest test jobs (elastic#85850) [Upgrade Assistant] Migrate server to new es-js client (elastic#89207) Migrate maps_legacy, maps_oss, region_map, and tile_map plugions to TS projects (elastic#89351) [Vega Docs] Add experimental flag on the vega maps title (elastic#89402) Increase the time needed to locate the save viz toast (elastic#89301) [Enterprise Search] Add links to doc links service (elastic#89260) Fixed regex bug in Safari (elastic#89399) [Lens] Fix indexpattern checks for missing references (elastic#88840) [Lens] Clean up usage collector (elastic#89109) update apm index pattern (elastic#89395) [APM] Upgrade ES client (elastic#86594) Enable v2 so migrations, disable in FTR tests (elastic#89297) [Search Sessions] Make search session indicator UI opt-in, refactor per-app capabilities (elastic#88699) Cleanup OSS code from visualizations wizard (elastic#89092) [APM] Optimize API test order (elastic#88654) Rename conversion function, extract to module scope and add tests. (elastic#89018) [core.logging] Add ops logs to the KP logging system (elastic#88070) chore(NA): improve ts build refs performance on kbn bootstrap (elastic#89333) skip flaky suite (elastic#89379) ... # Conflicts: # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/timeline/timeline.tsx # x-pack/test/accessibility/config.ts

…ana into task-manager/shift-on-trend * 'task-manager/shift-on-trend' of github.com:gmmorris/kibana: (74 commits) [Metrics UI] Fix Host Overview boxes in Host Detail page (elastic#89299) [Telemetry] Settings Collector: redact sensitive reported values (elastic#88675) [CI] Combines Jest test jobs (elastic#85850) [Upgrade Assistant] Migrate server to new es-js client (elastic#89207) Migrate maps_legacy, maps_oss, region_map, and tile_map plugions to TS projects (elastic#89351) [Vega Docs] Add experimental flag on the vega maps title (elastic#89402) Increase the time needed to locate the save viz toast (elastic#89301) [Enterprise Search] Add links to doc links service (elastic#89260) Fixed regex bug in Safari (elastic#89399) [Lens] Fix indexpattern checks for missing references (elastic#88840) [Lens] Clean up usage collector (elastic#89109) update apm index pattern (elastic#89395) [APM] Upgrade ES client (elastic#86594) Enable v2 so migrations, disable in FTR tests (elastic#89297) [Search Sessions] Make search session indicator UI opt-in, refactor per-app capabilities (elastic#88699) Cleanup OSS code from visualizations wizard (elastic#89092) [APM] Optimize API test order (elastic#88654) Rename conversion function, extract to module scope and add tests. (elastic#89018) [core.logging] Add ops logs to the KP logging system (elastic#88070) chore(NA): improve ts build refs performance on kbn bootstrap (elastic#89333) ...

stratoula added 2 commits January 25, 2021 11:34

Cleanup OSS code from visualizations wizard

612dbac

Remove unecessary translations

b199679

stratoula added release_note:skip Skip the PR/issue when compiling release notes Feature:Visualizations Generic visualization features (in case no more specific feature label is available) v7.12.0 v8.0.0 labels Jan 25, 2021

stratoula added 4 commits January 25, 2021 12:08

Remove unused translation

1016444

Fix functional test

5f1d419

Disable the functional test for OSS

4413117

Remove from oss correctly :D

3f4923a

stratoula added the Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// label Jan 25, 2021

stratoula marked this pull request as ready for review January 25, 2021 17:20

stratoula requested a review from a team January 25, 2021 17:20

stratoula requested review from a team as code owners January 25, 2021 17:20

spalger approved these changes Jan 25, 2021

View reviewed changes

stratoula added 2 commits January 26, 2021 09:56

Merge with master and resolve conflicts

117d967

Merge with master and resolve conflicts

56f3c11

stratoula requested a review from sulemanof January 26, 2021 11:55

sulemanof approved these changes Jan 26, 2021

View reviewed changes

test/functional/apps/visualize/index.ts Show resolved Hide resolved

flash1293 approved these changes Jan 27, 2021

View reviewed changes

pgayvallet approved these changes Jan 27, 2021

View reviewed changes

stratoula added 2 commits January 27, 2021 10:39

Resolve conflicts and marge master

dc1b9c7

Fix ci

25201a6

stratoula merged commit 64e9cf0 into elastic:master Jan 27, 2021

stratoula mentioned this pull request Jan 27, 2021

[7.x] Cleanup OSS code from visualizations wizard (#89092) #89409

Merged

nreese mentioned this pull request Jan 27, 2021

[Maps] remove maps_oss TS project #89502

Merged

nreese mentioned this pull request Mar 22, 2021

Users without access to Maps should not have the option to create them #88723

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cleanup OSS code from visualizations wizard#89092

Cleanup OSS code from visualizations wizard#89092
stratoula merged 10 commits intoelastic:masterfrom
stratoula:clean-oss-wizard

stratoula commented Jan 25, 2021 •

edited

Loading

Uh oh!

elasticmachine commented Jan 25, 2021

Uh oh!

spalger left a comment

Uh oh!

sulemanof left a comment

Uh oh!

Uh oh!

flash1293 left a comment

Uh oh!

flash1293 Jan 27, 2021

Uh oh!

stratoula Jan 27, 2021

Uh oh!

flash1293 Jan 27, 2021

Uh oh!

pgayvallet left a comment •

edited

Loading

Uh oh!

kibanamachine commented Jan 27, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

stratoula commented Jan 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

elasticmachine commented Jan 25, 2021

Uh oh!

spalger left a comment

Choose a reason for hiding this comment

Uh oh!

sulemanof left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

flash1293 left a comment

Choose a reason for hiding this comment

Uh oh!

flash1293 Jan 27, 2021

Choose a reason for hiding this comment

Uh oh!

stratoula Jan 27, 2021

Choose a reason for hiding this comment

Uh oh!

flash1293 Jan 27, 2021

Choose a reason for hiding this comment

Uh oh!

pgayvallet left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Jan 27, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Page load bundle

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

stratoula commented Jan 25, 2021 •

edited

Loading

pgayvallet left a comment •

edited

Loading