URL encoding for URL drilldown#86902
Merged
streamich merged 9 commits intoelastic:masterfrom Jan 4, 2021
streamich:url-encoding-2
Merged
URL encoding for URL drilldown#86902streamich merged 9 commits intoelastic:masterfrom streamich:url-encoding-2
streamich merged 9 commits intoelastic:masterfrom
streamich:url-encoding-2
Conversation
Contributor
|
Pinging @elastic/kibana-app-services (Team:AppServices) |
8 tasks
|
Both very useful changes. I like the clean organization as well. This looks great. |
Dosant
approved these changes
Jan 4, 2021
Contributor
Dosant
left a comment
There was a problem hiding this comment.
LGTM, tested new encode checkbox and checked that open in a new window still works
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]Distributable file count
Page load bundle
History
To update your PR or re-run it, just comment with: |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jan 4, 2021
…meline-component * 'master' of github.com:elastic/kibana: (955 commits) remove SameSite:None workaround (elastic#86994) URL encoding for URL drilldown (elastic#86902) [Security Solution] Fix few styling issues (elastic#87045) [APM] Custom links can still be created with a read only user. (elastic#87089) prevent double update (elastic#86794) Upgrade @hapi/hoek to revert hack introduced in hapi v20 upgrade (elastic#87113) [APM] Every time the new Header Icon is clicked it fetches data (elastic#87093) [APM] Add range query to service map trace walk (elastic#86631) [Discover] Deangularize navbar in context app (elastic#86353) skip "should schedule actions on legacy alerts" elastic#87010 🍾 update notice text for 2021 [logstash] remove "upgrade" functionality now that .logstash is a system index (elastic#87056) Enable prototype pollution protection in TSVB (elastic#85952) [Security Solution] add a consistent spelling of ES in Policy Response (elastic#87073) [SECURITY_SOLUTION][ENDPOINT] Delete Endpoint Policy List code (elastic#87063) Adds more URLs to the docs links service (elastic#86972) Add missing backticks in reporting-settings.asciidoc (elastic#77979) [test/functional_cors] 9000 is sometimes in use, make getPort random (elastic#87050) [Security Solution] Fix Timeline filter EuiSuperSelect styling (elastic#87033) [Lens] Fix duplicate suggestions on single-bucket charts (elastic#86996) ... # Conflicts: # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/index.ts
streamich
added a commit
that referenced
this pull request
Jan 5, 2021
* URL encoding for URL drilldown (#86902) * feat: 🎸 use EuiSwitch for "Open in new window" toggle * feat: 🎸 add "URL encoding" option and "Additional options" * feat: 🎸 make "Open in new window" true by default * feat: 🎸 respect encoding config setting * test: 💍 add encoding tests * feat: 🎸 add URI encoding Handlebars helpers * docs: ✏️ add URL encoding methods to URL Drilldown docs Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> * test: 💍 align 7.x branch with master Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #84650
encodeURIComponentandencodeURIQueryHandlebars helpers.Checklist
Delete any items that are not applicable to this PR.
For maintainers
Release note
In URL Drilldown "Open in new window" is now enabled by default. URL Drilldown now also has "Additional option" panel where URL encoding—which is enabled by default—can be disabled. Two new Handlebars helper functions were added to URL Drilldown:
encodeURIComponentandencodeURIQuery, which allow user to manually encode parts of URL when URL encoding is disabled.