Skip to content

[7.x] URL encoding for URL drilldown (#86902)#87143

Merged
streamich merged 4 commits intoelastic:7.xfrom
streamich:backport/7.x/pr-86902
Jan 5, 2021
Merged

[7.x] URL encoding for URL drilldown (#86902)#87143
streamich merged 4 commits intoelastic:7.xfrom
streamich:backport/7.x/pr-86902

Conversation

@streamich
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.x:

* feat: 🎸 use EuiSwitch for "Open in new window" toggle

* feat: 🎸 add "URL encoding" option and "Additional options"

* feat: 🎸 make "Open in new window" true by default

* feat: 🎸 respect encoding config setting

* test: 💍 add encoding tests

* feat: 🎸 add URI encoding Handlebars helpers

* docs: ✏️ add URL encoding methods to URL Drilldown docs

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@streamich streamich added the backport This PR is a backport of another PR label Jan 4, 2021
@streamich
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@streamich
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.6MB 1.5MB -26.9KB

Distributable file count

id before after diff
default 47592 48355 +763

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
triggersActionsUi 162.5KB 162.6KB +102.0B
uiActionsEnhanced 267.6KB 270.2KB +2.6KB
urlDrilldown 53.9KB 54.1KB +155.0B
total +2.9KB
Unknown metric groups

async chunk count

id before after diff
triggersActionsUi 31 32 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@streamich streamich merged commit 98485a5 into elastic:7.x Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants