[APM] Add range query to service map trace walk#86631
Merged
dgieselaar merged 5 commits intoelastic:masterfrom Jan 4, 2021
Merged
[APM] Add range query to service map trace walk#86631dgieselaar merged 5 commits intoelastic:masterfrom
dgieselaar merged 5 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/apm-ui (Team:apm) |
| const { apmEventClient } = setup; | ||
|
|
||
| // make sure there's a range so ES can skip shards | ||
| const day = 24 * 60 * 60 * 1000; |
Contributor
There was a problem hiding this comment.
Suggested change
| const day = 24 * 60 * 60 * 1000; | |
| const dayAsMilliseconds = 24 * 60 * 60 * 1000; |
Comment on lines
+41
to
+43
| { | ||
| range: rangeFilter(start, end), | ||
| }, |
Contributor
There was a problem hiding this comment.
Suggested change
| { | |
| range: rangeFilter(start, end), | |
| }, | |
| { range: rangeFilter(start, end), }, |
cauemarcondes
approved these changes
Dec 22, 2020
Contributor
cauemarcondes
left a comment
There was a problem hiding this comment.
LGTM, just some nits
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]Distributable file count
History
To update your PR or re-run it, just comment with: |
dgieselaar
added a commit
to dgieselaar/kibana
that referenced
this pull request
Jan 4, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
dgieselaar
added a commit
to dgieselaar/kibana
that referenced
this pull request
Jan 4, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
dgieselaar
added a commit
that referenced
this pull request
Jan 4, 2021
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jan 4, 2021
…meline-component * 'master' of github.com:elastic/kibana: (955 commits) remove SameSite:None workaround (elastic#86994) URL encoding for URL drilldown (elastic#86902) [Security Solution] Fix few styling issues (elastic#87045) [APM] Custom links can still be created with a read only user. (elastic#87089) prevent double update (elastic#86794) Upgrade @hapi/hoek to revert hack introduced in hapi v20 upgrade (elastic#87113) [APM] Every time the new Header Icon is clicked it fetches data (elastic#87093) [APM] Add range query to service map trace walk (elastic#86631) [Discover] Deangularize navbar in context app (elastic#86353) skip "should schedule actions on legacy alerts" elastic#87010 🍾 update notice text for 2021 [logstash] remove "upgrade" functionality now that .logstash is a system index (elastic#87056) Enable prototype pollution protection in TSVB (elastic#85952) [Security Solution] add a consistent spelling of ES in Policy Response (elastic#87073) [SECURITY_SOLUTION][ENDPOINT] Delete Endpoint Policy List code (elastic#87063) Adds more URLs to the docs links service (elastic#86972) Add missing backticks in reporting-settings.asciidoc (elastic#77979) [test/functional_cors] 9000 is sometimes in use, make getPort random (elastic#87050) [Security Solution] Fix Timeline filter EuiSuperSelect styling (elastic#87033) [Lens] Fix duplicate suggestions on single-bucket charts (elastic#86996) ... # Conflicts: # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/index.ts
dgieselaar
added a commit
that referenced
this pull request
Jan 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an +-1d offset to the service map query that fetches & walks traces. This allows ES to skip indices that will have no matches. Hopefully this will resolve some of the performance issues.
Creates an edge-case where long-running traces cannot be properly inspected (e.g., a trace that started well before the current time range), but that seems unlikely and worth the trade-off.