[APM] Custom links can still be created with a read only user.#87089
Merged
cauemarcondes merged 5 commits intoelastic:masterfrom Jan 4, 2021
Merged
[APM] Custom links can still be created with a read only user.#87089cauemarcondes merged 5 commits intoelastic:masterfrom
cauemarcondes merged 5 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/apm-ui (Team:apm) |
sorenlouv
approved these changes
Jan 2, 2021
Contributor
sorenlouv
left a comment
There was a problem hiding this comment.
Nice! Would be great to have this for all ui elements that require write access (eg. agent config)
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
@sqren done!
|
Contributor
|
Small suggestion; would it be another nice addition to show a tooltip when hovering the disabled button to explain why it's disabled? E.g. "Your user role doesn't have permissions to create custom links/agent configurations" |
Contributor
|
@cauemarcondes doesn't the custom link create route need an |
Contributor
Author
|
Contributor
|
@cauemarcondes thanks! |
Contributor
💚 Build SucceededMetrics [docs]Async chunks
Distributable file count
History
To update your PR or re-run it, just comment with: |
cauemarcondes
added a commit
to cauemarcondes/kibana
that referenced
this pull request
Jan 4, 2021
…ic#87089) * disabling buttons when user does not permission * fixing test * disabling create/edit button when user does not have write permission * addressing PR comments Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
cauemarcondes
added a commit
to cauemarcondes/kibana
that referenced
this pull request
Jan 4, 2021
…ic#87089) * disabling buttons when user does not permission * fixing test * disabling create/edit button when user does not have write permission * addressing PR comments Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jan 4, 2021
…meline-component * 'master' of github.com:elastic/kibana: (955 commits) remove SameSite:None workaround (elastic#86994) URL encoding for URL drilldown (elastic#86902) [Security Solution] Fix few styling issues (elastic#87045) [APM] Custom links can still be created with a read only user. (elastic#87089) prevent double update (elastic#86794) Upgrade @hapi/hoek to revert hack introduced in hapi v20 upgrade (elastic#87113) [APM] Every time the new Header Icon is clicked it fetches data (elastic#87093) [APM] Add range query to service map trace walk (elastic#86631) [Discover] Deangularize navbar in context app (elastic#86353) skip "should schedule actions on legacy alerts" elastic#87010 🍾 update notice text for 2021 [logstash] remove "upgrade" functionality now that .logstash is a system index (elastic#87056) Enable prototype pollution protection in TSVB (elastic#85952) [Security Solution] add a consistent spelling of ES in Policy Response (elastic#87073) [SECURITY_SOLUTION][ENDPOINT] Delete Endpoint Policy List code (elastic#87063) Adds more URLs to the docs links service (elastic#86972) Add missing backticks in reporting-settings.asciidoc (elastic#77979) [test/functional_cors] 9000 is sometimes in use, make getPort random (elastic#87050) [Security Solution] Fix Timeline filter EuiSuperSelect styling (elastic#87033) [Lens] Fix duplicate suggestions on single-bucket charts (elastic#86996) ... # Conflicts: # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/index.ts
cauemarcondes
added a commit
that referenced
this pull request
Jan 4, 2021
… (#87140) * disabling buttons when user does not permission * fixing test * disabling create/edit button when user does not have write permission * addressing PR comments Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
cauemarcondes
added a commit
that referenced
this pull request
Jan 4, 2021
… (#87139) * disabling buttons when user does not permission * fixing test * disabling create/edit button when user does not have write permission * addressing PR comments Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #87025
Before:
After:
