[Alerting] renames Resolved action group to Recovered by gmmorris · Pull Request #84123 · elastic/kibana

gmmorris · 2020-11-23T17:08:59Z

Summary

This PR changes the default term from “Resolved” to “Recovered”, as it fits most use cases and we feel users are most likely to understand its meaning across domains.

A follow up issue will add the ability for an Alert Type to specify its own label, so that recovered alerts are labeled in a manner that makes sense in that Alert Type’s domain.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
~~[ ] Documentation was added for features that require explanation or tutorials~~
Unit or functional tests were updated or added to match the most common scenarios
~~[ ] Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)~~
~~[ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)~~
~~[ ] This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)~~
~~[ ] This was checked for cross-browser compatibility~~

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2020-11-23T17:10:29Z

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

* master: (119 commits) [Uptime] Fix headers io-ts type (elastic#84089) [fleet] Add config options to accepted docker env vars (elastic#84338) [Fleet] Support URL query state in agent logs UI (elastic#84298) [basePathProxy] include query in redirect (elastic#84356) [Security Solution] Add Endpoint policy feature checks (elastic#83972) Fix issues with show_license_expiration (elastic#84361) [Security Solution][Resolver] Add support for predefined schemas for endpoint and winlogbeat (elastic#84103) [cli/dev] log a warning when --no-base-path is used with --dev (elastic#84354) [Fleet] Support input-level vars & templates (elastic#83878) [APM] Elastic chart issues (elastic#84238) [Time to Visualize] Fix Unlink Action via Rollback of ReplacePanel (elastic#83873) redirect to visualize listing page when by value visualization editor doesn't have a value input (elastic#84287) add live region for field search (elastic#84310) [ML] Persisted URL state for Anomalies table (elastic#84314) [dev/cli] detect worker type using env, not cluster module (elastic#83977) [Workplace Search] Migrate DisplaySettings tree (elastic#84283) Deprecate `xpack.task_manager.index` setting (elastic#84155) [Search] Search batching using bfetch (again) (elastic#84043) Use .kibana instead of .kibana_current to mark migration completion (elastic#83373) [Monitoring] Only look at ES for the missing data alert for now (elastic#83839) ...

gmmorris · 2020-11-30T09:50:37Z

@elasticmachine merge upstream

ymao1

LGTM!

mikecote

Changes LGTM! I left a few nits and backwards compatibility notes.

nit: Some event log tests still using resolved terminology: x-pack/test/alerting_api_integration/spaces_only/tests/alerting/event_log.ts.

x-pack/plugins/alerts/server/lib/alert_instance_summary_from_event_log.test.ts

x-pack/plugins/alerts/server/lib/alert_instance_summary_from_event_log.ts

x-pack/plugins/alerts/server/plugin.ts

x-pack/plugins/alerts/server/task_runner/task_runner.ts

* master: (25 commits) [Alerting] fixes buggy default message behaviour (elastic#84202) [Graph] Use new ES client and change license API (elastic#84398) [DOCS] Adds redirect to known plugins page (elastic#84001) Update IndexPatternSelect to get fields from indexPatternService instead of savedObject attributes (elastic#84376) Adding timestamps to created events so the sorting is stable (elastic#84515) [DOCS] Redirects for drilldown links (elastic#83846) [Fleet] Support for showing an Integration Detail Custom (UI Extension) tab (elastic#83805) [Enterprise Search] Migrate shared Schema components (elastic#84381) [Discover] Unskip date_nanos and shard links functional tests (elastic#82878) [APM] ML anomaly detection integration: Displaying anomaly job results in the Transaction duration chart is not as intended (elastic#84415) Support for painless language autocomplete within monaco (elastic#80577) [Lens] Time scale ui (elastic#83904) removing beta callouts (elastic#84510) [Lens] (Accessibility) add aria-label to chart type icon (elastic#84493) Trusted Apps signer API. (elastic#83661) increase stdout max listeners for legacy logging (elastic#84497) [APM] Service overview: Add throughput chart (elastic#84439) [Discover] Unskip main functional tests (elastic#84300) Uptime overview overhaul (elastic#83406) [APM] Adjust time formats based on the difference between start and end (elastic#84470) ...

kibanamachine · 2020-11-30T19:01:32Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: fd9ff25

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`triggersActionsUi`	1.5MB	1.5MB	+2.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`alerts`	66.4KB	66.4KB	+7.0B
`triggersActionsUi`	161.2KB	161.2KB	+4.0B
total			+11.0B

History

💚 Build #90626 succeeded 1abc873
💚 Build #90397 succeeded 6ab8d4d
💔 Build #90389 failed f2bd0e0
💔 Build #89757 failed 6dd664d
💔 Build #89723 failed 8716b86

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

weltenwort

infra plugin changes LGTM

This reverts commit 7dcaff5.

tylersmalley · 2020-12-01T15:11:06Z

Reverted as it failed when it hit master: 0b5c55c

…elastic#84123)"" This reverts commit 0b5c55c.

…overed (#84123)" (#84662) Reapplies the #84123 PR: This PR changes the default term from “Resolved” to “Recovered”, as it fits most use cases and we feel users are most likely to understand its meaning across domains.

* master: (63 commits) Revert the Revert of "[Alerting] renames Resolved action group to Recovered (elastic#84123)" (elastic#84662) declare kbn/monaco dependency on kbn/i18n explicitly (elastic#84660) Remove unscripted fields from sample data index-pattern saved objects (elastic#84659) [ML] Fix unnecessary trigger of wildcard field type search for ML plugin routes. (elastic#84605) Update create.asciidoc (elastic#84046) [Security Solution][Detections] Fix labels and issue with mandatory fields (elastic#84525) Fix flaky test suite (elastic#84602) [Security Solution] [Detections] Create a 'partial failure' status for rules (elastic#84293) Revert "[Alerting] renames Resolved action group to Recovered (elastic#84123)" Update code-comments describing babel plugins (elastic#84622) [Security Solution] [Cases] Cypress for case connector selector options (elastic#80745) [Discover] Unskip doc table tests (elastic#84564) [Lens] (Accessibility) Improve landmarks in Lens (elastic#84511) [Lens] (Accessibility) Focus mistakenly stops on righthand form (elastic#84519) Return early when parallel install process detected (elastic#84190) [Security Solution][Detections] Support arrays in event fields for Severity/Risk overrides (elastic#83723) [Security Solution][Detections] Fix grammatical error in validation message for threshold field in "Create new rule" -> "Define rule" (elastic#84490) [Fleet] Update agent details page (elastic#84434) adding documentation of use of NODE_EXTRA_CA_CERTS env var (elastic#84578) [Search] Integrate "Send to background" UI with session service (elastic#83073) ...

…overed (elastic#84123)" (elastic#84662) Reapplies the elastic#84123 PR: This PR changes the default term from “Resolved” to “Recovered”, as it fits most use cases and we feel users are most likely to understand its meaning across domains. # Conflicts: # x-pack/plugins/infra/server/lib/alerting/inventory_metric_threshold/inventory_metric_threshold_executor.ts # x-pack/plugins/infra/server/lib/alerting/metric_threshold/metric_threshold_executor.test.ts # x-pack/plugins/infra/server/lib/alerting/metric_threshold/metric_threshold_executor.ts # x-pack/plugins/triggers_actions_ui/public/application/sections/action_connector_form/action_type_form.tsx

…overed (elastic#84123)" (elastic#84662) Reapplies the elastic#84123 PR: This PR changes the default term from “Resolved” to “Recovered”, as it fits most use cases and we feel users are most likely to understand its meaning across domains. # Conflicts: # x-pack/plugins/triggers_actions_ui/public/application/sections/action_connector_form/action_type_form.tsx

…overed (#84123)" (#84662) (#84701) Reapplies the #84123 PR: This PR changes the default term from “Resolved” to “Recovered”, as it fits most use cases and we feel users are most likely to understand its meaning across domains. # Conflicts: # x-pack/plugins/triggers_actions_ui/public/application/sections/action_connector_form/action_type_form.tsx

renamed Resolved to Recovered

8716b86

gmmorris requested a review from a team as a code owner November 23, 2020 17:09

gmmorris added Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v7.11.0 v8.0.0 labels Nov 23, 2020

fixed missing import

6dd664d

gmmorris requested a review from a team as a code owner November 23, 2020 18:30

gmmorris marked this pull request as draft November 24, 2020 10:45

gmmorris added 3 commits November 26, 2020 09:54

fixed resolved in tests

0d57716

fixed unit test

6ab8d4d

gmmorris marked this pull request as ready for review November 26, 2020 12:02

Merge branch 'master' into alerts/rename-resolved-to-recovered

1abc873

ymao1 approved these changes Nov 30, 2020

View reviewed changes

mikecote self-requested a review November 30, 2020 15:48

mikecote approved these changes Nov 30, 2020

View reviewed changes

gmmorris added 2 commits November 30, 2020 17:19

support legacy event log alert recovery syntax

fd9ff25

weltenwort approved these changes Dec 1, 2020

View reviewed changes

gmmorris merged commit 7dcaff5 into elastic:master Dec 1, 2020

tylersmalley added a commit that referenced this pull request Dec 1, 2020

Revert "[Alerting] renames Resolved action group to Recovered (#84123)"

0b5c55c

This reverts commit 7dcaff5.

tylersmalley added the reverted label Dec 1, 2020

gmmorris added a commit to gmmorris/kibana that referenced this pull request Dec 1, 2020

Revert "Revert "[Alerting] renames Resolved action group to Recovered (…

74bbfdd

…elastic#84123)"" This reverts commit 0b5c55c.

mikecote mentioned this pull request Dec 1, 2020

Revert the Revert of "[Alerting] renames Resolved action group to Recovered (#84123)" #84662

Merged

8 tasks

gmmorris mentioned this pull request Dec 1, 2020

[7.x] Revert the Revert of "[Alerting] renames Resolved action group to Recovered (#84123)" (#84662) #84685

Closed

gmmorris mentioned this pull request Dec 1, 2020

[7.x] Revert the Revert of "[Alerting] renames Resolved action group to Recovered (#84123)" (#84662) #84701

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Alerting] renames Resolved action group to Recovered#84123

[Alerting] renames Resolved action group to Recovered#84123
gmmorris merged 8 commits intoelastic:masterfrom
gmmorris:alerts/rename-resolved-to-recovered

gmmorris commented Nov 23, 2020 •

edited

Loading

Uh oh!

elasticmachine commented Nov 23, 2020

Uh oh!

gmmorris commented Nov 30, 2020

Uh oh!

ymao1 left a comment

Uh oh!

mikecote left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kibanamachine commented Nov 30, 2020

Uh oh!

weltenwort left a comment

Uh oh!

tylersmalley commented Dec 1, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

gmmorris commented Nov 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented Nov 23, 2020

Uh oh!

gmmorris commented Nov 30, 2020

Uh oh!

ymao1 left a comment

Choose a reason for hiding this comment

Uh oh!

mikecote left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kibanamachine commented Nov 30, 2020

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

History

Uh oh!

weltenwort left a comment

Choose a reason for hiding this comment

Uh oh!

tylersmalley commented Dec 1, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

gmmorris commented Nov 23, 2020 •

edited

Loading