declare kbn/monaco dependency on kbn/i18n explicitly#84660
Merged
spalger merged 1 commit intoelastic:masterfrom Dec 1, 2020
Merged
declare kbn/monaco dependency on kbn/i18n explicitly#84660spalger merged 1 commit intoelastic:masterfrom
spalger merged 1 commit intoelastic:masterfrom
Conversation
Contributor
Author
|
@elastic/kibana-operations is it possible to detect such cases on CI? |
Contributor
|
We definitely run |
Contributor
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
spalger
approved these changes
Dec 1, 2020
Contributor
spalger
left a comment
There was a problem hiding this comment.
Looks like the issue is a race condition between the bootstrap step for @kbn/i18n and @kbn/monaco. Because they have similar dependencies the bootstrap scripts start at similar times and on CI it seems that @kbn/i18n finished first causing the @kbn/monaco bootstrap task to complete successfully. The only way to test and prevent this would be to use something like eslint and validate that all dependencies are declared, which we can consider, but it's not going to be an easy thing to turn on and will likely require some code to get working.
alisonelizabeth
approved these changes
Dec 1, 2020
Contributor
alisonelizabeth
left a comment
There was a problem hiding this comment.
LGTM. Thanks for fixing this!
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Dec 1, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Dec 1, 2020
* master: (63 commits) Revert the Revert of "[Alerting] renames Resolved action group to Recovered (elastic#84123)" (elastic#84662) declare kbn/monaco dependency on kbn/i18n explicitly (elastic#84660) Remove unscripted fields from sample data index-pattern saved objects (elastic#84659) [ML] Fix unnecessary trigger of wildcard field type search for ML plugin routes. (elastic#84605) Update create.asciidoc (elastic#84046) [Security Solution][Detections] Fix labels and issue with mandatory fields (elastic#84525) Fix flaky test suite (elastic#84602) [Security Solution] [Detections] Create a 'partial failure' status for rules (elastic#84293) Revert "[Alerting] renames Resolved action group to Recovered (elastic#84123)" Update code-comments describing babel plugins (elastic#84622) [Security Solution] [Cases] Cypress for case connector selector options (elastic#80745) [Discover] Unskip doc table tests (elastic#84564) [Lens] (Accessibility) Improve landmarks in Lens (elastic#84511) [Lens] (Accessibility) Focus mistakenly stops on righthand form (elastic#84519) Return early when parallel install process detected (elastic#84190) [Security Solution][Detections] Support arrays in event fields for Severity/Risk overrides (elastic#83723) [Security Solution][Detections] Fix grammatical error in validation message for threshold field in "Create new rule" -> "Define rule" (elastic#84490) [Fleet] Update agent details page (elastic#84434) adding documentation of use of NODE_EXTRA_CA_CERTS env var (elastic#84578) [Search] Integrate "Send to background" UI with session service (elastic#83073) ...
spalger
pushed a commit
that referenced
this pull request
Dec 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
after #80577
yarn kbn bootstrapfails locally withbecause
@kbn/monacoimports@kbn/i18nbut doesn't list it independenciessection