[APM] ML anomaly detection integration: Displaying anomaly job results in the Transaction duration chart is not as intended #84415
Merged
cauemarcondes merged 7 commits intoelastic:masterfrom Nov 30, 2020
Conversation
Contributor
|
Pinging @elastic/apm-ui (Team:apm) |
10 tasks
formgeist
approved these changes
Nov 26, 2020
Contributor
formgeist
left a comment
There was a problem hiding this comment.
The anomaly scores and stream look great 👍
Two visual issues that I spotted;
- The actual chart height is somehow a lot smaller than previously.
- The link to the ML job reads:
Machine Learning: View job:- should get rid of that last:
Contributor
Author
I'm going to remove the extra |
Contributor
Author
|
@elasticmachine merge upstream |
sorenlouv
reviewed
Nov 30, 2020
x-pack/plugins/apm/public/components/shared/charts/timeseries_chart.tsx
Outdated
Show resolved
Hide resolved
sorenlouv
reviewed
Nov 30, 2020
x-pack/plugins/apm/public/components/shared/charts/timeseries_chart.tsx
Outdated
Show resolved
Hide resolved
sorenlouv
approved these changes
Nov 30, 2020
Contributor
sorenlouv
left a comment
There was a problem hiding this comment.
Just one nit about the structure of anomalySeries
…bana into apm-ml-annomalies-chart
sorenlouv
reviewed
Nov 30, 2020
sorenlouv
approved these changes
Nov 30, 2020
Contributor
Author
|
@sqren I'm going to merge this PR when the CI passes and if I see that the anomalies boundaries are really positioned wrongly I'll create a new issue. I need this to be able to implement the Latency chart in the Service Overview page. |
Contributor
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
cauemarcondes
added a commit
to cauemarcondes/kibana
that referenced
this pull request
Nov 30, 2020
…s in the Transaction duration chart is not as intended (elastic#84415) * adding anomalies to transaction duration chart * removing extra : * fixing test * addressing pr comments * addressing pr comments Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
phillipb
added a commit
to phillipb/kibana
that referenced
this pull request
Nov 30, 2020
…bana into add-metadata-to-node-details * 'add-metadata-to-node-details' of github.com:phillipb/kibana: [APM] ML anomaly detection integration: Displaying anomaly job results in the Transaction duration chart is not as intended (elastic#84415) Support for painless language autocomplete within monaco (elastic#80577) [Lens] Time scale ui (elastic#83904) removing beta callouts (elastic#84510) [Lens] (Accessibility) add aria-label to chart type icon (elastic#84493) Trusted Apps signer API. (elastic#83661) increase stdout max listeners for legacy logging (elastic#84497) [APM] Service overview: Add throughput chart (elastic#84439) [Discover] Unskip main functional tests (elastic#84300) Uptime overview overhaul (elastic#83406) [APM] Adjust time formats based on the difference between start and end (elastic#84470) [ML] Renaming saved object repair to sync (elastic#84311) [UsageCollection] Remove `formatBulkUpload` and other unused APIs (elastic#84313) [Visualizations] Adds visConfig.title and uiState to build pipeline function (elastic#84456) [Elasticsearch Migration] Update docs re UsageCollection (elastic#84322) TSVB field list performance issue on using annotations (elastic#84407) [Security Solution] Exceptions Cypress tests (elastic#81759) [ML] Fix spaces job ID check (elastic#84404) [Security Solution][Detections] Handle dupes when processing threshold rules (elastic#83062)
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Nov 30, 2020
* master: (25 commits) [Alerting] fixes buggy default message behaviour (elastic#84202) [Graph] Use new ES client and change license API (elastic#84398) [DOCS] Adds redirect to known plugins page (elastic#84001) Update IndexPatternSelect to get fields from indexPatternService instead of savedObject attributes (elastic#84376) Adding timestamps to created events so the sorting is stable (elastic#84515) [DOCS] Redirects for drilldown links (elastic#83846) [Fleet] Support for showing an Integration Detail Custom (UI Extension) tab (elastic#83805) [Enterprise Search] Migrate shared Schema components (elastic#84381) [Discover] Unskip date_nanos and shard links functional tests (elastic#82878) [APM] ML anomaly detection integration: Displaying anomaly job results in the Transaction duration chart is not as intended (elastic#84415) Support for painless language autocomplete within monaco (elastic#80577) [Lens] Time scale ui (elastic#83904) removing beta callouts (elastic#84510) [Lens] (Accessibility) add aria-label to chart type icon (elastic#84493) Trusted Apps signer API. (elastic#83661) increase stdout max listeners for legacy logging (elastic#84497) [APM] Service overview: Add throughput chart (elastic#84439) [Discover] Unskip main functional tests (elastic#84300) Uptime overview overhaul (elastic#83406) [APM] Adjust time formats based on the difference between start and end (elastic#84470) ...
cauemarcondes
added a commit
that referenced
this pull request
Dec 1, 2020
…s in the Transaction duration chart is not as intended (#84415) (#84524) * adding anomalies to transaction duration chart * removing extra : * fixing test * addressing pr comments * addressing pr comments Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #84185