TSVB field list performance issue on using annotations#84407
Merged
DianaDerevyankina merged 5 commits intoelastic:masterfrom Nov 30, 2020
Merged
TSVB field list performance issue on using annotations#84407DianaDerevyankina merged 5 commits intoelastic:masterfrom
DianaDerevyankina merged 5 commits intoelastic:masterfrom
Conversation
Contributor
|
@elasticmachine merge upstream |
alexwizp
reviewed
Nov 27, 2020
src/plugins/vis_type_timeseries/public/application/components/vis_editor.js
Outdated
Show resolved
Hide resolved
alexwizp
reviewed
Nov 27, 2020
src/plugins/vis_type_timeseries/public/application/components/vis_editor.js
Outdated
Show resolved
Hide resolved
alexwizp
reviewed
Nov 27, 2020
src/plugins/vis_type_timeseries/public/application/components/annotations_editor.js
Outdated
Show resolved
Hide resolved
alexwizp
approved these changes
Nov 30, 2020
Contributor
alexwizp
left a comment
There was a problem hiding this comment.
Tested locally. Code LGTM. Thank you
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
Contributor
Author
|
@elasticmachine merge upstream |
stratoula
reviewed
Nov 30, 2020
| }); | ||
| }, VIS_STATE_DEBOUNCE_DELAY); | ||
|
|
||
| fetchFields = debounce( |
Contributor
There was a problem hiding this comment.
Can we give this function a different name in order to not be confused with the fetchFields from lib?
Contributor
Author
There was a problem hiding this comment.
Sure, renamed it to debouncedFetchFields
stratoula
approved these changes
Nov 30, 2020
Contributor
stratoula
left a comment
There was a problem hiding this comment.
Code LGTM, I have tested it locally and it works fine 🙂
Contributor
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
DianaDerevyankina
added a commit
to DianaDerevyankina/kibana
that referenced
this pull request
Nov 30, 2020
* TSVB field list performance issue on using annotations * Add AbortController to fetchFields and change translation id in annotations_editor * Rename fetchFields to debouncedFetchFields Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
DianaDerevyankina
added a commit
that referenced
this pull request
Nov 30, 2020
* TSVB field list performance issue on using annotations * Add AbortController to fetchFields and change translation id in annotations_editor * Rename fetchFields to debouncedFetchFields Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
phillipb
added a commit
to phillipb/kibana
that referenced
this pull request
Nov 30, 2020
…bana into add-metadata-to-node-details * 'add-metadata-to-node-details' of github.com:phillipb/kibana: [APM] ML anomaly detection integration: Displaying anomaly job results in the Transaction duration chart is not as intended (elastic#84415) Support for painless language autocomplete within monaco (elastic#80577) [Lens] Time scale ui (elastic#83904) removing beta callouts (elastic#84510) [Lens] (Accessibility) add aria-label to chart type icon (elastic#84493) Trusted Apps signer API. (elastic#83661) increase stdout max listeners for legacy logging (elastic#84497) [APM] Service overview: Add throughput chart (elastic#84439) [Discover] Unskip main functional tests (elastic#84300) Uptime overview overhaul (elastic#83406) [APM] Adjust time formats based on the difference between start and end (elastic#84470) [ML] Renaming saved object repair to sync (elastic#84311) [UsageCollection] Remove `formatBulkUpload` and other unused APIs (elastic#84313) [Visualizations] Adds visConfig.title and uiState to build pipeline function (elastic#84456) [Elasticsearch Migration] Update docs re UsageCollection (elastic#84322) TSVB field list performance issue on using annotations (elastic#84407) [Security Solution] Exceptions Cypress tests (elastic#81759) [ML] Fix spaces job ID check (elastic#84404) [Security Solution][Detections] Handle dupes when processing threshold rules (elastic#83062)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #83405
Summary
fetchFieldsfunctionChecklist
Delete any items that are not applicable to this PR.
For maintainers