[Enterprise Search] Share Loading component#83246
Conversation
|
@daveyholler FYI on this. It's not as fancy as App Search's current loader but if we really want that I'd like to ask we postpone until 7.13+ and later investigate how to port a nicer animation without a 3rd party animation lib dependency. |
daveyholler
left a comment
There was a problem hiding this comment.
This is perfectly acceptable. Thanks!!!
1f20e65 to
2e5ad24
Compare
|
I wonder if it's worth just sharing the one we have for DRY sake? |
|
WHAT! 🤯 I totally missed that lol, thanks Scotty. The only reason why I can think we wouldn't is if we do concretely plan on backporting the app search specific loader which has our logo and fancy animations. Lemme check w/ Davey rq. |
- for pages with shifting layouts or where skeletal loading doesn't make sense
|
@scottybollinger Here's WS with the new Loading component:
FYI that I use position absolute to center which works well with all our Layout views but less so with the non-Layout WS overview, so I added a temporary wrapper: a25d7dd
Let me know if that looks good to you! |
scottybollinger
left a comment
There was a problem hiding this comment.
This is great. Works perfectly locally. One suggested nit
...plugins/enterprise_search/public/applications/app_search/components/engine/engine_router.tsx
Outdated
Show resolved
Hide resolved
…h/components/engine/engine_router.tsx Co-authored-by: Scotty Bollinger <scotty.bollinger@elastic.co>
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
* Add basic Loading component - for pages with shifting layouts or where skeletal loading doesn't make sense * Move Loading to shared components * Update WS to use new shared Loading component * Fix for non-Layout WS Overview page * Update x-pack/plugins/enterprise_search/public/applications/app_search/components/engine/engine_router.tsx Co-authored-by: Scotty Bollinger <scotty.bollinger@elastic.co> Co-authored-by: Scotty Bollinger <scotty.bollinger@elastic.co> Co-authored-by: Scotty Bollinger <scotty.bollinger@elastic.co>
* master: [Security Solution][Detections] Adds framework for replacing API schemas (elastic#82462) [Enterprise Search] Share Loading component (elastic#83246) Consolidates Jest configuration files and scripts (elastic#82671) APM header changes (elastic#82870) [Security Solutions] Adds a default for indicator match custom query of *:* (elastic#81727) [Security Solution] Note 10k object paging limit on Endpoint list (elastic#82889) [packerCache] fix gulp usage, don't archive node_modules (elastic#83327) Upgrade Node.js to version 12 (elastic#61587) [Actions] Removing placeholders and updating validation messages on connector forms (elastic#82734) [Fleet] Rename ingest_manager_api_integration tests fleet_api_integration (elastic#83011) [DOCS] Updates Discover docs (elastic#82773) [ML] Data frame analytics: Adds map view (elastic#81666) enables actions scoped within the stack to register at Basic license (elastic#82931)
Summary
[Edit: PR was updated to have both App Search and Workplace Search share the same basic Loading component]
I'm adding a super basic loading spinner for views where skeletal views don't make sense. Also to make our migration a little bit faster so we don't have to think too much / change too much WRT dataLoading & early returns.
QA
if dataLoadingconditional onengine_router.tsxso it always returns Loading and go to any engine page.Checklist