Skip to content

[Fleet] Rename ingest_manager_api_integration tests fleet_api_integration#83011

Merged
nchaulet merged 5 commits intoelastic:masterfrom
nchaulet:feature-rename-ingestmanager-fleet-tests
Nov 12, 2020
Merged

[Fleet] Rename ingest_manager_api_integration tests fleet_api_integration#83011
nchaulet merged 5 commits intoelastic:masterfrom
nchaulet:feature-rename-ingestmanager-fleet-tests

Conversation

@nchaulet
Copy link
Copy Markdown
Member

@nchaulet nchaulet commented Nov 9, 2020 •
edited
Loading

Description

In the effort of renaming the Ingest Manager plugin Fleet.
Rename the api integration test folder.

x-pack/test/ingest_manager_api_integration => x-pack/test/fleet_api_integration
x-pack/test/ingest_manager_api_integration/apis/fleet/agents => x-pack/test/fleet_api_integration/apis/agents
x-pack/test/ingest_manager_api_integration/apis/fleet/enrollment-api-keys => x-pack/test/fleet_api_integration/apis/enrollment-api-keys

Misc

  • Also the environment variables to run the test has been renamed FLEET_PACKAGE_REGISTRY_PORT to reflect that change
  • Runame test name ingest_manager_* => fleet_*

@nchaulet nchaulet added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes 7.11.0 labels Nov 9, 2020
@nchaulet nchaulet requested a review from a team as a code owner November 9, 2020 20:05
@nchaulet nchaulet requested a review from a team November 9, 2020 20:05
@nchaulet nchaulet requested review from a team as code owners November 9, 2020 20:05
@nchaulet nchaulet self-assigned this Nov 9, 2020
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Nov 9, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 9, 2020

Pinging @elastic/ingest-management (Team:Ingest Management)

@nchaulet nchaulet force-pushed the feature-rename-ingestmanager-fleet-tests branch from 3a2d78a to 1bb5fb4 Compare November 9, 2020 20:07
@skh
Copy link
Copy Markdown
Contributor

skh commented Nov 10, 2020

@spalger does the rename of the environment variable need a change somewhere in CI?

skh
skh approved these changes Nov 10, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@skh skh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jfsiii jfsiii added v7.11.0 and removed 7.11.0 labels Nov 10, 2020
@nchaulet
Copy link
Copy Markdown
Member Author

nchaulet commented Nov 12, 2020

@elasticmachine merge upstream

spalger
spalger approved these changes Nov 12, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skh rename was already handled by changes in vars/kibanaPipeline.groovy

spalger
spalger reviewed Nov 12, 2020
View reviewed changes
paul-tavares
paul-tavares approved these changes Nov 12, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@paul-tavares paul-tavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@nchaulet
Copy link
Copy Markdown
Member Author

nchaulet commented Nov 12, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Nov 12, 2020

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nchaulet nchaulet merged commit fed9a4f into elastic:master Nov 12, 2020
@nchaulet nchaulet deleted the feature-rename-ingestmanager-fleet-tests branch November 12, 2020 18:51
@nchaulet nchaulet mentioned this pull request Nov 12, 2020
Merged
nchaulet added a commit to nchaulet/kibana that referenced this pull request Nov 12, 2020
@nchaulet
[Fleet] Rename ingest_manager_api_integration tests fleet_api_integra…
19bce25 
…tion (elastic#83011)

# Conflicts:
#	.github/paths-labeller.yml
#	x-pack/scripts/functional_tests.js
nchaulet added a commit that referenced this pull request Nov 12, 2020
@nchaulet
[Fleet] Rename ingest_manager_api_integration tests fleet_api_integra…
acd3e35 
…tion (#83011) (#83326)
gmmorris added a commit to gmmorris/kibana that referenced this pull request Nov 16, 2020
@gmmorris
Merge branch 'master' into alerts/action-groups-as-conditions
c20db06 
* master:
  [Security Solution][Detections] Adds framework for replacing API schemas (elastic#82462)
  [Enterprise Search] Share Loading component (elastic#83246)
  Consolidates Jest configuration files and scripts (elastic#82671)
  APM header changes (elastic#82870)
  [Security Solutions] Adds a default for indicator match custom query of *:* (elastic#81727)
  [Security Solution] Note 10k object paging limit on Endpoint list (elastic#82889)
  [packerCache] fix gulp usage, don't archive node_modules (elastic#83327)
  Upgrade Node.js to version 12 (elastic#61587)
  [Actions] Removing placeholders and updating validation messages on connector forms (elastic#82734)
  [Fleet] Rename ingest_manager_api_integration tests fleet_api_integration (elastic#83011)
  [DOCS] Updates Discover docs (elastic#82773)
  [ML] Data frame analytics: Adds map view (elastic#81666)
  enables actions scoped within the stack to register at Basic license (elastic#82931)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paul-tavares paul-tavares paul-tavares approved these changes

+2 more reviewers

@spalger spalger spalger approved these changes

@skh skh skh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nchaulet nchaulet

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.11.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@nchaulet @elasticmachine @skh @kibanamachine @spalger @paul-tavares @jfsiii