Skip to content

Upgrade Node.js to version 12#61587

Merged
watson merged 33 commits intoelastic:masterfrom
watson:bump-node
Nov 12, 2020
Merged

Upgrade Node.js to version 12#61587
watson merged 33 commits intoelastic:masterfrom
watson:bump-node

Conversation

@watson
Copy link
Copy Markdown
Contributor

@watson watson commented Mar 27, 2020 •
edited
Loading

Depends on #80468

This upgrades the Node.js runtime to a new major version.

For a complete list of changes in the Node.js runtime, see the Node.js CHANGELOG. For only the breaking changes, see the list of notable changes for v11 and v12 respectively.

Closes #47968
Closes #26379

Major changes to Node.js impacting this upgrade

Release note

Upgrades the major Node.js version used by and shipped with Kibana from v10 to v12. This includes support for TLSv1.3 and three new cipher suites: TLS_AES_256_GCM_SHA384, TLS_CHACHA20_POLY1305_SHA256, and TLS_AES_128_GCM_SHA256.

@watson watson self-assigned this Mar 27, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 27, 2020

Pinging @elastic/kibana-app-arch (Team:AppArch)

watson
watson commented Mar 27, 2020
View reviewed changes
@watson watson force-pushed the bump-node branch 3 times, most recently from 6880749 to 7b18da9 Compare April 2, 2020 14:34
oatkiller
oatkiller approved these changes Apr 2, 2020
View reviewed changes
@watson watson force-pushed the bump-node branch 2 times, most recently from a8698ea to 9b80d5b Compare April 6, 2020 17:14
watson
watson commented Apr 6, 2020
View reviewed changes
@watson watson marked this pull request as ready for review April 6, 2020 19:58
@watson watson requested a review from a team April 6, 2020 19:58
@watson watson requested review from a team as code owners April 6, 2020 19:58
@watson watson requested a review from a team April 6, 2020 19:58
@watson watson added v6.8.9 and removed v6.8.8 labels Apr 6, 2020
flash1293
flash1293 approved these changes Nov 10, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lens changes LGTM, it's about the change to stable Array#sort. Even makes it more correct!

mistic
mistic approved these changes Nov 10, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to files under operations team code owners LGTM

sebelga
sebelga approved these changes Nov 11, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@sebelga sebelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM! Now that #83150 has been merged you should be able to remove the skipped test and merge master over this branch. Cheers! 👍

spalger
spalger approved these changes Nov 11, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for doing this @watson!

@tylersmalley tylersmalley mentioned this pull request Nov 12, 2020
Closed
Bamieh
Bamieh approved these changes Nov 12, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@Bamieh Bamieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i18n changes look good. only a trival snapshot update.

ThomThomson
ThomThomson approved these changes Nov 12, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kibana Presentation changes LGTM! Thanks for explaining the Promise / ticks change that happened in Node 11.

@spalger spalger mentioned this pull request Nov 12, 2020
Merged
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 12, 2020

Pinging @elastic/ingest-management (Team:Ingest Management)

nchaulet
nchaulet approved these changes Nov 12, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ingest Management change LGTM

@watson watson mentioned this pull request Nov 12, 2020
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Nov 12, 2020 •
edited
Loading

💔 Build Failed

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 696.3KB 696.2KB -24.0B
monitoring 966.0KB 966.0KB +6.0B
securitySolution 7.9MB 7.9MB +16.0B
total -2.0B

Distributable file count

id before after diff
default 42810 42857 +47
oss 22464 22511 +47

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kibanaUtils 150.2KB 150.4KB +128.0B
spaces 290.4KB 290.4KB +80.0B
upgradeAssistant 74.5KB 74.5KB -24.0B
total +184.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@watson
Copy link
Copy Markdown
Contributor Author

watson commented Nov 12, 2020

FYI: This PR was merged before CI was passing on purpose, knowing that there would be an issue with the TypeScript tests. This is being fixed in master.

@mshustov mshustov mentioned this pull request Nov 16, 2020
Closed
@cnasikas cnasikas mentioned this pull request Jun 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jloleysens jloleysens jloleysens left review comments

@legrego legrego legrego approved these changes

@nchaulet nchaulet nchaulet approved these changes

@flash1293 flash1293 flash1293 approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

@clintandrewhall clintandrewhall clintandrewhall approved these changes

@mikecote mikecote mikecote approved these changes

@mistic mistic mistic approved these changes

@patrykkopycinski patrykkopycinski patrykkopycinski approved these changes

@Bamieh Bamieh Bamieh approved these changes

@tylersmalley tylersmalley tylersmalley approved these changes

@dmlemeshko dmlemeshko dmlemeshko approved these changes

@ThomThomson ThomThomson ThomThomson approved these changes

@justinkambic justinkambic justinkambic approved these changes

@jonathan-buttner jonathan-buttner jonathan-buttner approved these changes

+9 more reviewers

@lizozom lizozom lizozom approved these changes

@cjcenizal cjcenizal cjcenizal approved these changes

@chrisronline chrisronline chrisronline approved these changes

@dgieselaar dgieselaar dgieselaar approved these changes

@oatkiller oatkiller oatkiller approved these changes

@spalger spalger spalger approved these changes

@sebelga sebelga sebelga approved these changes

@sorenlouv sorenlouv sorenlouv approved these changes

@mshustov mshustov mshustov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@watson watson

Labels

Feature:Dependencies release_note:enhancement Team:APM - DEPRECATED Use Team:obs-ux-infra_services. Team:Fleet Team label for Observability Data Collection Fleet team Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.11.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Upgrade to Node 12.x Add TLS 1.3 Support