Merged
Conversation
Contributor
|
Pinging @elastic/kibana-platform (Team:Platform) |
azasypkin
approved these changes
Oct 27, 2020
Contributor
azasypkin
left a comment
There was a problem hiding this comment.
Security/Spaces/ESO plugins changes LGTM.
| * you may not use this file except in compliance with the Elastic License. | ||
| */ | ||
| import * as Rx from 'rxjs'; | ||
| import type { Writable } from '@kbn/utility-types'; |
Contributor
There was a problem hiding this comment.
note: TIL import type, nice!
mikecote
approved these changes
Oct 27, 2020
Contributor
mikecote
left a comment
There was a problem hiding this comment.
Alerting team related code LGTM
cjcenizal
approved these changes
Oct 27, 2020
Contributor
cjcenizal
left a comment
There was a problem hiding this comment.
Change to Index Management test mock LGTM.
lukeelmers
approved these changes
Oct 27, 2020
Contributor
lukeelmers
left a comment
There was a problem hiding this comment.
App arch code change LGTM
pgayvallet
approved these changes
Oct 28, 2020
Contributor
💚 Build SucceededMetrics [docs]distributable file count
History
To update your PR or re-run it, just comment with: |
mshustov
added a commit
to mshustov/kibana
that referenced
this pull request
Oct 28, 2020
* move global typings to packages/kbn-utility-types * update all imports * add tests * mute error * update docs * ok * rename kbn-utility-types/test --> kbn-utility-types/jest
mshustov
added a commit
that referenced
this pull request
Oct 28, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Oct 29, 2020
…kibana into alerts/convert-to-tm-intervals * 'alerts/convert-to-tm-intervals' of github.com:gmmorris/kibana: (88 commits) fixed jest APM Experiments settings (elastic#81554) [Resolver] Enable resolver test plugin tests (elastic#81339) Add TS project references for inspector (elastic#81792) Add uri decode to es_ui_shared and fix navigation issues with special characters (elastic#80835) [Fleet] Rename ingestManager translations fleet (elastic#81837) [Logs UI] Transmit and render array field values in log entries (elastic#81385) Audit Logging: use the original url (elastic#81282) [User experience] Fix JS error rate (elastic#81512) [UX] Add median/percentile info in titles (elastic#79824) Support export for SO with circular refs (elastic#81582) Get rid of global types (elastic#81739) [APM] Fix precommit script (elastic#81594) skips overview tests (elastic#81877) [Security Solution][Case] Fix connector's labeling (elastic#81824) Added simple test, which only covers successful case when edit happened right after task was complete previous execution [Maps] Fix EMS test (elastic#81856) [Security Solutions][Detections] - Fix bug, last response not showing for disabled rules (elastic#81783) skip flaky suite (elastic#81853) Fixed type checks and unit tests ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Global typings create an implicit dependency on environment. This PR refactors the global types:
PublicMethodsOf,MethodKeysOf,Writablearen't global anymore and should be imported from@kbn/utility-types.DeeplyMockedKeys,MockedKeysaren't global anymore (it overlaps withmochatypes) and should be imported from@kbn/utility-types/jest.Note that I didn't remove global type augmentation in
typings/folder.Plugin API changes
We reduced number of global types:
PublicMethodsOf,MethodKeysOf,Writableshould be imported from@kbn/utility-types.DeeplyMockedKeys,MockedKeysshould be imported from@kbn/utility-types/jest.