[UX] Add median/percentile info in titles#79824
Merged
shahzad31 merged 15 commits intoelastic:masterfrom Oct 28, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/uptime (Team:uptime) |
Contributor
|
Pinging @elastic/apm-ui (Team:apm) |
Contributor
Author
|
jenkins run the e2e |
Contributor
Author
|
@elasticmachine merge upstream |
formgeist
approved these changes
Oct 27, 2020
Contributor
formgeist
left a comment
There was a problem hiding this comment.
Just minor label suggestions
x-pack/plugins/apm/public/components/app/RumDashboard/translations.ts
Outdated
Show resolved
Hide resolved
15 tasks
Kerry350
approved these changes
Oct 27, 2020
Contributor
Kerry350
left a comment
There was a problem hiding this comment.
LGTM 👍
One minor thing, is it worth putting: percentile === 50 ? I18LABELS.median : getPercentileLabel(percentile!) into a reusable function as it comes up quite a few times?
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
shahzad31
added a commit
to shahzad31/kibana
that referenced
this pull request
Oct 28, 2020
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
shahzad31
added a commit
to shahzad31/kibana
that referenced
this pull request
Oct 28, 2020
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
shahzad31
added a commit
that referenced
this pull request
Oct 28, 2020
shahzad31
added a commit
that referenced
this pull request
Oct 28, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Oct 29, 2020
…kibana into alerts/convert-to-tm-intervals * 'alerts/convert-to-tm-intervals' of github.com:gmmorris/kibana: (88 commits) fixed jest APM Experiments settings (elastic#81554) [Resolver] Enable resolver test plugin tests (elastic#81339) Add TS project references for inspector (elastic#81792) Add uri decode to es_ui_shared and fix navigation issues with special characters (elastic#80835) [Fleet] Rename ingestManager translations fleet (elastic#81837) [Logs UI] Transmit and render array field values in log entries (elastic#81385) Audit Logging: use the original url (elastic#81282) [User experience] Fix JS error rate (elastic#81512) [UX] Add median/percentile info in titles (elastic#79824) Support export for SO with circular refs (elastic#81582) Get rid of global types (elastic#81739) [APM] Fix precommit script (elastic#81594) skips overview tests (elastic#81877) [Security Solution][Case] Fix connector's labeling (elastic#81824) Added simple test, which only covers successful case when edit happened right after task was complete previous execution [Maps] Fix EMS test (elastic#81856) [Security Solutions][Detections] - Fix bug, last response not showing for disabled rules (elastic#81783) skip flaky suite (elastic#81853) Fixed type checks and unit tests ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed point 17 from issue #78261
Added information to display whether the displayed metric is median, 75th Percentile to reflect selected calculation method.
Renamed User experience metrics, to just metrics
Also renamed page view to Total page views to make it more clear that it's not median
In the URL search, for individual page load duration
