Merged
Conversation
* Register advanced settings in server startup that show in the Kibana advanced settings UI. (Fixes elastic#81396.) * Format settings pages to be more consistent.
7bc27bf to
5e032f8
Compare
ogupte
reviewed
Oct 27, 2020
|
|
||
| const overviewTab = { | ||
| link: ( | ||
| <a title="UNDER CONSTRUCTION" href="#"> |
Contributor
There was a problem hiding this comment.
is UNDER CONSTRUCTION intentional because it's an experiment?
Contributor
Author
There was a problem hiding this comment.
Yes. It's just a placeholder and behind the flag and will be replaced in #81718.
Contributor
|
Pinging @elastic/apm-ui (Team:apm) |
ogupte
reviewed
Oct 27, 2020
|
|
||
| if (uiSettings.get(enableServiceOverview)) { | ||
| tabs.unshift(overviewTab); | ||
| } |
Contributor
There was a problem hiding this comment.
Since we're initializing tabs here anyways we can avoid an array mutation:
const tabs = uiSettings.get(enableServiceOverview) ?
[overviewTab, transactionsTab, errorsTab, serviceMapTab] :
[transactionsTab, errorsTab, serviceMapTab];
Contributor
Author
There was a problem hiding this comment.
I left the mutation since we're pushing on to the array later anyway and I thought is was clearer.
ogupte
reviewed
Oct 27, 2020
x-pack/plugins/apm/public/components/app/Settings/ApmIndices/index.tsx
Outdated
Show resolved
Hide resolved
Contributor
Author
|
retest |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
retest |
Contributor
💚 Build SucceededMetrics [docs]@kbn/optimizer bundle module count
async chunks size
distributable file count
History
To update your PR or re-run it, just comment with: |
smith
added a commit
to smith/kibana
that referenced
this pull request
Oct 28, 2020
* Add advanced settings for APM * Register advanced settings in server startup that show in the Kibana advanced settings UI. (Fixes elastic#81396.) * Format settings pages to be more consistent.
smith
added a commit
that referenced
this pull request
Oct 28, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Oct 29, 2020
…kibana into alerts/convert-to-tm-intervals * 'alerts/convert-to-tm-intervals' of github.com:gmmorris/kibana: (88 commits) fixed jest APM Experiments settings (elastic#81554) [Resolver] Enable resolver test plugin tests (elastic#81339) Add TS project references for inspector (elastic#81792) Add uri decode to es_ui_shared and fix navigation issues with special characters (elastic#80835) [Fleet] Rename ingestManager translations fleet (elastic#81837) [Logs UI] Transmit and render array field values in log entries (elastic#81385) Audit Logging: use the original url (elastic#81282) [User experience] Fix JS error rate (elastic#81512) [UX] Add median/percentile info in titles (elastic#79824) Support export for SO with circular refs (elastic#81582) Get rid of global types (elastic#81739) [APM] Fix precommit script (elastic#81594) skips overview tests (elastic#81877) [Security Solution][Case] Fix connector's labeling (elastic#81824) Added simple test, which only covers successful case when edit happened right after task was complete previous execution [Maps] Fix EMS test (elastic#81856) [Security Solutions][Detections] - Fix bug, last response not showing for disabled rules (elastic#81783) skip flaky suite (elastic#81853) Fixed type checks and unit tests ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.