[Logs UI] Transmit and render array field values in log entries#81385
Merged
afgomez merged 23 commits intoelastic:masterfrom Oct 28, 2020
Merged
[Logs UI] Transmit and render array field values in log entries#81385afgomez merged 23 commits intoelastic:masterfrom
afgomez merged 23 commits intoelastic:masterfrom
Conversation
The values will be returned as arrays of strings to match the response of the log entries API. The UI is now responsible to decide how render the fields.
Contributor
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
Contributor
💚 Build SucceededMetrics [docs]@kbn/optimizer bundle module count
async chunks size
page load bundle size
History
To update your PR or re-run it, just comment with: |
weltenwort
commented
Oct 28, 2020
Member
Author
weltenwort
left a comment
There was a problem hiding this comment.
Your additions LGTM and I don't yet regret any of my own changes. 😬 Log entries seem to render correctly everywhere I remembered to check. GitHub won't let me approve my own PR, though. 😉
Thanks again for picking this up! ❤️
This was referenced Oct 28, 2020
afgomez
added a commit
to afgomez/kibana
that referenced
this pull request
Oct 28, 2020
…tic#81385) Co-authored-by: Alejandro Fernández Gómez <antarticonorte@gmail.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Oct 29, 2020
…kibana into alerts/convert-to-tm-intervals * 'alerts/convert-to-tm-intervals' of github.com:gmmorris/kibana: (88 commits) fixed jest APM Experiments settings (elastic#81554) [Resolver] Enable resolver test plugin tests (elastic#81339) Add TS project references for inspector (elastic#81792) Add uri decode to es_ui_shared and fix navigation issues with special characters (elastic#80835) [Fleet] Rename ingestManager translations fleet (elastic#81837) [Logs UI] Transmit and render array field values in log entries (elastic#81385) Audit Logging: use the original url (elastic#81282) [User experience] Fix JS error rate (elastic#81512) [UX] Add median/percentile info in titles (elastic#79824) Support export for SO with circular refs (elastic#81582) Get rid of global types (elastic#81739) [APM] Fix precommit script (elastic#81594) skips overview tests (elastic#81877) [Security Solution][Case] Fix connector's labeling (elastic#81824) Added simple test, which only covers successful case when edit happened right after task was complete previous execution [Maps] Fix EMS test (elastic#81856) [Security Solutions][Detections] - Fix bug, last response not showing for disabled rules (elastic#81783) skip flaky suite (elastic#81853) Fixed type checks and unit tests ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This ensures that all field values that are retrieved via the
fieldsparameter are used instead of only the first one.closes #79838