Skip to content

Adds some missing licenses to the CSV export#78719

Merged
tylersmalley merged 3 commits intoelastic:masterfrom
tylersmalley:additional-license-csv
Sep 30, 2020
Merged

Adds some missing licenses to the CSV export#78719
tylersmalley merged 3 commits intoelastic:masterfrom
tylersmalley:additional-license-csv

Conversation

@tylersmalley
Copy link
Copy Markdown
Member

@tylersmalley tylersmalley commented Sep 29, 2020 •
edited
Loading

When adding the UBI license, I realized the Node license also wasn't being included. An additional column sourceURL was also required to be added. This will ensure it's present on https://artifacts.elastic.co/reports/dependencies/dependencies-current.html#kibana-7.9.2

name,version,url,license,sourceURL
"Node.js","10.22.1","https://nodejs.org","MIT",
"Red Hat Universal Base Image minimal",,"https://catalog.redhat.com/software/containers/ubi8/ubi-minimal/5c359a62bed8bd75a2c3fba8","Custom;https://www.redhat.com/licenses/EULA_Red_Hat_Universal_Base_Image_English_20190422.pdf","https://oss-dependencies.elastic.co/redhat/ubi/ubi-minimal-8-source.tar.gz"
"@babel/code-frame","7.10.4","https://github.com/babel/babel","MIT",
"@babel/core","7.11.1","https://github.com/babel/babel","MIT",
"@babel/generator","7.11.0","https://github.com/babel/babel","MIT",
"@babel/helper-function-name","7.10.4","https://github.com/babel/babel","MIT",
"@babel/helper-get-function-arity","7.10.4","https://github.com/babel/babel","MIT",
...

@tylersmalley
Adds some missing licenses to the CSV export
73faa89 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley tylersmalley added Team:Operations Kibana-Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Sep 29, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 29, 2020

Pinging @elastic/kibana-operations (Team:Operations)

spalger
spalger approved these changes Sep 29, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tylersmalley tylersmalley requested a review from mgreau September 29, 2020 04:09
@tylersmalley
Adds sourceURL column, required for UBI
6d0ddc3 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
mgreau
mgreau reviewed Sep 29, 2020
View reviewed changes
mgreau
mgreau approved these changes Sep 29, 2020
View reviewed changes
Copy link
Copy Markdown

@mgreau mgreau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one typo, otherwise LGTM.
Thanks 🙏

@tylersmalley
Update tasks/licenses_csv_report.js
fe83fcc 
Co-authored-by: Maxime Gréau <maxime.greau@elastic.co>
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Sep 30, 2020

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tylersmalley tylersmalley merged commit 5f5ef2b into elastic:master Sep 30, 2020
@tylersmalley tylersmalley mentioned this pull request Sep 30, 2020
Merged
tylersmalley added a commit to tylersmalley/kibana that referenced this pull request Sep 30, 2020
@tylersmalley
Adds some missing licenses to the CSV export (elastic#78719)
449d09c 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Sep 30, 2020
@gmmorris
Merge branch 'master' into actions/preconfigured-connector-error-on-edit
73b710b 
* master: (97 commits)
  [Actions] Adds a "Test Connector" button on the Connectors List to make discovery of the Test tab easier (elastic#78746)
  [Discover] Fix functional time picker test permissions (elastic#78564)
  [ML] Fixing module datafeed overrides (elastic#78925)
  Adds some missing licenses to the CSV export (elastic#78719)
  [dev/cli] ensure plugins/ and all watch source dirs exist (elastic#78973)
  [Lens] Stop using scripted metric to collect telemetry (elastic#78687)
  [Lens] fix wrong message in fields accordion (elastic#78924)
  [Enterprise Search][App Search] Credentials Logic updates (elastic#78644)
  [Monitoring] Disk usage alerting (elastic#75419)
  [SECURITY_SOLUTION] Trusted apps list expand/collapse details (elastic#78601)
  Update content on interstitial page (elastic#78881)
  chore(NA): include hjson as a prod dependency (elastic#78941)
  Fix empty meta fields input in Advanced Settings  (elastic#78576)
  [Lens] Maintain order of operations in dimension panel (elastic#78864)
  Fix plugin doc title (elastic#78880)
  load apm-rum agent lazily (elastic#78760)
  [ML] Skip full ML access permission test
  Optimize charts plugin (elastic#78922)
  ui_actions service initial docs (elastic#78902)
  skip failing suite (elastic#78942)
  ...
phillipb added a commit to phillipb/kibana that referenced this pull request Sep 30, 2020
@phillipb
Merge branch 'master' of github.com:elastic/kibana into override-anom…
1587918 
…aly-detection-partition-field

* 'master' of github.com:elastic/kibana: (37 commits)
  Fixes for the Ticket 78375 (elastic#79004)
  [Security] Alert Telemetry for the Security app (elastic#77200)
  [Search bar] Remove duplicate `popoverProps` (elastic#79025)
  [Security Solution][Detections] Add rule overrides for single event EQL rules (elastic#78876)
  [SECURITY_SOLUTION][ENDPOINT] Improve Endpoint Host data generator to also integrate with Ingest (elastic#74305)
  remove file accidentally checked in (elastic#79005)
  [ML] DF Analytics creation wizard: replace select input with job type cards with icons (elastic#78872)
  [Design] A couple fixes for 7.10 (elastic#78801)
  Fix KQL autocomplete value suggestions (elastic#78676)
  [Security Solution][Resolver] New mock with cursor (elastic#78863)
  Embeddables: basic documentation (elastic#78900)
  [security solution] only import beat_schema when needed (elastic#78708)
  [Reporting] API Integration tests: fix flaky tests for Spaces CSV formatting (elastic#78849)
  [Actions] Adds a "Test Connector" button on the Connectors List to make discovery of the Test tab easier (elastic#78746)
  [Discover] Fix functional time picker test permissions (elastic#78564)
  [ML] Fixing module datafeed overrides (elastic#78925)
  Adds some missing licenses to the CSV export (elastic#78719)
  [dev/cli] ensure plugins/ and all watch source dirs exist (elastic#78973)
  [Lens] Stop using scripted metric to collect telemetry (elastic#78687)
  [Lens] fix wrong message in fields accordion (elastic#78924)
  ...
tylersmalley added a commit that referenced this pull request Sep 30, 2020
@tylersmalley
Adds some missing licenses to the CSV export (#78719) (#79003)
8d6de20 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@mgreau mgreau mgreau approved these changes

@spalger spalger spalger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v7.10.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tylersmalley @elasticmachine @kibanamachine @mgreau @spalger